From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Andi Shyti <andi.shyti@linux.intel.com>,
Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use i915 instead of dev_priv as name for the private device
Date: Tue, 14 Feb 2023 11:00:37 +0000 [thread overview]
Message-ID: <34f2ea0f-5cf3-ef58-2a40-0d1e194147de@linux.intel.com> (raw)
In-Reply-To: <Y+tk5zUKbOCVHHGV@ashyti-mobl2.lan>
On 14/02/2023 10:39, Andi Shyti wrote:
> Hi,
>
> On Mon, Feb 13, 2023 at 03:36:54PM -0800, Lucas De Marchi wrote:
>> On Mon, Feb 13, 2023 at 02:11:26PM +0100, Das, Nirmoy wrote:
>>>
>>> On 2/10/2023 4:03 PM, Andi Shyti wrote:
>>>> It is becoming a strong habit to call the drm_i915_private
>>>> structures "i915", but there are still many left that are called
>>>> dev_priv.
>>>>
>>>> Sometimes this makes grepping a bit challenging and anyway it
>>>> keeps a coherent style.
>>>>
>>>> Rename all the "dev_priv" structures in the gt/* directory to
>>>> "i915".
>>>>
>>>> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
>>>> ---
>>>> Hi,
>>>>
>>>> just checking if we want something similar. I have this same
>>>> replicated patch for the rest of i915 but I want to make sure we
>>>> actually want it.
>
> Thanks Nirmoy for the review!
>
>>> I might be lacking historical context here but I assumption is we are
>>> moving towards replacing dev_priv with i915 everywhere.
>>
>> Context: 20230201135329.514677-1-luciano.coelho@intel.com and 87bkml5wv4.fsf@intel.com
>
> I think I have everything fixed, just didn't have time to format
> patches correctly. So that I decided to take this baby step
> to test the ground first and then move forward in the next couple
> of weeks.
>
> I don't think this patch that affects only the content of "gt/"
> has any dependency on dev_priv macros so that please let me know
> if anyone has anything against.
No complaints, to the contrary!
Acked-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
next prev parent reply other threads:[~2023-02-14 11:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:03 [Intel-gfx] [PATCH] drm/i915/gt: Use i915 instead of dev_priv as name for the private device Andi Shyti
2023-02-10 19:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-11 13:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-13 13:11 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2023-02-13 15:31 ` Jani Nikula
2023-02-13 23:36 ` Lucas De Marchi
2023-02-14 10:39 ` Andi Shyti
2023-02-14 11:00 ` Tvrtko Ursulin [this message]
2023-02-14 11:32 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34f2ea0f-5cf3-ef58-2a40-0d1e194147de@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.