From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Das, Nirmoy" <nirmoy.das@linux.intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Use i915 instead of dev_priv as name for the private device
Date: Mon, 13 Feb 2023 17:31:46 +0200 [thread overview]
Message-ID: <87pmadvaxp.fsf@intel.com> (raw)
In-Reply-To: <17d5dc0d-4bb9-6e13-bac1-8d1e7aad3f17@linux.intel.com>
On Mon, 13 Feb 2023, "Das, Nirmoy" <nirmoy.das@linux.intel.com> wrote:
> On 2/10/2023 4:03 PM, Andi Shyti wrote:
>> It is becoming a strong habit to call the drm_i915_private
>> structures "i915", but there are still many left that are called
>> dev_priv.
>>
>> Sometimes this makes grepping a bit challenging and anyway it
>> keeps a coherent style.
>>
>> Rename all the "dev_priv" structures in the gt/* directory to
>> "i915".
>>
>> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
>> ---
>> Hi,
>>
>> just checking if we want something similar. I have this same
>> replicated patch for the rest of i915 but I want to make sure we
>> actually want it.
>
> I might be lacking historical context here but I assumption is we are
> moving towards replacing dev_priv with i915 everywhere.
Yes. The implicit dev_priv still present in some of the register macros
is the only reason not to convert, and even in those cases we should
look into fixing that too.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2023-02-13 15:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:03 [Intel-gfx] [PATCH] drm/i915/gt: Use i915 instead of dev_priv as name for the private device Andi Shyti
2023-02-10 19:02 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-11 13:31 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-02-13 13:11 ` [Intel-gfx] [PATCH] " Das, Nirmoy
2023-02-13 15:31 ` Jani Nikula [this message]
2023-02-13 23:36 ` Lucas De Marchi
2023-02-14 10:39 ` Andi Shyti
2023-02-14 11:00 ` Tvrtko Ursulin
2023-02-14 11:32 ` Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmadvaxp.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nirmoy.das@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.