All of lore.kernel.org
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Zhouqi Jiang <luojia@rustsbi.com>, u-boot@lists.u-boot-project.org
Cc: trini@konsulko.com, tim609@andestech.com, leo.liang@sifive.com,
	me@ziyao.cc, sjg@chromium.org, alpernebiyasak@gmail.com,
	jiangzhouqi2025@iscas.ac.cn, plucky@rustsbi.com,
	Chao Liu <chao.liu@processmission.com>,
	Daniel Maslowski <info@orangecms.org>
Subject: Re: [PATCH v2 3/3] riscv: Document SBI firmware support in SPL
Date: Thu, 19 Nov 2026 03:14:57 -0800	[thread overview]
Message-ID: <35001dcd-3fec-48a9-8b1f-e2cc68c644b8@freeshell.de> (raw)
In-Reply-To: <356792A791E175F1+20261119091842.3062208-4-luojia@rustsbi.com>

Hi Zhougi,

On 11/19/26 01:18, Zhouqi Jiang wrote:
> Document how to supply OpenSBI and RustSBI Prototyper dynamic
> firmware to the existing SPL handoff. Explain the firmware load
> address, the FIT OS label, and how each implementation handles
> SPL_OPENSBI_SCRATCH_OPTIONS.
> 
> Mention RustSBI compatibility in the SPL Kconfig help so users can
> find it when configuring U-Boot.
> 
> Signed-off-by: Zhouqi Jiang <luojia@rustsbi.com>
> ---
> Changes in v2:
> - Document the shared handoff in the RISC-V architecture guide.
> - Explain scratch options in the architecture guide and SPL help.
> 
>  common/spl/Kconfig |  8 +++++++-
>  doc/arch/riscv.rst | 17 +++++++++++++++++
>  2 files changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/common/spl/Kconfig b/common/spl/Kconfig
> index 4930ecb0861..07548094e38 100644
> --- a/common/spl/Kconfig
> +++ b/common/spl/Kconfig
> @@ -1744,7 +1744,10 @@ config SPL_OPENSBI
>  	  Interface (SBI) specification. U-Boot supports the OpenSBI FW_DYNAMIC
>  	  firmware. It is loaded and started by U-Boot SPL.
>  
> -	  More details are available at https://github.com/riscv/opensbi and
> +	  RustSBI Prototyper dynamic firmware also supports this handoff.

How is 'RustSBI Prototyper' distinct from 'RustSBI'. Is this a
registered trademark? Is it a company name?

It should be enough to simply introduce that SBI implementations can be
passed to the build process with OPENSBI= and then to list (in 'LANG=C
sort' order) or link to specific build instructions for the available
implementations where different from OpenSBI.

> +
> +	  More details are available at https://github.com/riscv/opensbi,
the trailing comma at the end of URL here is problematic since it is a
valid component of any URI

> +	  https://github.com/rustsbi/rustsbi and
>  	  https://github.com/riscv/riscv-sbi-doc
>  
>  config SPL_OPENSBI_LOAD_ADDR
> @@ -1763,6 +1766,9 @@ config SPL_OPENSBI_SCRATCH_OPTIONS
>  	  - SBI_SCRATCH_NO_BOOT_PRINTS = 0x1 (Disable prints during boot)
>  	  - SBI_SCRATCH_DEBUG_PRINTS   = 0x2 (Enable runtime debug prints)
>  
> +	  RustSBI Prototyper currently does not use these options. See the
> +	  RISC-V architecture documentation for details.
> +

What does the RISC-V architecture documentation have to say about
'RustSBI Prototyper' lacking support for OpenSBI scratch options. This
sounds like four unrelated topics in one sentence.

>  config SPL_TARGET
>  	string "Addtional build targets for 'make'"
>  	default "spl/u-boot-spl.srec" if RCAR_GEN2
> diff --git a/doc/arch/riscv.rst b/doc/arch/riscv.rst
> index af0c48b8982..dc4cc853baa 100644
> --- a/doc/arch/riscv.rst
> +++ b/doc/arch/riscv.rst
> @@ -72,6 +72,23 @@ To examine the boot process with the QEMU virt machine, you can follow the
>  steps in the "Running U-Boot SPL" section of the following document:
>  :doc:`../board/emulation/qemu-riscv`.
>  
> +SBI firmware for SPL
> +--------------------
> +
> +With ``CONFIG_SPL_OPENSBI``, SPL passes FW_DYNAMIC handoff information to
> +the firmware loaded from the FIT image. Supported implementations include:

U-Boot main app build for SpacemiT K3 packages OpenSBI fw_dynamic.bin
and so I'm not understanding this explanation you have provided.

$ ls build/opensbi/platform/generic/firmware/fw_*bin
build/opensbi/platform/generic/firmware/fw_dynamic.bin
build/opensbi/platform/generic/firmware/fw_jump.bin
build/opensbi/platform/generic/firmware/fw_payload.bin

At some point in OpenSBI development, if I remember correctly v1.5 tag
or so, fw_dynamic.bin transitioned to be built fully dynamic /
relocatable. Previous to then it required the .text section address
specified at build time.

> +
> +* `OpenSBI FW_DYNAMIC <https://github.com/riscv-software-src/opensbi>`_.
> +* `RustSBI Prototyper dynamic firmware <https://github.com/rustsbi/rustsbi/tree/main/firmware>`_.
> +
> +Provide the firmware using either ``OPENSBI=/path/to/firmware.bin`` or
> +``RUSTSBI=/path/to/firmware.bin``. Its link address must match
> +``CONFIG_SPL_OPENSBI_LOAD_ADDR``. Both use the ``opensbi`` FIT OS label.
> +
> +``CONFIG_SPL_OPENSBI_SCRATCH_OPTIONS`` passes options to the firmware. OpenSBI
> +uses ``0x1`` to disable boot prints and ``0x2`` for runtime debug prints;

It could be 0x3 for both options?

> +RustSBI Prototyper currently ignores these options.
> +

Is that a bug? Why mention this, here?

>  Toolchain
>  ---------
>  

-E

  reply	other threads:[~2026-11-19 11:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 14:38 [PATCH] riscv: Add RustSBI firmware support Zhouqi Jiang
2026-11-15 17:10 ` Tom Rini
2026-11-16  5:42   ` Zhouqi Jiang
2026-11-16 13:02     ` Yao Zi
2026-11-16 15:15       ` Zhouqi Jiang
2026-11-19 11:41         ` Yao Zi
2026-11-19 12:00           ` Zhouqi Jiang
2026-11-16 12:45 ` Yao Zi
2026-11-19  9:18 ` [PATCH v2 0/3] riscv: Support RustSBI through the FW_DYNAMIC handoff Zhouqi Jiang
2026-11-19 10:31   ` E Shattow
     [not found] ` <20261119091842.3062208-1-luojia@rustsbi.com>
2026-11-19  9:18   ` [PATCH v2 1/3] riscv: Describe SBI_V02 in terms of the SBI version Zhouqi Jiang
2026-11-19 10:43     ` E Shattow
2026-11-19 12:08       ` Yao Zi
2026-11-19  9:18   ` [PATCH v2 2/3] binman: Accept RUSTSBI as an alias for OPENSBI Zhouqi Jiang
2026-11-19 10:47     ` E Shattow
2026-11-19  9:18   ` [PATCH v2 3/3] riscv: Document SBI firmware support in SPL Zhouqi Jiang
2026-11-19 11:14     ` E Shattow [this message]
2026-11-19 12:05       ` Zhouqi Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35001dcd-3fec-48a9-8b1f-e2cc68c644b8@freeshell.de \
    --to=e@freeshell.de \
    --cc=alpernebiyasak@gmail.com \
    --cc=chao.liu@processmission.com \
    --cc=info@orangecms.org \
    --cc=jiangzhouqi2025@iscas.ac.cn \
    --cc=leo.liang@sifive.com \
    --cc=luojia@rustsbi.com \
    --cc=me@ziyao.cc \
    --cc=plucky@rustsbi.com \
    --cc=sjg@chromium.org \
    --cc=tim609@andestech.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.