All of lore.kernel.org
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: Zhouqi Jiang <luojia@rustsbi.com>, u-boot@lists.u-boot-project.org
Cc: trini@konsulko.com, tim609@andestech.com, leo.liang@sifive.com,
	me@ziyao.cc, sjg@chromium.org, alpernebiyasak@gmail.com,
	jiangzhouqi2025@iscas.ac.cn, plucky@rustsbi.com,
	Chao Liu <chao.liu@processmission.com>,
	Daniel Maslowski <info@orangecms.org>
Subject: Re: [PATCH v2 2/3] binman: Accept RUSTSBI as an alias for OPENSBI
Date: Thu, 19 Nov 2026 02:47:17 -0800	[thread overview]
Message-ID: <b25fff6f-7db4-49bb-b68f-e7d7555ff155@freeshell.de> (raw)
In-Reply-To: <D5BE1F0AB7875B8C+20261119091842.3062208-3-luojia@rustsbi.com>

Hi Zhougi,

On 11/19/26 01:18, Zhouqi Jiang wrote:
> RustSBI Prototyper dynamic firmware accepts the FW_DYNAMIC handoff
> used by the existing opensbi FIT entry. Let users pass its binary
> with RUSTSBI= and forward it to the same binman entry. Reject builds
> which specify both firmware inputs to make the choice explicit.
> 
> Exercise the opensbi entry with an alternate firmware filename and
> describe the RustSBI input in the missing-blob help.
> 
> Signed-off-by: Zhouqi Jiang <luojia@rustsbi.com>
> ---
> Would you prefer to keep RUSTSBI= as an alias for the existing
> firmware input, or use OPENSBI= for both implementations?
> 
> Changes in v2:
> - Route RUSTSBI through the existing opensbi entry.
> - Reject simultaneous OPENSBI and RUSTSBI inputs.
> - Test the shared entry and update its missing-blob help.
> 
>  Makefile                       | 6 ++++--
>  tools/binman/ftest.py          | 9 +++++++++
>  tools/binman/missing-blob-help | 2 ++
>  3 files changed, 15 insertions(+), 2 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 519866b82ea..85638310395 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1679,7 +1679,9 @@ endif
>  endif
>  
>  quiet_cmd_binman = BINMAN  $@
> -cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
> +cmd_binman = $(if $(and $(strip $(OPENSBI)),$(strip $(RUSTSBI))), \
> +		$(error Specify only one of OPENSBI and RUSTSBI)) \
> +		$(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>  		$(foreach f,$(BINMAN_TOOLPATHS),--toolpath $(f)) \
>                  --toolpath $(objtree)/tools \
>  		$(if $(BINMAN_VERBOSE),-v$(BINMAN_VERBOSE)) \
> @@ -1694,7 +1696,7 @@ cmd_binman = $(srctree)/tools/binman/binman $(if $(BINMAN_DEBUG),-D) \
>  		-a atf-bl31-path=${BL31} \
>  		-a tee-os-path=${TEE} \
>  		-a ti-dm-path=${TI_DM} \
> -		-a opensbi-path=${OPENSBI} \
> +		-a opensbi-path=$(if $(strip $(RUSTSBI)),${RUSTSBI},${OPENSBI}) \
>  		-a default-dt=$(default_dt) \
>  		-a scp-path=$(SCP) \
>  		-a rockchip-tpl-path=$(ROCKCHIP_TPL) \
> diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
> index 567ffa96b2b..e8b58ce2ea8 100644
> --- a/tools/binman/ftest.py
> +++ b/tools/binman/ftest.py
> @@ -97,6 +97,7 @@ TEE_OS_DATA           = b'this is some tee OS data'
>  TI_DM_DATA            = b'tidmtidm'
>  ATF_BL2U_DATA         = b'bl2u'
>  OPENSBI_DATA          = b'opensbi'
> +RUSTSBI_DATA          = b'rustsbi'
>  SCP_DATA              = b'scp'
>  ROCKCHIP_TPL_DATA     = b'rockchip-tpl'
>  TEST_FDT1_DATA        = b'fdt1'
> @@ -236,6 +237,7 @@ class TestFunctional(unittest.TestCase):
>          TestFunctional._MakeInputFile('dm.bin', TI_DM_DATA)
>          TestFunctional._MakeInputFile('bl2u.bin', ATF_BL2U_DATA)
>          TestFunctional._MakeInputFile('fw_dynamic.bin', OPENSBI_DATA)
> +        TestFunctional._MakeInputFile('rustsbi.bin', RUSTSBI_DATA)
>          TestFunctional._MakeInputFile('scp.bin', SCP_DATA)
>          TestFunctional._MakeInputFile('rockchip-tpl.bin', ROCKCHIP_TPL_DATA)
>          TestFunctional._MakeInputFile('ti_unsecure.bin', TI_UNSECURE_DATA)
> @@ -5059,6 +5061,13 @@ class TestFunctional(unittest.TestCase):
>          data = self._DoReadFile('fip/opensbi.dts')
>          self.assertEqual(OPENSBI_DATA, data[:len(OPENSBI_DATA)])
>  
> +    def testPackRustSBIWithOpenSBIEntry(self):
> +        """Test RustSBI firmware as input to the existing OpenSBI entry"""
> +        data = self._DoReadFileDtb(
> +            'fip/opensbi.dts',
> +            entry_args={'opensbi-path': 'rustsbi.bin'})[0]
> +        self.assertEqual(RUSTSBI_DATA, data)
> +
>      def testSectionsSingleThread(self):
>          """Test sections without multithreading"""
>          data = self._DoReadFileDtb('entry/sections.dts', threads=0)[0]
> diff --git a/tools/binman/missing-blob-help b/tools/binman/missing-blob-help
> index 27dc620bd35..8020e6cca76 100644
> --- a/tools/binman/missing-blob-help
> +++ b/tools/binman/missing-blob-help
> @@ -37,6 +37,8 @@ See the documentation for your board. The OpenSBI git repo is at
>  https://github.com/riscv/opensbi.git
>  You may need to build fw_dynamic.bin first and re-build u-boot with
>  OPENSBI=/path/to/fw_dynamic.bin
> +RustSBI Prototyper dynamic firmware can be supplied with
> +RUSTSBI=/path/to/rustsbi-prototyper-dynamic.bin
>  
>  rockchip-tpl:
>  An external TPL is required to initialize DRAM. Get the external TPL

NAK.  No alias additional to OPENSBI=, please.

-E

  reply	other threads:[~2026-11-19 10:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 14:38 [PATCH] riscv: Add RustSBI firmware support Zhouqi Jiang
2026-11-15 17:10 ` Tom Rini
2026-11-16  5:42   ` Zhouqi Jiang
2026-11-16 13:02     ` Yao Zi
2026-11-16 15:15       ` Zhouqi Jiang
2026-11-19 11:41         ` Yao Zi
2026-11-19 12:00           ` Zhouqi Jiang
2026-11-16 12:45 ` Yao Zi
2026-11-19  9:18 ` [PATCH v2 0/3] riscv: Support RustSBI through the FW_DYNAMIC handoff Zhouqi Jiang
2026-11-19 10:31   ` E Shattow
     [not found] ` <20261119091842.3062208-1-luojia@rustsbi.com>
2026-11-19  9:18   ` [PATCH v2 1/3] riscv: Describe SBI_V02 in terms of the SBI version Zhouqi Jiang
2026-11-19 10:43     ` E Shattow
2026-11-19 12:08       ` Yao Zi
2026-11-19  9:18   ` [PATCH v2 2/3] binman: Accept RUSTSBI as an alias for OPENSBI Zhouqi Jiang
2026-11-19 10:47     ` E Shattow [this message]
2026-11-19  9:18   ` [PATCH v2 3/3] riscv: Document SBI firmware support in SPL Zhouqi Jiang
2026-11-19 11:14     ` E Shattow
2026-11-19 12:05       ` Zhouqi Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b25fff6f-7db4-49bb-b68f-e7d7555ff155@freeshell.de \
    --to=e@freeshell.de \
    --cc=alpernebiyasak@gmail.com \
    --cc=chao.liu@processmission.com \
    --cc=info@orangecms.org \
    --cc=jiangzhouqi2025@iscas.ac.cn \
    --cc=leo.liang@sifive.com \
    --cc=luojia@rustsbi.com \
    --cc=me@ziyao.cc \
    --cc=plucky@rustsbi.com \
    --cc=sjg@chromium.org \
    --cc=tim609@andestech.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.