From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi
Date: Sun, 31 Mar 2019 16:01:15 +0200 [thread overview]
Message-ID: <3503295.Ps5hWAbIar@phil> (raw)
In-Reply-To: <20190330095639.14626-2-jbx6244@gmail.com>
Hi Johan,
Am Samstag, 30. März 2019, 10:56:36 CEST schrieb Johan Jonker:
> From: Zheng Yang <zhengyang@rock-chips.com>
>
> The RK3066 HDMI TX serves as interface between a LCD Controller and
> a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and
> one HDMI transmitter PHY. The interface has three (3) 8-bit data channels
> which can be configured for a number of bus widths (8/10/12/16/20/24-bit)
> and different video formats (RGB, YCbCr).
>
> Features:
> HDMI version 1.4a, HDCP revision 1.4 and
> DVI version 1.0 compliant transmitter.
> Supports DTV resolutions from 480i to 1080i/p HD.
> Master I2C interface for a DDC connection.
> HDMI TX supports multiple power save modes.
> The HDMI TX input can switch between LCDC0 and LCDC1.
> (Sound support is not included in this patch)
>
> Signed-off-by: Zheng Yang <zhengyang@rock-chips.com>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
applied to drm-misc-next with a smallish change as described below,
please double check. [0]
> +static int
> +rk3066_hdmi_probe_single_connector_modes(struct drm_connector *connector,
> + uint32_t maxX, uint32_t maxY)
> +{
instead of
> + return drm_helper_probe_single_connector_modes(connector, 1920, 1080);
it is now doing
+ if (maxX > 1920)
+ maxX = 1920;
+ if (maxY > 1080)
+ maxY = 1080;
+
+ return drm_helper_probe_single_connector_modes(connector, maxX, maxY);
to take into account maxX / maxY being already below 1920x1080
> +}
Heiko
[0] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f84d3d37b7fbb022e33b79d54374466f6fbc7186
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
airlied@linux.ie, hjc@rock-chips.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi
Date: Sun, 31 Mar 2019 16:01:15 +0200 [thread overview]
Message-ID: <3503295.Ps5hWAbIar@phil> (raw)
In-Reply-To: <20190330095639.14626-2-jbx6244@gmail.com>
Hi Johan,
Am Samstag, 30. März 2019, 10:56:36 CEST schrieb Johan Jonker:
> From: Zheng Yang <zhengyang@rock-chips.com>
>
> The RK3066 HDMI TX serves as interface between a LCD Controller and
> a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and
> one HDMI transmitter PHY. The interface has three (3) 8-bit data channels
> which can be configured for a number of bus widths (8/10/12/16/20/24-bit)
> and different video formats (RGB, YCbCr).
>
> Features:
> HDMI version 1.4a, HDCP revision 1.4 and
> DVI version 1.0 compliant transmitter.
> Supports DTV resolutions from 480i to 1080i/p HD.
> Master I2C interface for a DDC connection.
> HDMI TX supports multiple power save modes.
> The HDMI TX input can switch between LCDC0 and LCDC1.
> (Sound support is not included in this patch)
>
> Signed-off-by: Zheng Yang <zhengyang@rock-chips.com>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
applied to drm-misc-next with a smallish change as described below,
please double check. [0]
> +static int
> +rk3066_hdmi_probe_single_connector_modes(struct drm_connector *connector,
> + uint32_t maxX, uint32_t maxY)
> +{
instead of
> + return drm_helper_probe_single_connector_modes(connector, 1920, 1080);
it is now doing
+ if (maxX > 1920)
+ maxX = 1920;
+ if (maxY > 1080)
+ maxY = 1080;
+
+ return drm_helper_probe_single_connector_modes(connector, maxX, maxY);
to take into account maxX / maxY being already below 1920x1080
> +}
Heiko
[0] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f84d3d37b7fbb022e33b79d54374466f6fbc7186
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: hjc@rock-chips.com, airlied@linux.ie, daniel@ffwll.ch,
robh+dt@kernel.org, mark.rutland@arm.com,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi
Date: Sun, 31 Mar 2019 16:01:15 +0200 [thread overview]
Message-ID: <3503295.Ps5hWAbIar@phil> (raw)
In-Reply-To: <20190330095639.14626-2-jbx6244@gmail.com>
Hi Johan,
Am Samstag, 30. März 2019, 10:56:36 CEST schrieb Johan Jonker:
> From: Zheng Yang <zhengyang@rock-chips.com>
>
> The RK3066 HDMI TX serves as interface between a LCD Controller and
> a HDMI bus. A HDMI TX consists of one HDMI transmitter controller and
> one HDMI transmitter PHY. The interface has three (3) 8-bit data channels
> which can be configured for a number of bus widths (8/10/12/16/20/24-bit)
> and different video formats (RGB, YCbCr).
>
> Features:
> HDMI version 1.4a, HDCP revision 1.4 and
> DVI version 1.0 compliant transmitter.
> Supports DTV resolutions from 480i to 1080i/p HD.
> Master I2C interface for a DDC connection.
> HDMI TX supports multiple power save modes.
> The HDMI TX input can switch between LCDC0 and LCDC1.
> (Sound support is not included in this patch)
>
> Signed-off-by: Zheng Yang <zhengyang@rock-chips.com>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
applied to drm-misc-next with a smallish change as described below,
please double check. [0]
> +static int
> +rk3066_hdmi_probe_single_connector_modes(struct drm_connector *connector,
> + uint32_t maxX, uint32_t maxY)
> +{
instead of
> + return drm_helper_probe_single_connector_modes(connector, 1920, 1080);
it is now doing
+ if (maxX > 1920)
+ maxX = 1920;
+ if (maxY > 1080)
+ maxY = 1080;
+
+ return drm_helper_probe_single_connector_modes(connector, maxX, maxY);
to take into account maxX / maxY being already below 1920x1080
> +}
Heiko
[0] https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f84d3d37b7fbb022e33b79d54374466f6fbc7186
next prev parent reply other threads:[~2019-03-31 14:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-30 9:56 [PATCH v6 0/4] Enable rk3066 VOP and HDMI for MK808 Johan Jonker
2019-03-30 9:56 ` Johan Jonker
2019-03-30 9:56 ` [PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi Johan Jonker
2019-03-30 9:56 ` Johan Jonker
2019-03-31 14:01 ` Heiko Stuebner [this message]
2019-03-31 14:01 ` Heiko Stuebner
2019-03-31 14:01 ` Heiko Stuebner
2019-03-30 9:56 ` [PATCH v6 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes Johan Jonker
2019-03-30 9:56 ` Johan Jonker
2019-03-31 15:36 ` Heiko Stuebner
2019-03-31 15:36 ` Heiko Stuebner
2019-03-30 9:56 ` [PATCH v6 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and " Johan Jonker
2019-03-30 9:56 ` Johan Jonker
2019-03-31 15:36 ` Heiko Stuebner
2019-03-31 15:36 ` Heiko Stuebner
2019-03-31 15:36 ` Heiko Stuebner
2019-03-30 9:56 ` [PATCH v6 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi Johan Jonker
2019-03-30 9:56 ` Johan Jonker
2019-03-31 13:57 ` Heiko Stuebner
2019-03-31 13:57 ` Heiko Stuebner
2019-03-31 13:57 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3503295.Ps5hWAbIar@phil \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.