[PATCH 0/4] eal: remove some experimental tags

[PATCH 0/4] eal: remove some experimental tags

[Stephen Hemminger]

These are all functions that have been in DPDK for two
years or more and should no longer be experimental.

Stephen Hemminger (4):
  rte_log: take of some experimental tags
  lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not
    experimental
  eal: make some intr functions not experimental
  eal: mark rte_delay_us_sleep as not experimental

 lib/eal/include/generic/rte_cycles.h |  4 +---
 lib/eal/include/rte_interrupts.h     | 12 +-----------
 lib/eal/include/rte_lcore.h          |  9 +--------
 lib/eal/include/rte_log.h            | 10 ----------
 lib/eal/version.map                  | 18 +++++++-----------
 5 files changed, 10 insertions(+), 43 deletions(-)

-- 
2.34.1

[PATCH 1/4] rte_log: take of some experimental tags

[Stephen Hemminger]

The RTE_LOG_REGISTER is not experimental, and the experimental
tag was never enforced on these.

Make rte_log_can_log a fully supported function.
It was introduced nearly 2yrs ago.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/include/rte_log.h | 10 ----------
 lib/eal/version.map       |  2 +-
 2 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/lib/eal/include/rte_log.h b/lib/eal/include/rte_log.h
index 319e4044a5c8..25ce42cdfc4d 100644
--- a/lib/eal/include/rte_log.h
+++ b/lib/eal/include/rte_log.h
@@ -136,7 +136,6 @@ int rte_log_get_level(uint32_t logtype);
  * @return
  * Returns 'true' if log can be printed and 'false' if it can't.
  */
-__rte_experimental
 bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
 
 /**
@@ -378,9 +377,6 @@ RTE_INIT(__##type)							    \
 }
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Register a dynamic log type in constructor context with its name and level.
  *
  * It is a wrapper macro for declaring the logtype, register the log and
@@ -397,9 +393,6 @@ RTE_INIT(__##type)							    \
 	RTE_LOG_REGISTER_IMPL(type, RTE_STR(name), level)
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * This is an equivalent to RTE_LOG_REGISTER, but relying on the build system
  * to select the right format for the logtype.
  */
@@ -407,9 +400,6 @@ RTE_INIT(__##type)							    \
 	RTE_LOG_REGISTER_IMPL(type, RTE_STR(RTE_LOG_DEFAULT_LOGTYPE), level)
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * This is an equivalent to RTE_LOG_REGISTER, but relying on the build system
  * to select the right prefix for the logtype.
  */
diff --git a/lib/eal/version.map b/lib/eal/version.map
index b53eeb30d74f..6b1657d0d8bd 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -129,6 +129,7 @@ DPDK_22 {
 	rte_lcore_iterate;
 	rte_lcore_to_socket_id;
 	rte_log;
+	rte_log_can_log;
 	rte_log_cur_msg_loglevel;
 	rte_log_cur_msg_logtype;
 	rte_log_dump;
@@ -364,7 +365,6 @@ EXPERIMENTAL {
 	__rte_trace_point_register;
 	per_lcore_trace_mem;
 	per_lcore_trace_point_sz;
-	rte_log_can_log;
 	rte_thread_getname; # WINDOWS_NO_EXPORT
 	rte_trace_dump; # WINDOWS_NO_EXPORT
 	rte_trace_is_enabled; # WINDOWS_NO_EXPORT
-- 
2.34.1

Re: [PATCH 1/4] rte_log: take of some experimental tags

[Ray Kinsella]

Stephen Hemminger <stephen@networkplumber.org> writes:

> The RTE_LOG_REGISTER is not experimental, and the experimental
> tag was never enforced on these.
>
> Make rte_log_can_log a fully supported function.
> It was introduced nearly 2yrs ago.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/eal/include/rte_log.h | 10 ----------
>  lib/eal/version.map       |  2 +-
>  2 files changed, 1 insertion(+), 11 deletions(-)

Acked-by: Ray Kinsella <mdr@ashroe.eu>

-- 
Regards, Ray K

[PATCH 2/4] lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not experimental

[Stephen Hemminger]

These API's have been around for a long time and by now are fixed.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/include/rte_lcore.h | 9 +--------
 lib/eal/version.map         | 4 ++--
 2 files changed, 3 insertions(+), 10 deletions(-)

diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h
index 258bc49b24ea..d2f908fa3466 100644
--- a/lib/eal/include/rte_lcore.h
+++ b/lib/eal/include/rte_lcore.h
@@ -160,9 +160,6 @@ unsigned int
 rte_lcore_to_socket_id(unsigned int lcore_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Return the id of the lcore on a socket starting from zero.
  *
  * @param lcore_id
@@ -170,23 +167,19 @@ rte_lcore_to_socket_id(unsigned int lcore_id);
  * @return
  *   The relative index, or -1 if not enabled.
  */
-__rte_experimental
 int
 rte_lcore_to_cpu_id(int lcore_id);
 
 #ifdef RTE_HAS_CPUSET
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Return the cpuset for a given lcore.
+ *
  * @param lcore_id
  *   the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1.
  * @return
  *   The cpuset of that lcore
  */
-__rte_experimental
 rte_cpuset_t
 rte_lcore_cpuset(unsigned int lcore_id);
 
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 6b1657d0d8bd..18d46acfeb1e 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -122,11 +122,13 @@ DPDK_22 {
 	rte_lcore_callback_register;
 	rte_lcore_callback_unregister;
 	rte_lcore_count;
+	rte_lcore_cpuset;
 	rte_lcore_dump;
 	rte_lcore_has_role;
 	rte_lcore_index;
 	rte_lcore_is_enabled;
 	rte_lcore_iterate;
+	rte_lcore_to_cpu_id;
 	rte_lcore_to_socket_id;
 	rte_log;
 	rte_log_can_log;
@@ -322,8 +324,6 @@ EXPERIMENTAL {
 
 	# added in 19.08
 	rte_intr_ack;
-	rte_lcore_cpuset;
-	rte_lcore_to_cpu_id;
 
 	# added in 20.02
 	rte_thread_is_intr;
-- 
2.34.1

Re: [PATCH 2/4] lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not experimental

[Ray Kinsella]

Stephen Hemminger <stephen@networkplumber.org> writes:

> These API's have been around for a long time and by now are fixed.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/eal/include/rte_lcore.h | 9 +--------
>  lib/eal/version.map         | 4 ++--
>  2 files changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/lib/eal/include/rte_lcore.h b/lib/eal/include/rte_lcore.h
> index 258bc49b24ea..d2f908fa3466 100644
> --- a/lib/eal/include/rte_lcore.h
> +++ b/lib/eal/include/rte_lcore.h

Acked-by: Ray Kinsella <mdr@ashroe.eu>

-- 
Regards, Ray K

[PATCH 3/4] eal: make some intr functions not experimental

[Stephen Hemminger]

These are functions related to interrupts that have been
in since 20.02 release or earlier.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/include/rte_interrupts.h | 12 +-----------
 lib/eal/version.map              | 10 +++-------
 2 files changed, 4 insertions(+), 18 deletions(-)

diff --git a/lib/eal/include/rte_interrupts.h b/lib/eal/include/rte_interrupts.h
index edbf0faeeffd..a378c0a0aa91 100644
--- a/lib/eal/include/rte_interrupts.h
+++ b/lib/eal/include/rte_interrupts.h
@@ -121,7 +121,6 @@ int rte_intr_callback_unregister(const struct rte_intr_handle *intr_handle,
  *  - On success, return the number of callback entities marked for remove.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int
 rte_intr_callback_unregister_pending(const struct rte_intr_handle *intr_handle,
 				rte_intr_callback_fn cb_fn, void *cb_arg,
@@ -177,9 +176,6 @@ int rte_intr_enable(const struct rte_intr_handle *intr_handle);
 int rte_intr_disable(const struct rte_intr_handle *intr_handle);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * It acknowledges an interrupt raised for the specified handle.
  *
  * This function should be called at the end of each interrupt handler either
@@ -193,22 +189,16 @@ int rte_intr_disable(const struct rte_intr_handle *intr_handle);
  *  - On success, zero.
  *  - On failure, a negative value.
  */
-__rte_experimental
 int rte_intr_ack(const struct rte_intr_handle *intr_handle);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Check if currently executing in interrupt context
  *
  * @return
  *  - non zero in case of interrupt context
  *  - zero in case of process context
  */
-__rte_experimental
-int
-rte_thread_is_intr(void);
+int rte_thread_is_intr(void);
 
 /**
  * @warning
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 18d46acfeb1e..131a0eea1f28 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -109,8 +109,10 @@ DPDK_22 {
 	rte_hexdump;
 	rte_hypervisor_get;
 	rte_hypervisor_get_name; # WINDOWS_NO_EXPORT
+	rte_intr_ack;
 	rte_intr_callback_register;
 	rte_intr_callback_unregister;
+	rte_intr_callback_unregister_pending;
 	rte_intr_disable;
 	rte_intr_enable;
 	rte_keepalive_create; # WINDOWS_NO_EXPORT
@@ -263,6 +265,7 @@ DPDK_22 {
 	rte_strsplit;
 	rte_sys_gettid;
 	rte_thread_get_affinity;
+	rte_thread_is_intr;
 	rte_thread_register;
 	rte_thread_set_affinity;
 	rte_thread_setname;
@@ -320,13 +323,6 @@ EXPERIMENTAL {
 	# added in 19.05
 	rte_dev_dma_map;
 	rte_dev_dma_unmap;
-	rte_intr_callback_unregister_pending;
-
-	# added in 19.08
-	rte_intr_ack;
-
-	# added in 20.02
-	rte_thread_is_intr;
 
 	# added in 20.05
 	__rte_eal_trace_alarm_cancel;
-- 
2.34.1

Re: [PATCH 3/4] eal: make some intr functions not experimental

[Ray Kinsella]

Stephen Hemminger <stephen@networkplumber.org> writes:

> These are functions related to interrupts that have been
> in since 20.02 release or earlier.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/eal/include/rte_interrupts.h | 12 +-----------
>  lib/eal/version.map              | 10 +++-------
>  2 files changed, 4 insertions(+), 18 deletions(-)

Acked-by: Ray Kinsella <mdr@ashroe.eu>

-- 
Regards, Ray K

[PATCH 4/4] eal: mark rte_delay_us_sleep as not experimental

[Stephen Hemminger]

This has been around since 2018 release.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/eal/include/generic/rte_cycles.h | 4 +---
 lib/eal/version.map                  | 2 +-
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/eal/include/generic/rte_cycles.h b/lib/eal/include/generic/rte_cycles.h
index 73d1fa7b923d..f4fdca416570 100644
--- a/lib/eal/include/generic/rte_cycles.h
+++ b/lib/eal/include/generic/rte_cycles.h
@@ -165,9 +165,7 @@ void rte_delay_us_block(unsigned int us);
  * @param us
  *   Number of microseconds to wait.
  */
-__rte_experimental
-void
-rte_delay_us_sleep(unsigned int us);
+void rte_delay_us_sleep(unsigned int us);
 
 /**
  * Replace rte_delay_us with user defined function.
diff --git a/lib/eal/version.map b/lib/eal/version.map
index 131a0eea1f28..8c65239fd0f5 100644
--- a/lib/eal/version.map
+++ b/lib/eal/version.map
@@ -26,6 +26,7 @@ DPDK_22 {
 	rte_delay_us;
 	rte_delay_us_block;
 	rte_delay_us_callback_register;
+	rte_delay_us_sleep;
 	rte_dev_is_probed;
 	rte_dev_probe;
 	rte_dev_remove;
@@ -315,7 +316,6 @@ EXPERIMENTAL {
 	rte_dev_iterator_next;
 
 	# added in 18.11
-	rte_delay_us_sleep;
 	rte_dev_event_callback_process;
 	rte_dev_hotplug_handle_disable;
 	rte_dev_hotplug_handle_enable;
-- 
2.34.1

Re: [PATCH 4/4] eal: mark rte_delay_us_sleep as not experimental

[Ray Kinsella]

Stephen Hemminger <stephen@networkplumber.org> writes:

> This has been around since 2018 release.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  lib/eal/include/generic/rte_cycles.h | 4 +---
>  lib/eal/version.map                  | 2 +-
>  2 files changed, 2 insertions(+), 4 deletions(-)
Acked-by: Ray Kinsella <mdr@ashroe.eu>

-- 
Regards, Ray K

Re: [PATCH 0/4] eal: remove some experimental tags

[Thomas Monjalon]

16/02/2022 20:39, Stephen Hemminger:
> These are all functions that have been in DPDK for two
> years or more and should no longer be experimental.
> 
> Stephen Hemminger (4):
>   rte_log: take of some experimental tags
>   lcore: change rte_lcore_to_cpu_id and rte_lcore_cpuset as not
>     experimental
>   eal: make some intr functions not experimental
>   eal: mark rte_delay_us_sleep as not experimental

Applied, thanks.