All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@samsung.com>
Cc: Arnon Warshavsky <arnon@qwilt.com>,
	dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,
	Andrzej Ostruszka <amo@semihalf.com>
Subject: Re: [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches
Date: Sat, 15 Sep 2018 23:07:00 +0200	[thread overview]
Message-ID: <3518082.x84fBL49uy@xps> (raw)
In-Reply-To: <20180914150818eucas1p299538375ea77dfc477516918818c3ab8~UTLGIgMNr0598905989eucas1p2k@eucas1p2.samsung.com>

14/09/2018 17:10, Ilya Maximets:
> Hi Thomas.
> 
> Beside your questions,
> There is another patch that targeted to fix this issue:
> 	http://patches.dpdk.org/patch/44020/
> And one similar to mine that I missed while sending:
> 	http://patches.dpdk.org/patch/43692/
> 
> So, I'm not sure which one should be accepted and if I need to
> update my version. What do you think? Stephen? Andrzej?

Generally speaking, I think it's better to avoid bash extensions
and comply with POSIX. That's why I support the proposal of moving
the awk script in its own file, removing the need for "read -d".

  reply	other threads:[~2018-09-15 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
2018-08-15 15:33 ` [PATCH] devtools: don't use bash extension in checkpatches Ilya Maximets
2018-08-16  5:25   ` Arnon Warshavsky
2018-09-14 14:50     ` [dpdk-stable] " Thomas Monjalon
2018-09-14 15:10       ` Ilya Maximets
2018-09-15 21:07         ` Thomas Monjalon [this message]
2018-09-15 19:07       ` Arnon Warshavsky
2018-09-15 20:37         ` Thomas Monjalon
2018-09-16  3:13           ` Arnon Warshavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3518082.x84fBL49uy@xps \
    --to=thomas@monjalon.net \
    --cc=amo@semihalf.com \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.