All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: Ilya Maximets <i.maximets@samsung.com>,
	dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-stable] [PATCH] devtools: don't use bash extension in checkpatches
Date: Fri, 14 Sep 2018 16:50:24 +0200	[thread overview]
Message-ID: <6831653.AvvoQPlBBt@xps> (raw)
In-Reply-To: <CAKy9EB16M51eKWUCGmK4Oe52GH=PuPYMOpVJL4Qqi7fu0vVsJw@mail.gmail.com>

16/08/2018 07:25, Arnon Warshavsky:
> Hi Ilya
> 
> Let's use single quotes instead of variable.
> 
> 
> Using the script directly with single quotes loses the ability to reuse it
> with an additional set of folders , expressions and RET_ON_FAIL.

I don't know awk. Please could you explain what we are loosing and why?

> If we wish to keep the awk code in this file and not in a separate file,
> maybe receiving the awk script parameters from the function
>  check_forbidden_additions( ) can also preserve the ability to reuse in
> future cases.

Yes I feel we could add some parameters to this function.
And yes, we could move the awk script in a separate file.
Actually, it would be better to keep checkpatches.sh as a wrapper script
calling various tools.

Thanks

  reply	other threads:[~2018-09-14 14:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180815153249eucas1p2e13cf746fda4b82519b40f3b760a2c33@eucas1p2.samsung.com>
2018-08-15 15:33 ` [PATCH] devtools: don't use bash extension in checkpatches Ilya Maximets
2018-08-16  5:25   ` Arnon Warshavsky
2018-09-14 14:50     ` Thomas Monjalon [this message]
2018-09-14 15:10       ` [dpdk-stable] " Ilya Maximets
2018-09-15 21:07         ` Thomas Monjalon
2018-09-15 19:07       ` Arnon Warshavsky
2018-09-15 20:37         ` Thomas Monjalon
2018-09-16  3:13           ` Arnon Warshavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6831653.AvvoQPlBBt@xps \
    --to=thomas@monjalon.net \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.