From: "Heiko Stübner" <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sandy Huang <hjc@rock-chips.com>
Subject: Re: [Intel-gfx] [PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally
Date: Mon, 05 Sep 2022 12:12:14 +0200 [thread overview]
Message-ID: <3530081.XrmoMso0CX@diego> (raw)
In-Reply-To: <bb733eccfb389533cc6e207689be845164a1ed91.1662036058.git.jani.nikula@intel.com>
Am Donnerstag, 1. September 2022, 14:47:10 CEST schrieb Jani Nikula:
> Calling drm_connector_update_edid_property() should be done
> unconditionally instead of depending on the number of modes added. Also
> match the call order in inno_hdmi and rk3066_hdmi.
>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: Heiko Stübner <heiko@sntech.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index c204e9b95c1f..f77bdf5f5168 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -273,10 +273,9 @@ static int cdn_dp_connector_get_modes(struct drm_connector *connector)
> edid->width_cm, edid->height_cm);
>
> dp->sink_has_audio = drm_detect_monitor_audio(edid);
> +
> + drm_connector_update_edid_property(connector, edid);
> ret = drm_add_edid_modes(connector, edid);
> - if (ret)
> - drm_connector_update_edid_property(connector,
> - edid);
> }
> mutex_unlock(&dp->lock);
>
>
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: dri-devel@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sandy Huang <hjc@rock-chips.com>
Subject: Re: [PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally
Date: Mon, 05 Sep 2022 12:12:14 +0200 [thread overview]
Message-ID: <3530081.XrmoMso0CX@diego> (raw)
In-Reply-To: <bb733eccfb389533cc6e207689be845164a1ed91.1662036058.git.jani.nikula@intel.com>
Am Donnerstag, 1. September 2022, 14:47:10 CEST schrieb Jani Nikula:
> Calling drm_connector_update_edid_property() should be done
> unconditionally instead of depending on the number of modes added. Also
> match the call order in inno_hdmi and rk3066_hdmi.
>
> Cc: Sandy Huang <hjc@rock-chips.com>
> Cc: Heiko Stübner <heiko@sntech.de>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> ---
> drivers/gpu/drm/rockchip/cdn-dp-core.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/cdn-dp-core.c b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> index c204e9b95c1f..f77bdf5f5168 100644
> --- a/drivers/gpu/drm/rockchip/cdn-dp-core.c
> +++ b/drivers/gpu/drm/rockchip/cdn-dp-core.c
> @@ -273,10 +273,9 @@ static int cdn_dp_connector_get_modes(struct drm_connector *connector)
> edid->width_cm, edid->height_cm);
>
> dp->sink_has_audio = drm_detect_monitor_audio(edid);
> +
> + drm_connector_update_edid_property(connector, edid);
> ret = drm_add_edid_modes(connector, edid);
> - if (ret)
> - drm_connector_update_edid_property(connector,
> - edid);
> }
> mutex_unlock(&dp->lock);
>
>
next prev parent reply other threads:[~2022-09-05 10:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 12:47 [PATCH 0/9] drm: convert to using is_hdmi and has_audio from display info Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Nouveau] " Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] " Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] [PATCH 1/9] drm/edid: parse display info has_audio similar to is_hdmi Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] [PATCH 2/9] drm/nouveau: convert to using is_hdmi and has_audio from display info Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Nouveau] " Jani Nikula
2022-09-01 20:16 ` [Intel-gfx] " Lyude Paul
2022-09-01 20:16 ` Lyude Paul
2022-09-01 20:16 ` [Nouveau] " Lyude Paul
2022-09-01 12:47 ` [PATCH 3/9] drm/radeon: " Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] " Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] [PATCH 4/9] drm/tegra: convert to using is_hdmi " Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-15 12:29 ` [Intel-gfx] " Thierry Reding
2022-09-15 12:29 ` Thierry Reding
2022-09-15 12:29 ` Thierry Reding
2022-09-01 12:47 ` [Intel-gfx] [PATCH 5/9] drm/exynos: " Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] [PATCH 6/9] drm/i2c/tda998x: convert to using has_audio from display_info Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-01 12:47 ` [Intel-gfx] [PATCH 7/9] drm/sti/sti_hdmi: convert to using is_hdmi from display info Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2023-04-22 17:06 ` [Intel-gfx] " Alain Volmat
2023-04-22 17:06 ` Alain Volmat
2022-09-01 12:47 ` [Intel-gfx] [PATCH 8/9] drm/rockchip: cdn-dp: call drm_connector_update_edid_property() unconditionally Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-05 10:12 ` Heiko Stübner [this message]
2022-09-05 10:12 ` Heiko Stübner
2022-09-01 12:47 ` [Intel-gfx] [PATCH 9/9] drm/rockchip: convert to using has_audio from display_info Jani Nikula
2022-09-01 12:47 ` Jani Nikula
2022-09-05 10:13 ` [Intel-gfx] " Heiko Stübner
2022-09-05 10:13 ` Heiko Stübner
2022-09-01 13:49 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: convert to using is_hdmi and has_audio from display info Patchwork
2022-09-01 14:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-02 10:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3530081.XrmoMso0CX@diego \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=laurent.pinchart@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.