Re: [PATCH/RFC 1/4] pinctrl: sh-pfc: Add PINMUX_SINGLE()

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Geert,

Thank you for the patch.

On Tuesday 20 October 2015 21:26:32 Geert Uytterhoeven wrote:
> Add a macro to describe a pinmux configuration for a single-function
> pin.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pinctrl/sh-pfc/sh_pfc.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h
> b/drivers/pinctrl/sh-pfc/sh_pfc.h index 63e6cd050d0fb7d2..932fbef8bad400dd
> 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -277,6 +277,13 @@ struct sh_pfc_soc_info {
>  	PINMUX_DATA(fn##_MARK, FN_##ms, FN_##ipsr, FN_##fn)
> 
>  /*
> + * Describe a pinmux configuration for a single-function pin.

I would say "single-function pin with GPIO capability".

Apart from that,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> + *   - fn: Function name
> + */
> +#define PINMUX_SINGLE(fn)						\
> +	PINMUX_DATA(fn##_MARK, FN_##fn)
> +
> +/*
>   * GP port style (32 ports banks)
>   */

-- 
Regards,

Laurent Pinchart