All of lore.kernel.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: add CLK_IGNORE_UNUSED flag to fix USB Host
Date: Fri, 12 Dec 2014 19:02:24 +0100	[thread overview]
Message-ID: <3548627.UnLcRkWMrC@phil> (raw)
In-Reply-To: <CABgxDoKKjwDf8+OuWiTjzpbGonshZ0fHXXMvSkJi1Z1U_7AsNA@mail.gmail.com>

Am Freitag, 12. Dezember 2014, 16:44:06 schrieb Romain Perier:
> Hi,
> 
> 2014-12-12 15:54 GMT+01:00 Julien CHAUVEAU
> 
> <julien.chauveau@neo-technologies.fr>:
> > This patch adds CLK_IGNORE_UNUSED flag to hclk_usb_peri, hclk_usbotg0 and
> > hclk_usbotg1 because these clocks must remain enabled to use the USB
> > controllers in host mode.
> > 
> > This fixes a regression introduced by patch "clk: rockchip: disable unused
> > clocks"
> > https://lkml.kernel.org/g/1415092270-24932-1-git-send-email-kever.yang at ro
> > ck-chips.com
> Could you refer the commit id instead ? something like "commit <ID>
> ("title of the corresponding commit")  (and use scripts/checkpatch.pl
> on your patch to be sure that the commit form is okay).

I can also fix this up when applying the patch


> 
> 
> I confirm the regression.

instead of prose-confirmation please provide appropriate tags, like

Reviewed-by: Romain Perier <romain.perier@gmail.com>
Tested-by: Romain Perier <romain.perier@gmail.com>

Tested-by when you have tested the fix on actual hardware and Reviewed-by when 
you have reviewed the actual change for correctnes


Thanks
Heiko

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Romain Perier <romain.perier@gmail.com>
Cc: Julien CHAUVEAU <julien.chauveau@neo-technologies.fr>,
	Mike Turquette <mturquette@linaro.org>,
	Stephen Boyd <sboyd@codeaurora.org>,
	"moderated list:ARM/Rockchip SoC..." 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"open list:COMMON CLK FRAMEWORK" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: rockchip: add CLK_IGNORE_UNUSED flag to fix USB Host
Date: Fri, 12 Dec 2014 19:02:24 +0100	[thread overview]
Message-ID: <3548627.UnLcRkWMrC@phil> (raw)
In-Reply-To: <CABgxDoKKjwDf8+OuWiTjzpbGonshZ0fHXXMvSkJi1Z1U_7AsNA@mail.gmail.com>

Am Freitag, 12. Dezember 2014, 16:44:06 schrieb Romain Perier:
> Hi,
> 
> 2014-12-12 15:54 GMT+01:00 Julien CHAUVEAU
> 
> <julien.chauveau@neo-technologies.fr>:
> > This patch adds CLK_IGNORE_UNUSED flag to hclk_usb_peri, hclk_usbotg0 and
> > hclk_usbotg1 because these clocks must remain enabled to use the USB
> > controllers in host mode.
> > 
> > This fixes a regression introduced by patch "clk: rockchip: disable unused
> > clocks"
> > https://lkml.kernel.org/g/1415092270-24932-1-git-send-email-kever.yang@ro
> > ck-chips.com
> Could you refer the commit id instead ? something like "commit <ID>
> ("title of the corresponding commit")  (and use scripts/checkpatch.pl
> on your patch to be sure that the commit form is okay).

I can also fix this up when applying the patch


> 
> 
> I confirm the regression.

instead of prose-confirmation please provide appropriate tags, like

Reviewed-by: Romain Perier <romain.perier@gmail.com>
Tested-by: Romain Perier <romain.perier@gmail.com>

Tested-by when you have tested the fix on actual hardware and Reviewed-by when 
you have reviewed the actual change for correctnes


Thanks
Heiko

  parent reply	other threads:[~2014-12-12 18:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-12 14:54 [PATCH] clk: rockchip: add CLK_IGNORE_UNUSED flag to fix USB Host Julien CHAUVEAU
2014-12-12 14:54 ` Julien CHAUVEAU
2014-12-12 15:44 ` Romain Perier
2014-12-12 15:44   ` Romain Perier
2014-12-12 18:01   ` NEO-Technologies / Julien CHAUVEAU
2014-12-12 18:01     ` NEO-Technologies / Julien CHAUVEAU
2014-12-12 18:02   ` Heiko Stübner [this message]
2014-12-12 18:02     ` Heiko Stübner
2014-12-12 21:05 ` [PATCH v2] " Julien CHAUVEAU
2014-12-12 21:05   ` Julien CHAUVEAU
2014-12-12 21:42   ` Romain Perier
2014-12-12 21:42     ` Romain Perier
2014-12-21 14:08   ` Heiko Stübner
2014-12-21 14:08     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3548627.UnLcRkWMrC@phil \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.