[PATCH] sh: fix sh770x SCIF memory regions

[PATCH] sh: fix sh770x SCIF memory regions

[Andriy Skulysh]

sh: fix sh770x SCIF memory regions

Resources scif1_resources & scif2_resources overlap.
Actual SCIF region size is 0x10.

This is regression from:

Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Date:   Fri Dec 6 10:59:48 2013 +0100
sh: Declare SCIF register base and IRQ as resources

Signed-off-by: Andriy Skulysh <askulysh@gmail.com>

diff --git a/arch/sh/kernel/cpu/sh3/setup-sh770x.c
b/arch/sh/kernel/cpu/sh3/setup-sh770x.c
index ff1465c..5acf89c 100644
--- a/arch/sh/kernel/cpu/sh3/setup-sh770x.c
+++ b/arch/sh/kernel/cpu/sh3/setup-sh770x.c
@@ -118,7 +118,7 @@ static struct plat_sci_port scif0_platform_data = {
 };

 static struct resource scif0_resources[] = {
-    DEFINE_RES_MEM(0xfffffe80, 0x100),
+    DEFINE_RES_MEM(0xfffffe80, 0x10),
     DEFINE_RES_IRQ(evt2irq(0x4e0)),
 };

@@ -143,7 +143,7 @@ static struct plat_sci_port scif1_platform_data = {
 };

 static struct resource scif1_resources[] = {
-    DEFINE_RES_MEM(0xa4000150, 0x100),
+    DEFINE_RES_MEM(0xa4000150, 0x10),
     DEFINE_RES_IRQ(evt2irq(0x900)),
 };

@@ -169,7 +169,7 @@ static struct plat_sci_port scif2_platform_data = {
 };

 static struct resource scif2_resources[] = {
-    DEFINE_RES_MEM(0xa4000140, 0x100),
+    DEFINE_RES_MEM(0xa4000140, 0x10),
     DEFINE_RES_IRQ(evt2irq(0x880)),
 };

Re: [PATCH] sh: fix sh770x SCIF memory regions

[Laurent Pinchart]

Hi Andriy,

Thank you for the patch.

On Thursday 16 October 2014 21:46:50 Andriy Skulysh wrote:
> sh: fix sh770x SCIF memory regions
> 
> Resources scif1_resources & scif2_resources overlap.
> Actual SCIF region size is 0x10.
> 
> This is regression from:
> 
> Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Date:   Fri Dec 6 10:59:48 2013 +0100
> sh: Declare SCIF register base and IRQ as resources
> 
> Signed-off-by: Andriy Skulysh <askulysh@gmail.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> diff --git a/arch/sh/kernel/cpu/sh3/setup-sh770x.c
> b/arch/sh/kernel/cpu/sh3/setup-sh770x.c
> index ff1465c..5acf89c 100644
> --- a/arch/sh/kernel/cpu/sh3/setup-sh770x.c
> +++ b/arch/sh/kernel/cpu/sh3/setup-sh770x.c
> @@ -118,7 +118,7 @@ static struct plat_sci_port scif0_platform_data = {
>  };
> 
>  static struct resource scif0_resources[] = {
> -    DEFINE_RES_MEM(0xfffffe80, 0x100),
> +    DEFINE_RES_MEM(0xfffffe80, 0x10),
>      DEFINE_RES_IRQ(evt2irq(0x4e0)),
>  };
> 
> @@ -143,7 +143,7 @@ static struct plat_sci_port scif1_platform_data = {
>  };
> 
>  static struct resource scif1_resources[] = {
> -    DEFINE_RES_MEM(0xa4000150, 0x100),
> +    DEFINE_RES_MEM(0xa4000150, 0x10),
>      DEFINE_RES_IRQ(evt2irq(0x900)),
>  };
> 
> @@ -169,7 +169,7 @@ static struct plat_sci_port scif2_platform_data = {
>  };
> 
>  static struct resource scif2_resources[] = {
> -    DEFINE_RES_MEM(0xa4000140, 0x100),
> +    DEFINE_RES_MEM(0xa4000140, 0x10),
>      DEFINE_RES_IRQ(evt2irq(0x880)),
>  };

-- 
Regards,

Laurent Pinchart

Re: [PATCH] sh: fix sh770x SCIF memory regions

[Geert Uytterhoeven]

Hi Andriy,

On Fri, Oct 24, 2014 at 12:46 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Thank you for the patch.
>
> On Thursday 16 October 2014 21:46:50 Andriy Skulysh wrote:
>> sh: fix sh770x SCIF memory regions
>>
>> Resources scif1_resources & scif2_resources overlap.
>> Actual SCIF region size is 0x10.
>>
>> This is regression from:
>>
>> Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> Date:   Fri Dec 6 10:59:48 2013 +0100
>> sh: Declare SCIF register base and IRQ as resources
>>
>> Signed-off-by: Andriy Skulysh <askulysh@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

As drivers/sh is unmaintained, please send this patch to Andrew Morton.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds