From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9
Date: Tue, 25 Aug 2015 22:36:22 +0200 [thread overview]
Message-ID: <3551937.qa4lRhD8e3@wuerfel> (raw)
In-Reply-To: <1440533237-5831-1-git-send-email-mcoquelin.stm32@gmail.com>
On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a750c14..57d53af 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
> int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
> range 11 64 if ARCH_SHMOBILE_LEGACY
> default "12" if SOC_AM33XX
> - default "9" if SA1111 || ARCH_EFM32
> + default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
> default "11"
>
This looks wrong now that we can enable multiple ARMV7M platforms
together. In practice it doesn't matter much, because you wouldn't
do that for a real-life system, but out of principle this seems
like something you'd better put into the defconfig file for
both ARCH_EFM32 and ARCH_STM32. We could also think about changing
the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
it again in defconfig for any platform that actually has a lot of
RAM (if any).
The SOC_AM33XX is slightly different because it increases the default
rather than reducing it, presumably because the larger allocation is
actually required (for what?).
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
olof@lixom.net, khilman@kernel.org, afaerber@suse.de,
Russell King <linux@arm.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9
Date: Tue, 25 Aug 2015 22:36:22 +0200 [thread overview]
Message-ID: <3551937.qa4lRhD8e3@wuerfel> (raw)
In-Reply-To: <1440533237-5831-1-git-send-email-mcoquelin.stm32@gmail.com>
On Tuesday 25 August 2015 22:07:17 Maxime Coquelin wrote:
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index a750c14..57d53af 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1734,7 +1734,7 @@ config FORCE_MAX_ZONEORDER
> int "Maximum zone order" if ARCH_SHMOBILE_LEGACY
> range 11 64 if ARCH_SHMOBILE_LEGACY
> default "12" if SOC_AM33XX
> - default "9" if SA1111 || ARCH_EFM32
> + default "9" if SA1111 || ARCH_EFM32 || ARCH_STM32
> default "11"
>
This looks wrong now that we can enable multiple ARMV7M platforms
together. In practice it doesn't matter much, because you wouldn't
do that for a real-life system, but out of principle this seems
like something you'd better put into the defconfig file for
both ARCH_EFM32 and ARCH_STM32. We could also think about changing
the default to "9" for any ARM_SINGLE_ARMV7M config and increasing
it again in defconfig for any platform that actually has a lot of
RAM (if any).
The SOC_AM33XX is slightly different because it increases the default
rather than reducing it, presumably because the larger allocation is
actually required (for what?).
Arnd
next prev parent reply other threads:[~2015-08-25 20:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 20:07 [PATCH] ARM: stm32: Reduce FORCE_MAX_ZONEORDER to 9 Maxime Coquelin
2015-08-25 20:07 ` Maxime Coquelin
2015-08-25 20:36 ` Arnd Bergmann [this message]
2015-08-25 20:36 ` Arnd Bergmann
2015-08-25 21:03 ` Maxime Coquelin
2015-08-25 21:03 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3551937.qa4lRhD8e3@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.