From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH] iommu: Convert to using %pOF instead of full_name
Date: Thu, 20 Jul 2017 22:35:46 +0200 [thread overview]
Message-ID: <3567821.Si31GJ2fDW@phil> (raw)
In-Reply-To: <20170718214339.7774-29-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Am Dienstag, 18. Juli 2017, 16:43:09 CEST schrieb Rob Herring:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
> Cc: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
> Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> ---
> drivers/iommu/rockchip-iommu.c | 10 +++++-----
for the Rockchip-related part
Reviewed-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
> index 4ba48a26b389..1b8155dada26 100644
> --- a/drivers/iommu/rockchip-iommu.c
> +++ b/drivers/iommu/rockchip-iommu.c
> @@ -1008,20 +1008,20 @@ static int rk_iommu_group_set_iommudata(struct iommu_group *group,
> ret = of_parse_phandle_with_args(np, "iommus", "#iommu-cells", 0,
> &args);
> if (ret) {
> - dev_err(dev, "of_parse_phandle_with_args(%s) => %d\n",
> - np->full_name, ret);
> + dev_err(dev, "of_parse_phandle_with_args(%pOF) => %d\n",
> + np, ret);
> return ret;
> }
> if (args.args_count != 0) {
> - dev_err(dev, "incorrect number of iommu params found for %s (found %d, expected 0)\n",
> - args.np->full_name, args.args_count);
> + dev_err(dev, "incorrect number of iommu params found for %pOF (found %d, expected 0)\n",
> + args.np, args.args_count);
> return -EINVAL;
> }
>
> pd = of_find_device_by_node(args.np);
> of_node_put(args.np);
> if (!pd) {
> - dev_err(dev, "iommu %s not found\n", args.np->full_name);
> + dev_err(dev, "iommu %pOF not found\n", args.np);
> return -EPROBE_DEFER;
> }
>
> --
> 2.11.0
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] iommu: Convert to using %pOF instead of full_name
Date: Thu, 20 Jul 2017 22:35:46 +0200 [thread overview]
Message-ID: <3567821.Si31GJ2fDW@phil> (raw)
In-Reply-To: <20170718214339.7774-29-robh@kernel.org>
Am Dienstag, 18. Juli 2017, 16:43:09 CEST schrieb Rob Herring:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: iommu at lists.linux-foundation.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-rockchip at lists.infradead.org
> ---
> drivers/iommu/rockchip-iommu.c | 10 +++++-----
for the Rockchip-related part
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
> index 4ba48a26b389..1b8155dada26 100644
> --- a/drivers/iommu/rockchip-iommu.c
> +++ b/drivers/iommu/rockchip-iommu.c
> @@ -1008,20 +1008,20 @@ static int rk_iommu_group_set_iommudata(struct iommu_group *group,
> ret = of_parse_phandle_with_args(np, "iommus", "#iommu-cells", 0,
> &args);
> if (ret) {
> - dev_err(dev, "of_parse_phandle_with_args(%s) => %d\n",
> - np->full_name, ret);
> + dev_err(dev, "of_parse_phandle_with_args(%pOF) => %d\n",
> + np, ret);
> return ret;
> }
> if (args.args_count != 0) {
> - dev_err(dev, "incorrect number of iommu params found for %s (found %d, expected 0)\n",
> - args.np->full_name, args.args_count);
> + dev_err(dev, "incorrect number of iommu params found for %pOF (found %d, expected 0)\n",
> + args.np, args.args_count);
> return -EINVAL;
> }
>
> pd = of_find_device_by_node(args.np);
> of_node_put(args.np);
> if (!pd) {
> - dev_err(dev, "iommu %s not found\n", args.np->full_name);
> + dev_err(dev, "iommu %pOF not found\n", args.np);
> return -EPROBE_DEFER;
> }
>
> --
> 2.11.0
>
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Rob Herring <robh@kernel.org>
Cc: Joerg Roedel <joro@8bytes.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
iommu@lists.linux-foundation.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] iommu: Convert to using %pOF instead of full_name
Date: Thu, 20 Jul 2017 22:35:46 +0200 [thread overview]
Message-ID: <3567821.Si31GJ2fDW@phil> (raw)
In-Reply-To: <20170718214339.7774-29-robh@kernel.org>
Am Dienstag, 18. Juli 2017, 16:43:09 CEST schrieb Rob Herring:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/iommu/rockchip-iommu.c | 10 +++++-----
for the Rockchip-related part
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c
> index 4ba48a26b389..1b8155dada26 100644
> --- a/drivers/iommu/rockchip-iommu.c
> +++ b/drivers/iommu/rockchip-iommu.c
> @@ -1008,20 +1008,20 @@ static int rk_iommu_group_set_iommudata(struct iommu_group *group,
> ret = of_parse_phandle_with_args(np, "iommus", "#iommu-cells", 0,
> &args);
> if (ret) {
> - dev_err(dev, "of_parse_phandle_with_args(%s) => %d\n",
> - np->full_name, ret);
> + dev_err(dev, "of_parse_phandle_with_args(%pOF) => %d\n",
> + np, ret);
> return ret;
> }
> if (args.args_count != 0) {
> - dev_err(dev, "incorrect number of iommu params found for %s (found %d, expected 0)\n",
> - args.np->full_name, args.args_count);
> + dev_err(dev, "incorrect number of iommu params found for %pOF (found %d, expected 0)\n",
> + args.np, args.args_count);
> return -EINVAL;
> }
>
> pd = of_find_device_by_node(args.np);
> of_node_put(args.np);
> if (!pd) {
> - dev_err(dev, "iommu %s not found\n", args.np->full_name);
> + dev_err(dev, "iommu %pOF not found\n", args.np);
> return -EPROBE_DEFER;
> }
>
> --
> 2.11.0
>
>
>
next prev parent reply other threads:[~2017-07-20 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 21:43 [PATCH] iommu: Convert to using %pOF instead of full_name Rob Herring
2017-07-18 21:43 ` Rob Herring
2017-07-18 21:43 ` Rob Herring
[not found] ` <20170718214339.7774-29-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-07-20 20:35 ` Heiko Stuebner [this message]
2017-07-20 20:35 ` Heiko Stuebner
2017-07-20 20:35 ` Heiko Stuebner
2017-07-26 11:01 ` Joerg Roedel
2017-07-26 11:01 ` Joerg Roedel
2017-07-26 11:01 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3567821.Si31GJ2fDW@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.