All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Randy Li <ayaka@soulik.info>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk,
	mark.rutland@arm.com
Subject: Re: [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for firefly reload
Date: Sun, 14 Aug 2016 14:30:51 +0200	[thread overview]
Message-ID: <35898684.O6p1GdTFI2@phil> (raw)
In-Reply-To: <1471174044-26003-2-git-send-email-ayaka@soulik.info>

Am Sonntag, 14. August 2016, 19:27:23 CEST schrieb Randy Li:
> Because of a bug in hardware design, the sdcard at firefly
> rk3288 reload board can't switch the io voltage level to 1.8v.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/rk3288-firefly-reload.dts | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> b/arch/arm/boot/dts/rk3288-firefly-reload.dts index 43145d1..a2b1f14 100644
> --- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> +++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
> @@ -202,18 +202,13 @@
>  	bus-width = <4>;
>  	cap-mmc-highspeed;
>  	cap-sd-highspeed;
> -	sd-uhs-sdr12;
> -	sd-uhs-sdr25;
> -	sd-uhs-sdr50;
> -	sd-uhs-sdr104;
> -	sd-uhs-ddr50;
>  	card-detect-delay = <200>;
>  	disable-wp;
>  	num-slots = <1>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
>  	vmmc-supply = <&vcc_sd>;
> -	vqmmc-supply = <&vccio_sd>;
> +	vqmmc-supply = <&vcc_sd>;

that looks wrong. vccio_sd is still the vqmmc supply in the schematics even 
though we don't want to switch to 1.8V . But that regulator should still be 
controllable without needing a regulator-always-on in the future.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for firefly reload
Date: Sun, 14 Aug 2016 14:30:51 +0200	[thread overview]
Message-ID: <35898684.O6p1GdTFI2@phil> (raw)
In-Reply-To: <1471174044-26003-2-git-send-email-ayaka@soulik.info>

Am Sonntag, 14. August 2016, 19:27:23 CEST schrieb Randy Li:
> Because of a bug in hardware design, the sdcard at firefly
> rk3288 reload board can't switch the io voltage level to 1.8v.
> 
> Signed-off-by: Randy Li <ayaka@soulik.info>
> ---
>  arch/arm/boot/dts/rk3288-firefly-reload.dts | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> b/arch/arm/boot/dts/rk3288-firefly-reload.dts index 43145d1..a2b1f14 100644
> --- a/arch/arm/boot/dts/rk3288-firefly-reload.dts
> +++ b/arch/arm/boot/dts/rk3288-firefly-reload.dts
> @@ -202,18 +202,13 @@
>  	bus-width = <4>;
>  	cap-mmc-highspeed;
>  	cap-sd-highspeed;
> -	sd-uhs-sdr12;
> -	sd-uhs-sdr25;
> -	sd-uhs-sdr50;
> -	sd-uhs-sdr104;
> -	sd-uhs-ddr50;
>  	card-detect-delay = <200>;
>  	disable-wp;
>  	num-slots = <1>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&sdmmc_clk>, <&sdmmc_cmd>, <&sdmmc_cd>, <&sdmmc_bus4>;
>  	vmmc-supply = <&vcc_sd>;
> -	vqmmc-supply = <&vccio_sd>;
> +	vqmmc-supply = <&vcc_sd>;

that looks wrong. vccio_sd is still the vqmmc supply in the schematics even 
though we don't want to switch to 1.8V . But that regulator should still be 
controllable without needing a regulator-always-on in the future.


Heiko

  reply	other threads:[~2016-08-14 12:30 UTC|newest]

Thread overview: 123+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06 15:25 [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload ayaka
2016-07-06 15:25 ` ayaka
2016-07-06 15:25 ` ayaka
     [not found] ` <1467818724-21500-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-06 15:25   ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi ayaka
2016-07-06 15:25     ` ayaka
2016-07-06 15:25     ` ayaka
2016-07-06 15:25   ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics ayaka
2016-07-06 15:25     ` ayaka
2016-07-06 15:25     ` ayaka
     [not found]     ` <1467818724-21500-3-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-06 16:13       ` Heiko Stuebner
2016-07-06 16:13         ` Heiko Stuebner
2016-07-06 16:13         ` Heiko Stuebner
2016-07-06 17:34         ` [PATCH 0/3] " Randy Li
2016-07-06 17:34           ` Randy Li
2016-07-06 17:34           ` Randy Li
2016-07-06 17:34           ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 17:34             ` Randy Li
2016-07-06 17:34           ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:34             ` Randy Li
2016-07-06 17:34           ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-06 17:34             ` Randy Li
2016-07-06 17:52         ` [PATCH 0/3] Re:[PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:52           ` Randy Li
2016-07-06 17:52           ` Randy Li
2016-07-06 17:52           ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 17:52             ` Randy Li
     [not found]           ` <1467827564-28007-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-06 17:52             ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 17:52               ` Randy Li
2016-07-06 17:52               ` Randy Li
2016-07-06 17:52           ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-06 17:52             ` Randy Li
2016-07-06 18:06         ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 18:06           ` Randy Li
2016-07-06 18:06           ` Randy Li
2016-07-06 18:22         ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Randy Li
2016-07-06 18:22           ` Randy Li
2016-07-06 18:22           ` Randy Li
2016-07-06 18:22           ` [PATCH 1/3] ARM: dts: add label leds for rk3288-firefly.dtsi Randy Li
2016-07-06 18:22             ` Randy Li
2016-07-06 18:22           ` [PATCH 2/3] ARM: dts: move regulator settings from common to specifics Randy Li
2016-07-06 18:22             ` Randy Li
2016-07-06 18:23           ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-06 18:23             ` Randy Li
     [not found]           ` <1467829380-16242-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-07 21:35             ` [PATCH 0/3] ARM: dts: the dts support for rk3288 firefly reload Heiko Stuebner
2016-07-07 21:35               ` Heiko Stuebner
2016-07-07 21:35               ` Heiko Stuebner
2016-07-09 15:42               ` ayaka
2016-07-09 15:42                 ` ayaka
2016-07-09 23:06                 ` Heiko Stuebner
2016-07-09 23:06                   ` Heiko Stuebner
2016-07-17 15:38                   ` [PATCH] " Randy Li
2016-07-17 15:38                     ` Randy Li
     [not found]                     ` <1468769937-23387-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-17 15:38                       ` [PATCH] ARM: dts: add rk3288-firefly-reload Randy Li
2016-07-17 15:38                         ` Randy Li
     [not found]                         ` <1468769937-23387-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-17 21:01                           ` Rob Herring
2016-07-17 21:01                             ` Rob Herring
2016-07-18 11:24                           ` Heiko Stübner
2016-07-18 11:24                             ` Heiko Stübner
2016-07-18 15:32                             ` [PATCH v2] " Randy Li
2016-07-18 15:32                               ` Randy Li
2016-07-18 15:32                               ` Randy Li
     [not found]                               ` <1468855952-2006-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-07-18 15:32                                 ` [PATCH] " Randy Li
2016-07-18 15:32                                   ` Randy Li
2016-07-18 15:32                                   ` Randy Li
2016-07-18 19:46                                   ` Heiko Stübner
2016-07-18 19:46                                     ` Heiko Stübner
2016-08-07  3:40                                     ` Shawn Lin
2016-08-07  3:40                                       ` Shawn Lin
2016-08-07  3:40                                       ` Shawn Lin
     [not found]                                       ` <413ebccd-e8d6-1401-3065-f9a63b4d66e6-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-07 14:44                                         ` Heiko Stuebner
2016-08-07 14:44                                           ` Heiko Stuebner
2016-08-07 14:44                                           ` Heiko Stuebner
2016-08-08  2:29                                           ` Shawn Lin
2016-08-08  2:29                                             ` Shawn Lin
2016-08-09  9:28                                           ` 陈豪
2016-08-09  9:28                                             ` 陈豪
2016-08-09  9:28                                             ` 陈豪
     [not found]                                             ` <CAFLEztQ1pa-CCbC8c8+VJ_kg8RyPOb-UHZiKBZffKEw9zyx9Zg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-09 10:02                                               ` 陈豪
2016-08-09 10:02                                                 ` 陈豪
2016-08-09 10:02                                                 ` 陈豪
     [not found]                                                 ` <CAFLEztTROearSEcgzV3EVHFcRcMQpLhAQ6BXP-dDyRDAWybaxg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-08-09 10:06                                                   ` Randy Li
2016-08-09 10:06                                                     ` Randy Li
2016-08-09 10:06                                                     ` Randy Li
     [not found]                                                     ` <C2BE77CA-A59B-4128-8802-E3E36FACDABA-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-09 10:58                                                       ` Heiko Stübner
2016-08-09 10:58                                                         ` Heiko Stübner
2016-08-09 10:58                                                         ` Heiko Stübner
2016-08-10  1:12                                                         ` Randy Li
2016-08-10  1:12                                                           ` Randy Li
2016-08-10  1:12                                                           ` Randy Li
     [not found]                                                           ` <522097f6-8b5c-ee6d-c1b1-a63840228a0e-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-08-14 11:27                                                             ` [PATCH 0/2] ARM: dts: rockchip: correct the regulators in firefly reload Randy Li
2016-08-14 11:27                                                               ` Randy Li
2016-08-14 11:27                                                               ` Randy Li
     [not found]                                                               ` <1471174044-26003-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-14 11:27                                                                 ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-14 11:27                                                                   ` Randy Li
2016-08-14 11:27                                                                   ` Randy Li
2016-08-14 12:30                                                                   ` Heiko Stuebner [this message]
2016-08-14 12:30                                                                     ` Heiko Stuebner
2016-08-14 12:38                                                                     ` ayaka
2016-08-14 12:38                                                                       ` ayaka
2016-08-14 12:38                                                                       ` ayaka
2016-08-17 14:10                                                                       ` Heiko Stübner
2016-08-17 14:10                                                                         ` Heiko Stübner
2016-08-17 17:03                                                                         ` [PATCH 0/2 v2] ARM: dts: rockchip: correct the regulators in " Randy Li
2016-08-17 17:03                                                                           ` Randy Li
2016-08-17 17:03                                                                           ` [PATCH 1/2] ARM: dts: rockchip: remove excess sd properties for " Randy Li
2016-08-17 17:03                                                                             ` Randy Li
     [not found]                                                                             ` <1471453391-10267-2-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-18 13:35                                                                               ` Heiko Stübner
2016-08-18 13:35                                                                                 ` Heiko Stübner
2016-08-18 13:35                                                                                 ` Heiko Stübner
2016-08-18 14:20                                                                                 ` ayaka
2016-08-18 14:20                                                                                   ` ayaka
     [not found]                                                                           ` <1471453391-10267-1-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-17 17:03                                                                             ` [PATCH 2/2] ARM: dts: rockchip: add missing regulators for firefly reload board Randy Li
2016-08-17 17:03                                                                               ` Randy Li
2016-08-17 17:03                                                                               ` Randy Li
     [not found]                                                                               ` <1471453391-10267-3-git-send-email-ayaka-xPW3/0Ywev/iB9QmIjCX8w@public.gmane.org>
2016-08-18 16:47                                                                                 ` Heiko Stübner
2016-08-18 16:47                                                                                   ` Heiko Stübner
2016-08-18 16:47                                                                                   ` Heiko Stübner
2016-08-14 11:27                                                                 ` Randy Li
2016-08-14 11:27                                                                   ` Randy Li
2016-08-14 11:27                                                                   ` Randy Li
2016-07-06 15:25   ` [PATCH 3/3] ARM: dts: add rk3288-firefly-reload ayaka
2016-07-06 15:25     ` ayaka
2016-07-06 15:25     ` ayaka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35898684.O6p1GdTFI2@phil \
    --to=heiko@sntech.de \
    --cc=ayaka@soulik.info \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.