From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Oltean <olteanv@gmail.com>,
andrew@lunn.ch, vivien.didelot@gmail.com, davem@davemloft.net,
o.rempel@pengutronix.de
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU
Date: Tue, 21 Apr 2020 10:20:10 -0700 [thread overview]
Message-ID: <35b913be-edcf-cf3d-fb79-c69c1aa4ff96@gmail.com> (raw)
In-Reply-To: <20200421171853.12572-1-olteanv@gmail.com>
On 4/21/2020 10:18 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
>
> There is no reason to fail the probing of the switch if the MTU couldn't
> be configured correctly (either the switch port itself, or the host
> port) for whatever reason. MTU-sized traffic probably won't work, sure,
> but we can still probably limp on and support some form of communication
> anyway, which the users would probably appreciate more.
>
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2020-04-21 17:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:18 [PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU Vladimir Oltean
2020-04-21 17:20 ` Florian Fainelli [this message]
2020-04-23 2:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35b913be-edcf-cf3d-fb79-c69c1aa4ff96@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.