[PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU

[PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU

[Vladimir Oltean]

From: Vladimir Oltean <vladimir.oltean@nxp.com>

There is no reason to fail the probing of the switch if the MTU couldn't
be configured correctly (either the switch port itself, or the host
port) for whatever reason. MTU-sized traffic probably won't work, sure,
but we can still probably limp on and support some form of communication
anyway, which the users would probably appreciate more.

Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/slave.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index e94eb1aac602..d1068803cd11 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -1770,11 +1770,9 @@ int dsa_slave_create(struct dsa_port *port)
 	rtnl_lock();
 	ret = dsa_slave_change_mtu(slave_dev, ETH_DATA_LEN);
 	rtnl_unlock();
-	if (ret && ret != -EOPNOTSUPP) {
-		dev_err(ds->dev, "error %d setting MTU on port %d\n",
-			ret, port->index);
-		goto out_free;
-	}
+	if (ret)
+		dev_warn(ds->dev, "nonfatal error %d setting MTU on port %d\n",
+			 ret, port->index);
 
 	netif_carrier_off(slave_dev);
 
-- 
2.17.1

Re: [PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU

[Florian Fainelli]

On 4/21/2020 10:18 AM, Vladimir Oltean wrote:
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> There is no reason to fail the probing of the switch if the MTU couldn't
> be configured correctly (either the switch port itself, or the host
> port) for whatever reason. MTU-sized traffic probably won't work, sure,
> but we can still probably limp on and support some form of communication
> anyway, which the users would probably appreciate more.
> 
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH v2 net] net: dsa: don't fail to probe if we couldn't set the MTU

[David Miller]

From: Vladimir Oltean <olteanv@gmail.com>
Date: Tue, 21 Apr 2020 20:18:53 +0300

> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> There is no reason to fail the probing of the switch if the MTU couldn't
> be configured correctly (either the switch port itself, or the host
> port) for whatever reason. MTU-sized traffic probably won't work, sure,
> but we can still probably limp on and support some form of communication
> anyway, which the users would probably appreciate more.
> 
> Fixes: bfcb813203e6 ("net: dsa: configure the MTU for switch ports")
> Reported-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Applied, thanks Vlad.