* [PATCH 0/3] Introducing opencl testing
@ 2025-02-05 20:04 a-christidis
2025-02-05 20:04 ` [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS a-christidis
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: a-christidis @ 2025-02-05 20:04 UTC (permalink / raw)
To: reatmon; +Cc: meta-arago
From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com>
Hello !
This patch series, includes everything needed to start testing opencl.
This includes:
- Recipe to build opencl-cts
- A patch for opencl-cts itself
- A bbappend to bump the version of opencl-headers
Reasoning for the above 3 can be found on the individual patches.
Antonios Christidis (3):
meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS
meta-arago-test: Introducing OpenCL testing
meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08
.../recipes-core/packagegroups/ti-test.bb | 1 +
.../opencl/opencl-headers_%.bbappend | 1 +
.../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++
...Ignore-Compiler-Warnings-Patch-for-O.patch | 61 +++++++++++++++++++
.../opencl/opencl-cts_2024.08.08.bb | 27 ++++++++
5 files changed, 125 insertions(+)
create mode 100644 meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend
create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch
create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch
create mode 100644 meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb
--
2.34.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS 2025-02-05 20:04 [PATCH 0/3] Introducing opencl testing a-christidis @ 2025-02-05 20:04 ` a-christidis 2025-02-06 16:27 ` [EXTERNAL] [meta-arago] " Chirag Shilwant 2025-02-05 20:04 ` [PATCH 2/3] meta-arago-test: Introducing OpenCL testing a-christidis ` (2 subsequent siblings) 3 siblings, 1 reply; 9+ messages in thread From: a-christidis @ 2025-02-05 20:04 UTC (permalink / raw) To: reatmon; +Cc: meta-arago From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> Within the cmake build system, the compiler -Werror flag is enabeled. This turns all warnings into errors and doens't allow the system to compile correctly. Change the system to ignore the 3 warning rules that show up when compiling. Signed-off-by: Antonios Christidis <a-christidis@ti.com> --- .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch new file mode 100644 index 00000000..c21db6fb --- /dev/null +++ b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch @@ -0,0 +1,35 @@ +From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 +From: Antonios Christidis <a-christidis@ti.com> +Date: Fri, 17 Jan 2025 15:05:39 -0600 +Subject: [PATCH] Ignore Compiler Warnings + +Within the cmake build system, the compiler -Werror flag is enabeled. This +turns all warnings into errors and doens't allow the system to compile +correctly. Change the system to ignore the 3 warning rules that show up when +compiling. + +Upstream-Status: Inappropriate [oe specific - compilation errors due to cross-compiling] + +Singed-Off-By: Antonios Christidis <a-christidis@ti.com> +--- + CMakeLists.txt | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/CMakeLists.txt b/CMakeLists.txt +index 5cfef6b3..71b6ddb4 100644 +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" + add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning directive + add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 + add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue #784 +- ++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) ++ add_cxx_flag_if_supported(-Wno-stringop-truncation) ++ add_cxx_flag_if_supported(-Wno-strict-aliasing) + # -msse -mfpmath=sse to force gcc to use sse for float math, + # avoiding excess precision problems that cause tests like int2float + # to falsely fail. -ffloat-store also works, but WG suggested +-- +2.34.1 + -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [EXTERNAL] [meta-arago] [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS 2025-02-05 20:04 ` [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS a-christidis @ 2025-02-06 16:27 ` Chirag Shilwant 0 siblings, 0 replies; 9+ messages in thread From: Chirag Shilwant @ 2025-02-06 16:27 UTC (permalink / raw) To: a-christidis, reatmon; +Cc: meta-arago On 06/02/25 01:34, Antonios Christidis via lists.yoctoproject.org wrote: > From: Antonios Christidis <a0507488@ uda0867391-2. dhcp. ti. com> > Within the cmake build system, the compiler -Werror flag is enabeled. > This turns all warnings into errors and doens't allow the system to > compile correctly. Change the system > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. > Report Suspicious > <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uRdqXRfP1m1bKqYkPNMD_F8gldlTqLdGpJz9zdNE3i7SGylNrydwCm3CzQOW3Meo6Sa62BDFt95wryJu21hgPsXsYH0$> > > ZjQcmQRYFpfptBannerEnd > From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> > > Within the cmake build system, the compiler -Werror flag is enabeled. enabled > This > turns all warnings into errors and doens't doesn't -- Chirag > allow the system to compile > correctly. Change the system to ignore the 3 warning rules that show up when > compiling. > > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > > diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > new file mode 100644 > index 00000000..c21db6fb > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > @@ -0,0 +1,35 @@ > +From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 > +From: Antonios Christidis <a-christidis@ti.com> > +Date: Fri, 17 Jan 2025 15:05:39 -0600 > +Subject: [PATCH] Ignore Compiler Warnings > + > +Within the cmake build system, the compiler -Werror flag is enabeled. This > +turns all warnings into errors and doens't allow the system to compile > +correctly. Change the system to ignore the 3 warning rules that show up when > +compiling. > + > +Upstream-Status: Inappropriate [oe specific - compilation errors due to cross-compiling] > + > +Singed-Off-By: Antonios Christidis <a-christidis@ti.com> > +--- > + CMakeLists.txt | 4 +++- > + 1 file changed, 3 insertions(+), 1 deletion(-) > + > +diff --git a/CMakeLists.txt b/CMakeLists.txt > +index 5cfef6b3..71b6ddb4 100644 > +--- a/CMakeLists.txt > ++++ b/CMakeLists.txt > +@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" > + add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning directive > + add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 > + add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue #784 > +- > ++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) > ++ add_cxx_flag_if_supported(-Wno-stringop-truncation) > ++ add_cxx_flag_if_supported(-Wno-strict-aliasing) > + # -msse -mfpmath=sse to force gcc to use sse for float math, > + # avoiding excess precision problems that cause tests like int2float > + # to falsely fail. -ffloat-store also works, but WG suggested > +-- > +2.34.1 > + > -- > 2.34.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15814):https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/message/15814__;!!G3vK!SE5kwceOXxQ9IuoC2fBFl30oafkus7SzSXSWEgBIwu7_kSG2I-9KQsM5mi9PdnXTyk4UG1bc8v9HTGCGee0L1ERDCn8tCKNQedRA$ > Mute This Topic:https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/111019654/7030289__;!!G3vK!SE5kwceOXxQ9IuoC2fBFl30oafkus7SzSXSWEgBIwu7_kSG2I-9KQsM5mi9PdnXTyk4UG1bc8v9HTGCGee0L1ERDCn8tCP6o9QNC$ > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe:https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/unsub__;!!G3vK!SE5kwceOXxQ9IuoC2fBFl30oafkus7SzSXSWEgBIwu7_kSG2I-9KQsM5mi9PdnXTyk4UG1bc8v9HTGCGee0L1ERDCn8tCJ3iflM5$ [c-shilwant@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] meta-arago-test: Introducing OpenCL testing 2025-02-05 20:04 [PATCH 0/3] Introducing opencl testing a-christidis 2025-02-05 20:04 ` [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS a-christidis @ 2025-02-05 20:04 ` a-christidis 2025-02-06 16:08 ` Ryan Eatmon 2025-02-05 20:04 ` [PATCH 3/3] meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08 a-christidis [not found] ` <18216885381BCE4F.752@lists.yoctoproject.org> 3 siblings, 1 reply; 9+ messages in thread From: a-christidis @ 2025-02-05 20:04 UTC (permalink / raw) To: reatmon; +Cc: meta-arago From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> Adding recipe for opencl-cts, v2024-08-08 is a pre-release version. I have tested it to work with opencl-headers version v2024.05.08 . This version is picked due to incompatibility issues with other versions of headers. The recipe also includes a patch, to allow it to compile and build properly. Further information below. Signed-off-by: Antonios Christidis <a-christidis@ti.com> --- .../recipes-core/packagegroups/ti-test.bb | 1 + ...Ignore-Compiler-Warnings-Patch-for-O.patch | 61 +++++++++++++++++++ .../opencl/opencl-cts_2024.08.08.bb | 27 ++++++++ 3 files changed, 89 insertions(+) create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch create mode 100644 meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb index e8458cef..81f6e1c6 100644 --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb @@ -61,6 +61,7 @@ TI_TEST_EXTRAS = " \ piglit \ python3-numpy \ wayland-utils \ + opencl-cts \ " TI_TEST_BASE:append:armv7a = " \ diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch new file mode 100644 index 00000000..35019946 --- /dev/null +++ b/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch @@ -0,0 +1,61 @@ +From 3f01b7509cf725e9668b8e01d65669fc5626c160 Mon Sep 17 00:00:00 2001 +From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> +Date: Wed, 5 Feb 2025 11:40:22 -0600 +Subject: [meta-arago][scarthgap/master][PATCH] meta-arago-test: Ignore + Compiler Warnings Patch for OpenCL-CTS + +Within the cmake build system, the compiler -Werror flag is enabeled. This +turns all warnings into errors and doens't allow the system to compile +correctly. Change the system to ignore the 3 warning rules that show up when +compiling. + +Signed-off-by: Antonios Christidis <a-christidis@ti.com> +--- + .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ + 1 file changed, 35 insertions(+) + create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch + +diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch +new file mode 100644 +index 00000000..c21db6fb +--- /dev/null ++++ b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch +@@ -0,0 +1,35 @@ ++From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 ++From: Antonios Christidis <a-christidis@ti.com> ++Date: Fri, 17 Jan 2025 15:05:39 -0600 ++Subject: [PATCH] Ignore Compiler Warnings ++ ++Within the cmake build system, the compiler -Werror flag is enabeled. This ++turns all warnings into errors and doens't allow the system to compile ++correctly. Change the system to ignore the 3 warning rules that show up when ++compiling. ++ ++Upstream-Status: Inappropriate [oe specific - compilation errors due to cross-compiling] ++ ++Singed-Off-By: Antonios Christidis <a-christidis@ti.com> ++--- ++ CMakeLists.txt | 4 +++- ++ 1 file changed, 3 insertions(+), 1 deletion(-) ++ ++diff --git a/CMakeLists.txt b/CMakeLists.txt ++index 5cfef6b3..71b6ddb4 100644 ++--- a/CMakeLists.txt +++++ b/CMakeLists.txt ++@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" ++ add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning directive ++ add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 ++ add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue #784 ++- +++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) +++ add_cxx_flag_if_supported(-Wno-stringop-truncation) +++ add_cxx_flag_if_supported(-Wno-strict-aliasing) ++ # -msse -mfpmath=sse to force gcc to use sse for float math, ++ # avoiding excess precision problems that cause tests like int2float ++ # to falsely fail. -ffloat-store also works, but WG suggested ++-- ++2.34.1 ++ +-- +2.34.1 + diff --git a/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb b/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb new file mode 100644 index 00000000..c200884b --- /dev/null +++ b/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb @@ -0,0 +1,27 @@ +SUMMARY = "OpenCL CTS" +DESCRIPTION = "OpenCL CTS test suite" +LICENSE = "Apache-2.0" +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3b83ef96387f14655fc854ddc3c6bd57" + +inherit pkgconfig cmake + +DEPENDS += "opencl-headers opencl-icd-loader" +RDEPENDS:${PN} += "python3-core python3-io" + +S = "${WORKDIR}/git" + +SRC_URI = "git://github.com/KhronosGroup/OpenCL-CTS.git;protocol=https;branch=main;lfs=0 \ + file://0001-Ignore-Compiler-Warnings.patch" + + +SRCREV = "a406b340913f622da089b00f284a597656c10239" + +EXTRA_OECMAKE:append = " -DCMAKE_BUILD_TYPE=Debug -DCL_INCLUDE_DIR=${STAGING_INCDIR} -DCL_LIB_DIR=${STAGING_LIBDIR} -DOPENCL_LIBRARIES=OpenCL" + +do_install() { + install -d ${D}${bindir}/opencl_test_conformance + cp -r ${B}/test_conformance/* ${D}${bindir}/opencl_test_conformance + sed -i 's:/usr/bin/python:/usr/bin/python3:g' ${D}${bindir}/opencl_test_conformance/run_conformance.py + find "${D}${bindir}/opencl_test_conformance" -name cmake_install.cmake -type f -delete + find "${D}${bindir}/opencl_test_conformance" -name CMakeFiles -type d -exec rm -rf "{}" \; -depth +} -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 2/3] meta-arago-test: Introducing OpenCL testing 2025-02-05 20:04 ` [PATCH 2/3] meta-arago-test: Introducing OpenCL testing a-christidis @ 2025-02-06 16:08 ` Ryan Eatmon 0 siblings, 0 replies; 9+ messages in thread From: Ryan Eatmon @ 2025-02-06 16:08 UTC (permalink / raw) To: a-christidis; +Cc: meta-arago On 2/5/2025 2:04 PM, a-christidis@ti.com wrote: > From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> > > Adding recipe for opencl-cts, v2024-08-08 is a pre-release version. > I have tested it to work with opencl-headers version v2024.05.08 . This version > is picked due to incompatibility issues with other versions of headers. > > The recipe also includes a patch, to allow it to compile and build properly. > Further information below. > > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > .../recipes-core/packagegroups/ti-test.bb | 1 + > ...Ignore-Compiler-Warnings-Patch-for-O.patch | 61 +++++++++++++++++++ > .../opencl/opencl-cts_2024.08.08.bb | 27 ++++++++ > 3 files changed, 89 insertions(+) > create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch > create mode 100644 meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb > > diff --git a/meta-arago-test/recipes-core/packagegroups/ti-test.bb b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > index e8458cef..81f6e1c6 100644 > --- a/meta-arago-test/recipes-core/packagegroups/ti-test.bb > +++ b/meta-arago-test/recipes-core/packagegroups/ti-test.bb > @@ -61,6 +61,7 @@ TI_TEST_EXTRAS = " \ > piglit \ > python3-numpy \ > wayland-utils \ > + opencl-cts \ > " Given that this is a patch that should also be for master, please break the adding of the package to ti-test out into it's own patch and not lumped in with add the recipe itself. Also, in the commit make sure to point out that this is a backport of a patch from meta-openembedded on master. And explain that they were not willing to take the patch onto scarthgap due to the LTS issue. > TI_TEST_BASE:append:armv7a = " \ > diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch > new file mode 100644 > index 00000000..35019946 > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/opencl/files/0001-meta-arago-test-Ignore-Compiler-Warnings-Patch-for-O.patch > @@ -0,0 +1,61 @@ > +From 3f01b7509cf725e9668b8e01d65669fc5626c160 Mon Sep 17 00:00:00 2001 > +From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> > +Date: Wed, 5 Feb 2025 11:40:22 -0600 > +Subject: [meta-arago][scarthgap/master][PATCH] meta-arago-test: Ignore > + Compiler Warnings Patch for OpenCL-CTS > + > +Within the cmake build system, the compiler -Werror flag is enabeled. This > +turns all warnings into errors and doens't allow the system to compile > +correctly. Change the system to ignore the 3 warning rules that show up when > +compiling. > + > +Signed-off-by: Antonios Christidis <a-christidis@ti.com> > +--- > + .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ > + 1 file changed, 35 insertions(+) > + create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > + > +diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch Is this an error? The first patch in the series added the patch, this adds the same patch under a different name? > +new file mode 100644 > +index 00000000..c21db6fb > +--- /dev/null > ++++ b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > +@@ -0,0 +1,35 @@ > ++From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 > ++From: Antonios Christidis <a-christidis@ti.com> > ++Date: Fri, 17 Jan 2025 15:05:39 -0600 > ++Subject: [PATCH] Ignore Compiler Warnings > ++ > ++Within the cmake build system, the compiler -Werror flag is enabeled. This > ++turns all warnings into errors and doens't allow the system to compile > ++correctly. Change the system to ignore the 3 warning rules that show up when > ++compiling. > ++ > ++Upstream-Status: Inappropriate [oe specific - compilation errors due to cross-compiling] > ++ > ++Singed-Off-By: Antonios Christidis <a-christidis@ti.com> > ++--- > ++ CMakeLists.txt | 4 +++- > ++ 1 file changed, 3 insertions(+), 1 deletion(-) > ++ > ++diff --git a/CMakeLists.txt b/CMakeLists.txt > ++index 5cfef6b3..71b6ddb4 100644 > ++--- a/CMakeLists.txt > +++++ b/CMakeLists.txt > ++@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" > ++ add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning directive > ++ add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 > ++ add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue #784 > ++- > +++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) > +++ add_cxx_flag_if_supported(-Wno-stringop-truncation) > +++ add_cxx_flag_if_supported(-Wno-strict-aliasing) > ++ # -msse -mfpmath=sse to force gcc to use sse for float math, > ++ # avoiding excess precision problems that cause tests like int2float > ++ # to falsely fail. -ffloat-store also works, but WG suggested > ++-- > ++2.34.1 > ++ > +-- > +2.34.1 > + > diff --git a/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb b/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb > new file mode 100644 > index 00000000..c200884b > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/opencl/opencl-cts_2024.08.08.bb Is this a copy of a recipe from upstream? If so, why do we need to carry it? If we are just waiting on meta-openembedded to accept the patch, then I would prefer to hold off on this patch until it is accepted upstream. Otherwise you are just going to be sending a second patch in a day or so once it is accepted. > @@ -0,0 +1,27 @@ > +SUMMARY = "OpenCL CTS" > +DESCRIPTION = "OpenCL CTS test suite" > +LICENSE = "Apache-2.0" > +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=3b83ef96387f14655fc854ddc3c6bd57" > + > +inherit pkgconfig cmake > + > +DEPENDS += "opencl-headers opencl-icd-loader" > +RDEPENDS:${PN} += "python3-core python3-io" > + > +S = "${WORKDIR}/git" > + > +SRC_URI = "git://github.com/KhronosGroup/OpenCL-CTS.git;protocol=https;branch=main;lfs=0 \ > + file://0001-Ignore-Compiler-Warnings.patch" > + > + > +SRCREV = "a406b340913f622da089b00f284a597656c10239" > + > +EXTRA_OECMAKE:append = " -DCMAKE_BUILD_TYPE=Debug -DCL_INCLUDE_DIR=${STAGING_INCDIR} -DCL_LIB_DIR=${STAGING_LIBDIR} -DOPENCL_LIBRARIES=OpenCL" > + > +do_install() { > + install -d ${D}${bindir}/opencl_test_conformance > + cp -r ${B}/test_conformance/* ${D}${bindir}/opencl_test_conformance > + sed -i 's:/usr/bin/python:/usr/bin/python3:g' ${D}${bindir}/opencl_test_conformance/run_conformance.py > + find "${D}${bindir}/opencl_test_conformance" -name cmake_install.cmake -type f -delete > + find "${D}${bindir}/opencl_test_conformance" -name CMakeFiles -type d -exec rm -rf "{}" \; -depth > +} -- Ryan Eatmon reatmon@ti.com ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08 2025-02-05 20:04 [PATCH 0/3] Introducing opencl testing a-christidis 2025-02-05 20:04 ` [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS a-christidis 2025-02-05 20:04 ` [PATCH 2/3] meta-arago-test: Introducing OpenCL testing a-christidis @ 2025-02-05 20:04 ` a-christidis 2025-02-06 15:54 ` Ryan Eatmon [not found] ` <18216885381BCE4F.752@lists.yoctoproject.org> 3 siblings, 1 reply; 9+ messages in thread From: a-christidis @ 2025-02-05 20:04 UTC (permalink / raw) To: reatmon; +Cc: meta-arago From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> This version of the headers is required for OpenCl-CTS. Carry this bbappend, as a version pump wasn't possible on the upstream meta-oe layer. As per the LTS process. Signed-Off-By: Antonios Christidis <a-christidis@ti.com> --- .../recipes-extended/opencl/opencl-headers_%.bbappend | 1 + 1 file changed, 1 insertion(+) create mode 100644 meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend diff --git a/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend b/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend new file mode 100644 index 00000000..4dff02d9 --- /dev/null +++ b/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend @@ -0,0 +1 @@ +SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d" -- 2.34.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08 2025-02-05 20:04 ` [PATCH 3/3] meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08 a-christidis @ 2025-02-06 15:54 ` Ryan Eatmon 0 siblings, 0 replies; 9+ messages in thread From: Ryan Eatmon @ 2025-02-06 15:54 UTC (permalink / raw) To: a-christidis; +Cc: meta-arago On 2/5/2025 2:04 PM, a-christidis@ti.com wrote: > From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> > > This version of the headers is required for OpenCl-CTS. > > Carry this bbappend, as a version pump wasn't possible on the upstream meta-oe > layer. As per the LTS process. > > Signed-Off-By: Antonios Christidis <a-christidis@ti.com> > --- > .../recipes-extended/opencl/opencl-headers_%.bbappend | 1 + > 1 file changed, 1 insertion(+) > create mode 100644 meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend > > diff --git a/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend b/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend > new file mode 100644 > index 00000000..4dff02d9 > --- /dev/null > +++ b/meta-arago-test/recipes-extended/opencl/opencl-headers_%.bbappend > @@ -0,0 +1 @@ > +SRCREV = "8275634cf9ec31b6484c2e6be756237cb583999d" This is problematic. We are working to move at least meta-arago-test to be be yocto compliant and bare .bbappends that change things like this are considered bad form. Here is an example of an upcoming patch that I will be sending to adress this same issue with the piglit package: https://git.ti.com/cgit/arago-project/meta-arago/commit/?id=ecc08cf6204f9f935f39fe5308efbb537b99824e Part of the log term plan has been to move meta-arago-test over to meta-ti-test in the meta-ti repo. And that repository is yocto compliant and we want to always keep it. -- Ryan Eatmon reatmon@ti.com ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <18216885381BCE4F.752@lists.yoctoproject.org>]
* Re: [EXTERNAL] [meta-arago] [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS [not found] ` <18216885381BCE4F.752@lists.yoctoproject.org> @ 2025-02-05 20:12 ` Antonios Christidis 2025-02-06 16:08 ` Ryan Eatmon 0 siblings, 1 reply; 9+ messages in thread From: Antonios Christidis @ 2025-02-05 20:12 UTC (permalink / raw) To: meta-arago Forgot to tag the patches. All patches in this series are for scarthgap. On 2/5/25 2:04 PM, Antonios Christidis via lists.yoctoproject.org wrote: > From: Antonios Christidis <a0507488@ uda0867391-2. dhcp. ti. com> > Within the cmake build system, the compiler -Werror flag is enabeled. > This turns all warnings into errors and doens't allow the system to > compile correctly. Change the system > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source > of this email and know the content is safe. > Report Suspicious > <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uRdqPBfPVqwaKqYFPP3NsvaOW-AC0f2W5AKZr2gZk4GyKmNn6P9WH_O3f5crwuRtqfpZzQALJjaRVfm6nsYFMQwAZs8g$> > > ZjQcmQRYFpfptBannerEnd > From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> > > Within the cmake build system, the compiler -Werror flag is enabeled. This > turns all warnings into errors and doens't allow the system to compile > correctly. Change the system to ignore the 3 warning rules that show up when > compiling. > > Signed-off-by: Antonios Christidis <a-christidis@ti.com> > --- > .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > create mode 100644 meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > > diff --git a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > new file mode 100644 > index 00000000..c21db6fb > --- /dev/null > +++ b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch > @@ -0,0 +1,35 @@ > +From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 > +From: Antonios Christidis <a-christidis@ti.com> > +Date: Fri, 17 Jan 2025 15:05:39 -0600 > +Subject: [PATCH] Ignore Compiler Warnings > + > +Within the cmake build system, the compiler -Werror flag is enabeled. This > +turns all warnings into errors and doens't allow the system to compile > +correctly. Change the system to ignore the 3 warning rules that show up when > +compiling. > + > +Upstream-Status: Inappropriate [oe specific - compilation errors due to cross-compiling] > + > +Singed-Off-By: Antonios Christidis <a-christidis@ti.com> > +--- > + CMakeLists.txt | 4 +++- > + 1 file changed, 3 insertions(+), 1 deletion(-) > + > +diff --git a/CMakeLists.txt b/CMakeLists.txt > +index 5cfef6b3..71b6ddb4 100644 > +--- a/CMakeLists.txt > ++++ b/CMakeLists.txt > +@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" > + add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning directive > + add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 > + add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue #784 > +- > ++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) > ++ add_cxx_flag_if_supported(-Wno-stringop-truncation) > ++ add_cxx_flag_if_supported(-Wno-strict-aliasing) > + # -msse -mfpmath=sse to force gcc to use sse for float math, > + # avoiding excess precision problems that cause tests like int2float > + # to falsely fail. -ffloat-store also works, but WG suggested > +-- > +2.34.1 > + > -- > 2.34.1 > > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15814):https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/message/15814__;!!G3vK!VU6Bx3Q5OIRRTq2hv8bOVDuwJFJNPEUWBXxrYPF1d_H8AjBdwcpTefEFc4WHcFSEFI5XC9ty1GZ516xqqesdeOnMeHGcxUKh3zxd$ > Mute This Topic:https://urldefense.com/v3/__https://lists.yoctoproject.org/mt/111019654/9164840__;!!G3vK!VU6Bx3Q5OIRRTq2hv8bOVDuwJFJNPEUWBXxrYPF1d_H8AjBdwcpTefEFc4WHcFSEFI5XC9ty1GZ516xqqesdeOnMeHGcxTPinxbc$ > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe:https://urldefense.com/v3/__https://lists.yoctoproject.org/g/meta-arago/unsub__;!!G3vK!VU6Bx3Q5OIRRTq2hv8bOVDuwJFJNPEUWBXxrYPF1d_H8AjBdwcpTefEFc4WHcFSEFI5XC9ty1GZ516xqqesdeOnMeHGcxQVuUZZq$ [a-christidis@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [meta-arago] [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS 2025-02-05 20:12 ` [EXTERNAL] [meta-arago] [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS Antonios Christidis @ 2025-02-06 16:08 ` Ryan Eatmon 0 siblings, 0 replies; 9+ messages in thread From: Ryan Eatmon @ 2025-02-06 16:08 UTC (permalink / raw) To: a-christidis, meta-arago On 2/5/2025 2:12 PM, Antonios Christidis via lists.yoctoproject.org wrote: > Forgot to tag the patches. All patches in this series are for scarthgap. There needs to be a master version of this patch that adds the package to ti-test. > On 2/5/25 2:04 PM, Antonios Christidis via lists.yoctoproject.org wrote: >> From: Antonios Christidis <a0507488@ uda0867391-2. dhcp. ti. com> >> Within the cmake build system, the compiler -Werror flag is enabeled. >> This turns all warnings into errors and doens't allow the system to >> compile correctly. Change the system >> ZjQcmQRYFpfptBannerStart >> This message was sent from outside of Texas Instruments. >> Do not click links or open attachments unless you recognize the source >> of this email and know the content is safe. >> Report Suspicious >> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uRdqPBfPVqwaKqYFPP3NsvaOW-AC0f2W5AKZr2gZk4GyKmNn6P9WH_O3f5crwuRtqfpZzQALJjaRVfm6nsYFMQwAZs8g$> >> ZjQcmQRYFpfptBannerEnd >> From: Antonios Christidis <a0507488@uda0867391-2.dhcp.ti.com> >> >> Within the cmake build system, the compiler -Werror flag is enabeled. >> This >> turns all warnings into errors and doens't allow the system to compile >> correctly. Change the system to ignore the 3 warning rules that show >> up when >> compiling. >> >> Signed-off-by: Antonios Christidis <a-christidis@ti.com> >> --- >> .../files/0001-Ignore-Compiler-Warnings.patch | 35 +++++++++++++++++++ >> 1 file changed, 35 insertions(+) >> create mode 100644 >> meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch >> >> diff --git >> a/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch >> new file mode 100644 >> index 00000000..c21db6fb >> --- /dev/null >> +++ >> b/meta-arago-test/recipes-graphics/opencl/files/0001-Ignore-Compiler-Warnings.patch >> @@ -0,0 +1,35 @@ >> +From 082ce10dd191f036f5a6e1fb31134e9736ba3643 Mon Sep 17 00:00:00 2001 >> +From: Antonios Christidis <a-christidis@ti.com> >> +Date: Fri, 17 Jan 2025 15:05:39 -0600 >> +Subject: [PATCH] Ignore Compiler Warnings >> + >> +Within the cmake build system, the compiler -Werror flag is >> enabeled. This >> +turns all warnings into errors and doens't allow the system to compile >> +correctly. Change the system to ignore the 3 warning rules that show >> up when >> +compiling. >> + >> +Upstream-Status: Inappropriate [oe specific - compilation errors due >> to cross-compiling] >> + >> +Singed-Off-By: Antonios Christidis <a-christidis@ti.com> >> +--- >> + CMakeLists.txt | 4 +++- >> + 1 file changed, 3 insertions(+), 1 deletion(-) >> + >> +diff --git a/CMakeLists.txt b/CMakeLists.txt >> +index 5cfef6b3..71b6ddb4 100644 >> +--- a/CMakeLists.txt >> ++++ b/CMakeLists.txt >> +@@ -109,7 +109,9 @@ if(CMAKE_COMPILER_IS_GNUCC OR >> "${CMAKE_CXX_COMPILER_ID}" MATCHES "(Apple)?Clang" >> + add_cxx_flag_if_supported(-Wno-error=cpp) # Allow #warning >> directive >> + add_cxx_flag_if_supported(-Wno-unknown-pragmas) # Issue #785 >> + add_cxx_flag_if_supported(-Wno-error=asm-operand-widths) # Issue >> #784 >> +- >> ++ add_cxx_flag_if_supported(-Wno-maybe-uninitialized) >> ++ add_cxx_flag_if_supported(-Wno-stringop-truncation) >> ++ add_cxx_flag_if_supported(-Wno-strict-aliasing) >> + # -msse -mfpmath=sse to force gcc to use sse for float math, >> + # avoiding excess precision problems that cause tests like >> int2float >> + # to falsely fail. -ffloat-store also works, but WG suggested >> +-- >> +2.34.1 >> + >> -- >> 2.34.1 >> >> >> >> >> >> > > > -=-=-=-=-=-=-=-=-=-=-=- > Links: You receive all messages sent to this group. > View/Reply Online (#15818): > https://lists.yoctoproject.org/g/meta-arago/message/15818 > Mute This Topic: https://lists.yoctoproject.org/mt/111019823/6551054 > Group Owner: meta-arago+owner@lists.yoctoproject.org > Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub > [reatmon@ti.com] > -=-=-=-=-=-=-=-=-=-=-=- > > -- Ryan Eatmon reatmon@ti.com ----------------------------------------- Texas Instruments, Inc. - LCPD - MGTS ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2025-02-06 16:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-05 20:04 [PATCH 0/3] Introducing opencl testing a-christidis
2025-02-05 20:04 ` [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS a-christidis
2025-02-06 16:27 ` [EXTERNAL] [meta-arago] " Chirag Shilwant
2025-02-05 20:04 ` [PATCH 2/3] meta-arago-test: Introducing OpenCL testing a-christidis
2025-02-06 16:08 ` Ryan Eatmon
2025-02-05 20:04 ` [PATCH 3/3] meta-arago-test: opencl-headers version v2023.12.14->v2024.05.08 a-christidis
2025-02-06 15:54 ` Ryan Eatmon
[not found] ` <18216885381BCE4F.752@lists.yoctoproject.org>
2025-02-05 20:12 ` [EXTERNAL] [meta-arago] [PATCH 1/3] meta-arago-test: Ignore Compiler Warnings Patch for OpenCL-CTS Antonios Christidis
2025-02-06 16:08 ` Ryan Eatmon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.