[Kernel-janitors] LinuxCPD - New mini project

[Kernel-janitors] LinuxCPD - New mini project

[Aaron Grothe]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Hi,

I've put a small project up at Sourceforge http://linuxcpd.sf.net

The project is called LinuxCPD for Linux Cut and Paste Detection.  The goal of the project is to
hopefully lead to some refactoring of the kernel and reducing the amount of Cut and Pasted code in
the kernel.

It runs Red Hill consulting's Simian tool against the 2.4 and 2.6 kernel and reports all sections
of code that are duplicated that are larger than 50 lines.  Looking at I'm happily surprised about
how much less duplicated code there appears to be in the 2.6 kernel series.

If anybody has any ideas or suggestions on how to make this tool more useful I would be very
appreciative.

Regards,

Aaron
=-=-=
"The Journey is the Reward" - Old Zen Buddhist Saying


		
__________________________________
Do you Yahoo!?
Read only the mail you want - Yahoo! Mail SpamGuard.
http://promotions.yahoo.com/new_mail 

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] LinuxCPD - New mini project

[Jon Masters]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

On Tue, 28 Sep 2004 18:05:32 -0700 (PDT), Aaron Grothe
<ajgrothe@yahoo.com> wrote:

> I've put a small project up at Sourceforge http://linuxcpd.sf.net

> Looking at I'm happily surprised about
> how much less duplicated code there appears to be in the 2.6 kernel series.

Generally a good thing. It does reveal quite a few duplications
between ppc and ppc64 trees which might be worth pursuing sometime.

Jon.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] LinuxCPD - New mini project

[Arnd Bergmann]

[-- Attachment #1.1: Type: text/plain, Size: 1855 bytes --]

On Mittwoch, 29. September 2004 03:51, Jon Masters wrote:
> On Tue, 28 Sep 2004 18:05:32 -0700 (PDT), Aaron Grothe
> <ajgrothe@yahoo.com> wrote:
> 
> > I've put a small project up at Sourceforge http://linuxcpd.sf.net
> 
> > Looking at I'm happily surprised about
> > how much less duplicated code there appears to be in the 2.6 kernel series.

Much of the improvements can probably be attributed to merging the 64 bit
subarchitectures of mips and s390 into their respective 32 bit trees.

> Generally a good thing. It does reveal quite a few duplications
> between ppc and ppc64 trees which might be worth pursuing sometime.

It may not be a good idea to follow the same route as mips and s390
for ppc64 and completely get rid of the 64 bit tree, because the ppc64
tree already doesn't need much of the legacy code in ppc.
OTOH, it would be nice to share the include/asm tree in order to
simplify life for multilib build environments. For arch/ppc*/, we
could follow the approach of x86_64, where the files with identical
functionality are simply built in the arch/i386 tree. See the
patch below for a trivial example of this (these two files are
already identical on ppc and ppc64).
Unifying the xmon directory could be something more interesting.

	Arnd <><

diff -u -r1.2 Makefile
--- ./arch/ppc64/lib/Makefile	7 Sep 2004 10:32:45 -0000	1.2
+++ ./arch/ppc64/lib/Makefile	29 Sep 2004 13:06:00 -0000
@@ -2,8 +2,11 @@
 # Makefile for ppc64-specific library files..
 #
 
-lib-y := checksum.o dec_and_lock.o string.o strcase.o
+lib-y := checksum.o string.o 
 lib-y += copypage.o memcpy.o copyuser.o
+
+obj-y += ppclib.o
+ppclib-y := $(addprefix ../../ppc/lib/,dec_and_lock.o strcase.o)
 
 # Lock primitives are defined as no-ops in include/linux/spinlock.h
 # for non-SMP configs. Don't build the real versions.

[-- Attachment #1.2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors