From: Michael Neuling <mikey@neuling.org>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@lists.ozlabs.org, Philippe De Muyter <phdm@macqel.be>
Subject: powerpc/ptrace: Fix brk.len used uninitialised
Date: Tue, 12 Mar 2013 13:42:49 +1100 [thread overview]
Message-ID: <3606.1363056169@ale.ozlabs.ibm.com> (raw)
In-Reply-To: <20130308102422.GA25184@frolo.macqel>
With some CONFIGS it's possible that in ppc_set_hwdebug, brk.len is
uninitialised before being used. It has been reported that GCC 4.2 will
produce the following error in this case:
arch/powerpc/kernel/ptrace.c:1479: warning: 'brk.len' is used uninitialized in this function
arch/powerpc/kernel/ptrace.c:1381: note: 'brk.len' was declared here
This patch corrects this.
Signed-off-by: Michael Neuling <mikey@neuling.org>
Reported-by: Philippe De Muyter <phdm@macqel.be>
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index 245c1b6..f9b30c6 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -1428,6 +1428,7 @@ static long ppc_set_hwdebug(struct task_struct *child,
brk.address = bp_info->addr & ~7UL;
brk.type = HW_BRK_TYPE_TRANSLATE;
+ brk.len = 8;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ)
brk.type |= HW_BRK_TYPE_READ;
if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_WRITE)
prev parent reply other threads:[~2013-03-12 2:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 6:00 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized Philippe De Muyter
2013-03-06 6:00 ` Philippe De Muyter
2013-03-06 22:09 ` Michael Neuling
2013-03-06 22:09 ` Michael Neuling
2013-03-06 22:36 ` Philippe De Muyter
2013-03-06 22:36 ` Philippe De Muyter
2013-03-06 23:14 ` Michael Neuling
2013-03-06 23:14 ` Michael Neuling
2013-03-07 9:59 ` Philippe De Muyter
2013-03-07 9:59 ` Philippe De Muyter
2013-03-07 22:32 ` Michael Neuling
2013-03-07 22:32 ` Michael Neuling
2013-03-07 23:03 ` Michael Neuling
2013-03-07 23:03 ` Michael Neuling
2013-03-08 10:24 ` Philippe De Muyter
2013-03-08 10:24 ` Philippe De Muyter
2013-03-12 2:42 ` Michael Neuling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3606.1363056169@ale.ozlabs.ibm.com \
--to=mikey@neuling.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.