From: Philippe De Muyter <phdm@macqel.be>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized
Date: Fri, 8 Mar 2013 11:24:22 +0100 [thread overview]
Message-ID: <20130308102422.GA25184@frolo.macqel> (raw)
In-Reply-To: <11606.1362697414@ale.ozlabs.ibm.com>
On Fri, Mar 08, 2013 at 10:03:34AM +1100, Michael Neuling wrote:
> Michael Neuling <mikey@neuling.org> wrote:
>
> diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> index 245c1b6..8564515 100644
> --- a/arch/powerpc/kernel/ptrace.c
> +++ b/arch/powerpc/kernel/ptrace.c
> @@ -1428,6 +1428,7 @@ static long ppc_set_hwdebug(struct task_struct *child,
>
> brk.address = bp_info->addr & ~7UL;
> brk.type = HW_BRK_TYPE_TRANSLATE;
> + brk.len = 0;
> if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ)
> brk.type |= HW_BRK_TYPE_READ;
> if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_WRITE)
That's ok. Thanks
Philippe
WARNING: multiple messages have this Message-ID (diff)
From: Philippe De Muyter <phdm@macqel.be>
To: Michael Neuling <mikey@neuling.org>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized
Date: Fri, 8 Mar 2013 11:24:22 +0100 [thread overview]
Message-ID: <20130308102422.GA25184@frolo.macqel> (raw)
In-Reply-To: <11606.1362697414@ale.ozlabs.ibm.com>
On Fri, Mar 08, 2013 at 10:03:34AM +1100, Michael Neuling wrote:
> Michael Neuling <mikey@neuling.org> wrote:
>
> diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
> index 245c1b6..8564515 100644
> --- a/arch/powerpc/kernel/ptrace.c
> +++ b/arch/powerpc/kernel/ptrace.c
> @@ -1428,6 +1428,7 @@ static long ppc_set_hwdebug(struct task_struct *child,
>
> brk.address = bp_info->addr & ~7UL;
> brk.type = HW_BRK_TYPE_TRANSLATE;
> + brk.len = 0;
> if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_READ)
> brk.type |= HW_BRK_TYPE_READ;
> if (bp_info->trigger_type & PPC_BREAKPOINT_TRIGGER_WRITE)
That's ok. Thanks
Philippe
next prev parent reply other threads:[~2013-03-08 10:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 6:00 3.9-rc1 powerpc ptrace.c: 'brk.len' is used uninitialized Philippe De Muyter
2013-03-06 6:00 ` Philippe De Muyter
2013-03-06 22:09 ` Michael Neuling
2013-03-06 22:09 ` Michael Neuling
2013-03-06 22:36 ` Philippe De Muyter
2013-03-06 22:36 ` Philippe De Muyter
2013-03-06 23:14 ` Michael Neuling
2013-03-06 23:14 ` Michael Neuling
2013-03-07 9:59 ` Philippe De Muyter
2013-03-07 9:59 ` Philippe De Muyter
2013-03-07 22:32 ` Michael Neuling
2013-03-07 22:32 ` Michael Neuling
2013-03-07 23:03 ` Michael Neuling
2013-03-07 23:03 ` Michael Neuling
2013-03-08 10:24 ` Philippe De Muyter [this message]
2013-03-08 10:24 ` Philippe De Muyter
2013-03-12 2:42 ` powerpc/ptrace: Fix brk.len used uninitialised Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308102422.GA25184@frolo.macqel \
--to=phdm@macqel.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.