All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>,
	devicetree@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: Add docs for EL15203000
Date: Fri, 7 Jun 2019 16:26:41 -0500	[thread overview]
Message-ID: <361ecc6a-b0b6-1bc9-a52b-e3531340deeb@ti.com> (raw)
In-Reply-To: <adf5a755-c534-64c3-6e99-ba39ffea95e2@kaa.org.ua>

Oleh

On 6/7/19 4:17 PM, Oleh Kravchenko wrote:
> Dan,
>
> On 08.06.19 00:04, Dan Murphy wrote:
>> Oleh
>> But this is not really max_brightness now this is a feature and now
>> does not make sense in this context
>>>> You may need to use something different for this property or expose
>>>> a file in the driver.
>>>>
>>>>
>>> Protocol for this board define 0x32 as brightness level.
>>> This behaviur needed to keep backward compatibity.
>>>
>>>
>> Backwards compatibility to what?
> With old/new boards.

This does not make sense.

How would a device tree entry or a file that controls the blinking have 
to deal with the hardware?

If it allows feature setting then you should create a bool in the device 
tree.

el15203000-blink;

If the board supports the feature you set this and create a file to 
dis/enable the feature.

If the board does not support it then no file is created.

max_brightness for this device appears to be 1.

Dan


>> This is a new driver there should be no DT that has this compatible or
>> definition.
>>
>> I will let Rob ack or nack this node.
>>
>> Dan
>>
>

      parent reply	other threads:[~2019-06-07 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-07 18:40 [PATCH v2 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-06-07 20:14 ` Dan Murphy
2019-06-07 20:53   ` Oleh Kravchenko
2019-06-07 21:04     ` Dan Murphy
2019-06-07 21:17       ` Oleh Kravchenko
2019-06-07 21:23         ` Jacek Anaszewski
2019-06-07 21:48           ` Oleh Kravchenko
2019-06-07 22:12             ` Oleh Kravchenko
     [not found]               ` <e1fc84a1-75e4-6c56-d2ea-f6ade28087ac@kaa.org.ua>
     [not found]                 ` <e4e0223d-c463-e767-12b2-7e360eac000b@gmail.com>
     [not found]                   ` <38050529-5730-6e88-fe1a-909492711dd0@kaa.org.ua>
     [not found]                     ` <8f658d57-5079-ad76-ce3e-af3d031b4685@gmail.com>
     [not found]                       ` <20190611120156.GA1161@amd>
     [not found]                         ` <9e812391-56e9-2dd5-1f08-435df717b12b@gmail.com>
2019-07-08 22:00                           ` Oleh Kravchenko
2019-07-16 18:41                             ` Jacek Anaszewski
2019-07-16 20:35                               ` Oleh Kravchenko
2019-06-09 12:23             ` Jacek Anaszewski
2019-06-07 21:26         ` Dan Murphy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=361ecc6a-b0b6-1bc9-a52b-e3531340deeb@ti.com \
    --to=dmurphy@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=oleg@kaa.org.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.