From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: Oleh Kravchenko <oleg@kaa.org.ua>, Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: Add docs for EL15203000
Date: Tue, 16 Jul 2019 20:41:37 +0200 [thread overview]
Message-ID: <7d71e2a7-5dcf-7dd8-71a7-eee5c07fb1d0@gmail.com> (raw)
In-Reply-To: <8d0d6893-212c-41c4-fef8-76417eb45399@kaa.org.ua>
Hi Oleh,
On 7/9/19 12:00 AM, Oleh Kravchenko wrote:
> Hello Jacek,
>
> 11.06.19 22:52, Jacek Anaszewski пише:
>> On 6/11/19 2:01 PM, Pavel Machek wrote:
>>> Hi!
>>>
>>>>> I just want to clerify - for now LEDs board has 2 from 3 LEDs with effect function.
>>>>>
>>>>> 1. Screen frame led is just blinking, so blink_set() is fit well to this.
>>>>> 2. Pipe led actually consist from 3 leds and when effect is enabled next pattern is used:
>>>>>
>>>>> ^
>>>>> |
>>>>> LED1 > OFF ON ON ON
>>>>> |
>>>>> LED2 > OFF OFF ON ON
>>>>> |
>>>>> LED3 > OFF OFF OFF ON
>>>>> |
>>>>> +----^----^----^----^----> time
>>>>
>>>> Pattern trigger applies to a single LED so it won't fit for this
>>>> pattern.
>>>>
>>>> Currently we don't support patterns spanning on multiple LEDs,
>>>> so you would have to come up with your own solution.
>>>>
>>>> What I can recommend is a trigger that would be created by your driver
>>>> and would activate this sequence.
>>>
>>> Yes, please.
>>>
>>> While adding custom files to sysfs may appear easier, we'll need
>>> "led-specific-triggers" for other reasons.
>>
>> For what reasons exactly?
>>
>> This is similar to the generic hw trigger support proposed by
>> Marek Behun. In the reply to that patch I asked some questions [0].
>> So far the mechanism looks too me awkward and not introducing any
>> novelty besides requiring one more step - setting the trigger.
>>
>>> And for the record... Handling 3 LEDs as one is not something usual in
>>> the LED subsystem; I guess it makes sense in your specific case, but
>>> hopefully noone will copy that design.
>>>
>>> (I guess they are not individually controllable?)
>>>
>>> Pavel
>>>
>>
>> [0] https://www.spinics.net/lists/linux-leds/msg12269.html
>>
>
> I just figure out that this Pipe LED actually consist from 5 LEDs, not 3 :)
> And supports next level 'brightness' from SPI driver:
> - '0' Off
> - '1' On
> - '2' Cascade (waterfall down)
> -'3' InverseCascade (waterfall up)
> - '4' Bounce
> - '5' InverseBounce
>
> Please advice, can I proceed with sys attribute file to set '2'..'5' levels?
It looks like pattern trigger is the most appropriate solution for the
effects 2-5. Your driver will need to implement pattern_set op for the
LEDs supporting the effects, and then the effect will be enabled after
writing required sequence to the hw_pattern file. You will need to come
up with a sequence of values that the driver will recognize as a request
of enabling given hardware effect. Please compare
drivers/leds/leds-sc27xx-bltc.c and its ABI documentation [0] for
reference. See also hw_pattern file description in [1].
[0] Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
[1] Documentation/ABI/testing/sysfs-class-led-trigger-pattern
--
Best regards,
Jacek Anaszewski
next prev parent reply other threads:[~2019-07-16 18:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 18:40 [PATCH v2 1/2] dt-bindings: Add docs for EL15203000 Oleh Kravchenko
2019-06-07 20:14 ` Dan Murphy
2019-06-07 20:53 ` Oleh Kravchenko
2019-06-07 21:04 ` Dan Murphy
2019-06-07 21:17 ` Oleh Kravchenko
2019-06-07 21:23 ` Jacek Anaszewski
2019-06-07 21:48 ` Oleh Kravchenko
2019-06-07 22:12 ` Oleh Kravchenko
[not found] ` <e1fc84a1-75e4-6c56-d2ea-f6ade28087ac@kaa.org.ua>
[not found] ` <e4e0223d-c463-e767-12b2-7e360eac000b@gmail.com>
[not found] ` <38050529-5730-6e88-fe1a-909492711dd0@kaa.org.ua>
[not found] ` <8f658d57-5079-ad76-ce3e-af3d031b4685@gmail.com>
[not found] ` <20190611120156.GA1161@amd>
[not found] ` <9e812391-56e9-2dd5-1f08-435df717b12b@gmail.com>
2019-07-08 22:00 ` Oleh Kravchenko
2019-07-16 18:41 ` Jacek Anaszewski [this message]
2019-07-16 20:35 ` Oleh Kravchenko
2019-06-09 12:23 ` Jacek Anaszewski
2019-06-07 21:26 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d71e2a7-5dcf-7dd8-71a7-eee5c07fb1d0@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.