From: "Heiko Stübner" <heiko@sntech.de>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: atishp@atishpatra.org, anup@brainfault.org,
Will Deacon <will@kernel.org>,
mark.rutland@arm.com, Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Conor.Dooley@microchip.com,
samuel@sholland.org
Subject: Re: [PATCH v6 0/2] riscv_pmu_sbi: add support for PMU variant on T-Head C9xx cores
Date: Thu, 27 Oct 2022 21:53:20 +0200 [thread overview]
Message-ID: <3621249.aeNJFYEL58@diego> (raw)
In-Reply-To: <mhng-0bf8c154-76ce-4cd3-bfdb-ffd8a4670600@palmer-ri-x1c9>
Am Donnerstag, 27. Oktober 2022, 07:02:59 CEST schrieb Palmer Dabbelt:
> On Tue, 11 Oct 2022 16:18:39 PDT (-0700), heiko@sntech.de wrote:
> > The PMU on T-Head C9xx cores is quite similar to the SSCOFPMF extension
> > but not completely identical, so this series
>
> The rest of that sentance got dropped, so I put in
>
> The PMU on T-Head C9xx cores is quite similar to the SSCOFPMF extension
> but not completely identical, so this series adds a T-Head PMU errata
> that handlen the differences.
>
> but LMK if you had a better version, it's still early so I don't mind
> swapping it around.
sounds just fine and sorry for not finishing that sentence on my own.
> b4 also got kind of confused here so I had to merge suff manually.
do you still know what b4 complained about?
My patch workflow is pretty basic (git format-patch + separate
git send-email) so I guess it might be interesting what it was
stumbling on.
Thanks
Heiko
> > changes in v6:
> > - follow Anup's suggestion and hook into the (pending) cpuinfo patch [2]
> > instead of modifying the core sbi_get_* functions
> >
> > changes in v5:
> > - add received Reviews
> > - fix sbi caching wrt. negative values (Drew)
> > - add comment about specific c9xx arch- and imp-ids (Conor)
> >
> > changes in v4:
> > - add new patch to cache sbi mvendor, march and mimp-ids (Atish)
> > - errata dependencies in one line (Conor)
> > - make driver detection conditional on CONFIG_ERRATA_THEAD_PMU too (Atish)
> >
> > changes in v3:
> > - improve commit message (Atish, Conor)
> > - IS_ENABLED and BIT() in errata probe (Conor)
> >
> > The change depends on my cpufeature/t-head errata probe cleanup series [1].
> >
> >
> > changes in v2:
> > - use alternatives for the CSR access
> > - make the irq num selection a bit nicer
> >
> > There is of course a matching opensbi-part whose most recent implementation
> > can be found on [0].
> >
> >
> > [0] https://patchwork.ozlabs.org/project/opensbi/cover/20221004164227.1381825-1-heiko@sntech.de
> > [1] https://lore.kernel.org/all/20220905111027.2463297-1-heiko@sntech.de/
> > [2] https://lore.kernel.org/r/20220727043829.151794-1-apatel@ventanamicro.com
> >
> > Heiko Stuebner (2):
> > RISC-V: Cache SBI vendor values
> > drivers/perf: riscv_pmu_sbi: add support for PMU variant on T-Head
> > C9xx cores
> >
> > arch/riscv/Kconfig.erratas | 13 +++++++++++
> > arch/riscv/errata/thead/errata.c | 19 ++++++++++++++++
> > arch/riscv/include/asm/errata_list.h | 16 ++++++++++++-
> > arch/riscv/include/asm/sbi.h | 5 ++++
> > arch/riscv/kernel/cpu.c | 30 +++++++++++++++++++++---
> > drivers/perf/riscv_pmu_sbi.c | 34 ++++++++++++++++++++--------
> > 6 files changed, 103 insertions(+), 14 deletions(-)
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: atishp@atishpatra.org, anup@brainfault.org,
Will Deacon <will@kernel.org>,
mark.rutland@arm.com, Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Conor.Dooley@microchip.com,
samuel@sholland.org
Subject: Re: [PATCH v6 0/2] riscv_pmu_sbi: add support for PMU variant on T-Head C9xx cores
Date: Thu, 27 Oct 2022 21:53:20 +0200 [thread overview]
Message-ID: <3621249.aeNJFYEL58@diego> (raw)
In-Reply-To: <mhng-0bf8c154-76ce-4cd3-bfdb-ffd8a4670600@palmer-ri-x1c9>
Am Donnerstag, 27. Oktober 2022, 07:02:59 CEST schrieb Palmer Dabbelt:
> On Tue, 11 Oct 2022 16:18:39 PDT (-0700), heiko@sntech.de wrote:
> > The PMU on T-Head C9xx cores is quite similar to the SSCOFPMF extension
> > but not completely identical, so this series
>
> The rest of that sentance got dropped, so I put in
>
> The PMU on T-Head C9xx cores is quite similar to the SSCOFPMF extension
> but not completely identical, so this series adds a T-Head PMU errata
> that handlen the differences.
>
> but LMK if you had a better version, it's still early so I don't mind
> swapping it around.
sounds just fine and sorry for not finishing that sentence on my own.
> b4 also got kind of confused here so I had to merge suff manually.
do you still know what b4 complained about?
My patch workflow is pretty basic (git format-patch + separate
git send-email) so I guess it might be interesting what it was
stumbling on.
Thanks
Heiko
> > changes in v6:
> > - follow Anup's suggestion and hook into the (pending) cpuinfo patch [2]
> > instead of modifying the core sbi_get_* functions
> >
> > changes in v5:
> > - add received Reviews
> > - fix sbi caching wrt. negative values (Drew)
> > - add comment about specific c9xx arch- and imp-ids (Conor)
> >
> > changes in v4:
> > - add new patch to cache sbi mvendor, march and mimp-ids (Atish)
> > - errata dependencies in one line (Conor)
> > - make driver detection conditional on CONFIG_ERRATA_THEAD_PMU too (Atish)
> >
> > changes in v3:
> > - improve commit message (Atish, Conor)
> > - IS_ENABLED and BIT() in errata probe (Conor)
> >
> > The change depends on my cpufeature/t-head errata probe cleanup series [1].
> >
> >
> > changes in v2:
> > - use alternatives for the CSR access
> > - make the irq num selection a bit nicer
> >
> > There is of course a matching opensbi-part whose most recent implementation
> > can be found on [0].
> >
> >
> > [0] https://patchwork.ozlabs.org/project/opensbi/cover/20221004164227.1381825-1-heiko@sntech.de
> > [1] https://lore.kernel.org/all/20220905111027.2463297-1-heiko@sntech.de/
> > [2] https://lore.kernel.org/r/20220727043829.151794-1-apatel@ventanamicro.com
> >
> > Heiko Stuebner (2):
> > RISC-V: Cache SBI vendor values
> > drivers/perf: riscv_pmu_sbi: add support for PMU variant on T-Head
> > C9xx cores
> >
> > arch/riscv/Kconfig.erratas | 13 +++++++++++
> > arch/riscv/errata/thead/errata.c | 19 ++++++++++++++++
> > arch/riscv/include/asm/errata_list.h | 16 ++++++++++++-
> > arch/riscv/include/asm/sbi.h | 5 ++++
> > arch/riscv/kernel/cpu.c | 30 +++++++++++++++++++++---
> > drivers/perf/riscv_pmu_sbi.c | 34 ++++++++++++++++++++--------
> > 6 files changed, 103 insertions(+), 14 deletions(-)
>
next prev parent reply other threads:[~2022-10-27 19:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 23:18 [PATCH v6 0/2] riscv_pmu_sbi: add support for PMU variant on T-Head C9xx cores Heiko Stuebner
2022-10-11 23:18 ` Heiko Stuebner
2022-10-11 23:18 ` [PATCH v6 1/2] RISC-V: Cache SBI vendor values Heiko Stuebner
2022-10-11 23:18 ` Heiko Stuebner
2022-10-11 23:18 ` [PATCH v6 2/2] drivers/perf: riscv_pmu_sbi: add support for PMU variant on T-Head C9xx cores Heiko Stuebner
2022-10-11 23:18 ` Heiko Stuebner
2022-10-27 5:02 ` [PATCH v6 0/2] " Palmer Dabbelt
2022-10-27 5:02 ` Palmer Dabbelt
2022-10-27 19:53 ` Heiko Stübner [this message]
2022-10-27 19:53 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3621249.aeNJFYEL58@diego \
--to=heiko@sntech.de \
--cc=Conor.Dooley@microchip.com \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=samuel@sholland.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.