All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: Huibin Hong <huibin.hong@rock-chips.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	felipe.balbi@linux.intel.com, johnyoun@synopsys.com,
	catalin.marinas@arm.com, will.deacon@arm.com,
	linux-kernel@vger.kernel.org, jh80.chung@samsung.com,
	linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org, andy.yan@rock-chips.com,
	jic23@kernel.org, wxt@rock-chips.com
Subject: Re: [PATCH] arm64: dts: rockchip: add dmac nodes for rk3368 SoCs
Date: Fri, 17 Mar 2017 12:04:19 +0100	[thread overview]
Message-ID: <36338936.qaTCZ9qzt4@phil> (raw)
In-Reply-To: <1488534549-26175-1-git-send-email-huibin.hong@rock-chips.com>

Am Freitag, 3. März 2017, 17:49:09 CET schrieb Huibin Hong:
> Addd dmac bus and dmac peri dts nodes for peripherals,
> such as I2S, SPI, UART and so on.
> 
> Signed-off-by: Huibin Hong <huibin.hong@rock-chips.com>

applied for 4.12, with the changes described below

> ---
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi | 31
> +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a635adc..c9be1b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -204,6 +204,37 @@
>  				     <&cpu_b2>, <&cpu_b3>;
>  	};
> 
> +	amba {

moved "amba" above "arm-pmu", please mind the alphabetical ordering in the 
future.

> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		dmac_peri: dma-controller@ff250000 {
> +			compatible = "arm,pl330", "arm,primecell";
> +			reg = <0x0 0xff250000 0x0 0x4000>;
> +			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			clocks = <&cru ACLK_DMAC_PERI>;
> +			clock-names = "apb_pclk";
> +			arm,pl330-broken-no-flushp;
> +			peripherals-req-type-burst;

dropped peripherals-req-type-burst, as it is not part of mainline (yet?).
Please send a patch readding that if it gets submitted and accepted at some 
point.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: add dmac nodes for rk3368 SoCs
Date: Fri, 17 Mar 2017 12:04:19 +0100	[thread overview]
Message-ID: <36338936.qaTCZ9qzt4@phil> (raw)
In-Reply-To: <1488534549-26175-1-git-send-email-huibin.hong@rock-chips.com>

Am Freitag, 3. M?rz 2017, 17:49:09 CET schrieb Huibin Hong:
> Addd dmac bus and dmac peri dts nodes for peripherals,
> such as I2S, SPI, UART and so on.
> 
> Signed-off-by: Huibin Hong <huibin.hong@rock-chips.com>

applied for 4.12, with the changes described below

> ---
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi | 31
> +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a635adc..c9be1b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -204,6 +204,37 @@
>  				     <&cpu_b2>, <&cpu_b3>;
>  	};
> 
> +	amba {

moved "amba" above "arm-pmu", please mind the alphabetical ordering in the 
future.

> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		dmac_peri: dma-controller at ff250000 {
> +			compatible = "arm,pl330", "arm,primecell";
> +			reg = <0x0 0xff250000 0x0 0x4000>;
> +			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			clocks = <&cru ACLK_DMAC_PERI>;
> +			clock-names = "apb_pclk";
> +			arm,pl330-broken-no-flushp;
> +			peripherals-req-type-burst;

dropped peripherals-req-type-burst, as it is not part of mainline (yet?).
Please send a patch readding that if it gets submitted and accepted at some 
point.


Heiko

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Huibin Hong <huibin.hong@rock-chips.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
	catalin.marinas@arm.com, will.deacon@arm.com, wxt@rock-chips.com,
	andy.yan@rock-chips.com, felipe.balbi@linux.intel.com,
	jic23@kernel.org, jh80.chung@samsung.com, johnyoun@synopsys.com,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: add dmac nodes for rk3368 SoCs
Date: Fri, 17 Mar 2017 12:04:19 +0100	[thread overview]
Message-ID: <36338936.qaTCZ9qzt4@phil> (raw)
In-Reply-To: <1488534549-26175-1-git-send-email-huibin.hong@rock-chips.com>

Am Freitag, 3. März 2017, 17:49:09 CET schrieb Huibin Hong:
> Addd dmac bus and dmac peri dts nodes for peripherals,
> such as I2S, SPI, UART and so on.
> 
> Signed-off-by: Huibin Hong <huibin.hong@rock-chips.com>

applied for 4.12, with the changes described below

> ---
>  arch/arm64/boot/dts/rockchip/rk3368.dtsi | 31
> +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3368.dtsi index a635adc..c9be1b2 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3368.dtsi
> @@ -204,6 +204,37 @@
>  				     <&cpu_b2>, <&cpu_b3>;
>  	};
> 
> +	amba {

moved "amba" above "arm-pmu", please mind the alphabetical ordering in the 
future.

> +		compatible = "simple-bus";
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		dmac_peri: dma-controller@ff250000 {
> +			compatible = "arm,pl330", "arm,primecell";
> +			reg = <0x0 0xff250000 0x0 0x4000>;
> +			interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>,
> +				     <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> +			#dma-cells = <1>;
> +			clocks = <&cru ACLK_DMAC_PERI>;
> +			clock-names = "apb_pclk";
> +			arm,pl330-broken-no-flushp;
> +			peripherals-req-type-burst;

dropped peripherals-req-type-burst, as it is not part of mainline (yet?).
Please send a patch readding that if it gets submitted and accepted at some 
point.


Heiko

  reply	other threads:[~2017-03-17 11:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-03  9:49 [PATCH] arm64: dts: rockchip: add dmac nodes for rk3368 SoCs Huibin Hong
2017-03-03  9:49 ` Huibin Hong
2017-03-03  9:49 ` Huibin Hong
2017-03-17 11:04 ` Heiko Stuebner [this message]
2017-03-17 11:04   ` Heiko Stuebner
2017-03-17 11:04   ` Heiko Stuebner
  -- strict thread matches above, loose matches on Subject: below --
2017-03-22 12:03 Huibin Hong
2017-03-22 12:03 ` Huibin Hong
2017-03-22 12:03 ` Huibin Hong
2017-03-22 12:49 ` Heiko Stübner
2017-03-22 12:49   ` Heiko Stübner
2017-03-22 12:49   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36338936.qaTCZ9qzt4@phil \
    --to=heiko@sntech.de \
    --cc=andy.yan@rock-chips.com \
    --cc=catalin.marinas@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=felipe.balbi@linux.intel.com \
    --cc=huibin.hong@rock-chips.com \
    --cc=jh80.chung@samsung.com \
    --cc=jic23@kernel.org \
    --cc=johnyoun@synopsys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=will.deacon@arm.com \
    --cc=wxt@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.