All of lore.kernel.org
 help / color / mirror / Atom feed
From: Valdis.Kletnieks@vt.edu
To: Nicholas Krause <xerofoify@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, linux@arm.linux.org.uk,
	tomasz.figa@gmail.com, linux-kernel@vger.kernel.org,
	kgene.kim@samsung.com, ben-linux@fluff.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks
Date: Mon, 14 Jul 2014 17:43:50 -0400	[thread overview]
Message-ID: <36350.1405374230@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 14 Jul 2014 14:14:24 -0400." <1405361664-5210-1-git-send-email-xerofoify@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 839 bytes --]

On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said:
> This patch addresses the fix me message in this file that states to
> remove all definitions not related to reg-clocks in this header
> file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)

> -#endif /* _PLAT_REGS_CLOCK_H */
> +/#endif /* _PLAT_REGS_CLOCK_H */

You're kidding us, right? Given that this was obviously *not* compile
tested at all, why should we believe that in fact all those #defines
are in fact no longer used?

Hint: There's a very high chance that somebody stuck that FIXME in there rather
than just cleaning it up themselves precisely *because* it was still in use in
an inconvenient to fix place in the tree..


[-- Attachment #1.2: Type: application/pgp-signature, Size: 848 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Valdis.Kletnieks@vt.edu (Valdis.Kletnieks at vt.edu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks
Date: Mon, 14 Jul 2014 17:43:50 -0400	[thread overview]
Message-ID: <36350.1405374230@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 14 Jul 2014 14:14:24 -0400." <1405361664-5210-1-git-send-email-xerofoify@gmail.com>

On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said:
> This patch addresses the fix me message in this file that states to
> remove all definitions not related to reg-clocks in this header
> file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)

> -#endif /* _PLAT_REGS_CLOCK_H */
> +/#endif /* _PLAT_REGS_CLOCK_H */

You're kidding us, right? Given that this was obviously *not* compile
tested at all, why should we believe that in fact all those #defines
are in fact no longer used?

Hint: There's a very high chance that somebody stuck that FIXME in there rather
than just cleaning it up themselves precisely *because* it was still in use in
an inconvenient to fix place in the tree..

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140714/99d5cb05/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Valdis.Kletnieks@vt.edu
To: Nicholas Krause <xerofoify@gmail.com>
Cc: ben-linux@fluff.org, kgene.kim@samsung.com,
	linux@arm.linux.org.uk, tomasz.figa@gmail.com,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks
Date: Mon, 14 Jul 2014 17:43:50 -0400	[thread overview]
Message-ID: <36350.1405374230@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Mon, 14 Jul 2014 14:14:24 -0400." <1405361664-5210-1-git-send-email-xerofoify@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

On Mon, 14 Jul 2014 14:14:24 -0400, Nicholas Krause said:
> This patch addresses the fix me message in this file that states to
> remove all definitions not related to reg-clocks in this header
> file.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/include/mach/regs-clock.h | 22 +---------------------
>  1 file changed, 1 insertion(+), 21 deletions(-)

> -#endif /* _PLAT_REGS_CLOCK_H */
> +/#endif /* _PLAT_REGS_CLOCK_H */

You're kidding us, right? Given that this was obviously *not* compile
tested at all, why should we believe that in fact all those #defines
are in fact no longer used?

Hint: There's a very high chance that somebody stuck that FIXME in there rather
than just cleaning it up themselves precisely *because* it was still in use in
an inconvenient to fix place in the tree..


[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

  parent reply	other threads:[~2014-07-14 21:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 18:14 [PATCH] mach-s3c64xx: Remove all defintions not related to regs-clocks Nicholas Krause
2014-07-14 18:14 ` Nicholas Krause
2014-07-14 18:23 ` Randy Dunlap
2014-07-14 18:23   ` Randy Dunlap
2014-07-14 18:40   ` Paul Bolle
2014-07-14 18:40     ` Paul Bolle
2014-07-14 18:45     ` Randy Dunlap
2014-07-14 18:45       ` Randy Dunlap
2014-07-14 18:56       ` Nick Krause
2014-07-14 18:56         ` Nick Krause
2014-07-14 18:34 ` Randy Dunlap
2014-07-14 18:34   ` Randy Dunlap
2014-07-14 18:51 ` Arnd Bergmann
2014-07-14 18:51   ` Arnd Bergmann
2014-07-14 21:43 ` Valdis.Kletnieks [this message]
2014-07-14 21:43   ` Valdis.Kletnieks
2014-07-14 21:43   ` Valdis.Kletnieks at vt.edu
2014-07-17  1:13   ` Nick Krause
2014-07-17  1:13     ` Nick Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36350.1405374230@turing-police.cc.vt.edu \
    --to=valdis.kletnieks@vt.edu \
    --cc=ben-linux@fluff.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=tomasz.figa@gmail.com \
    --cc=xerofoify@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.