Re: [Qemu-devel] [PATCH] e1000: cleanup process_tx_desc

[Andrew Jones <drjones@redhat.com>]

----- Original Message -----
> On 4 June 2013 08:34, Andrew Jones <drjones@redhat.com> wrote:
> > I could send a v2 that fixes the 1 error and 2 warnings found in the
> > context
> > of this patch, but why? It's out of the scope of the patch (although I did
> > use "cleanup" in the summary...), and it would hardly make a dent in this
> > file's problems.
> 
> The idea is that we gradually bring the code closer into
> line with QEMU's standards by (a) not allowing in new
> code which doesn't follow the rules and (b) fixing old
> code where it is in areas which a patch touches. This
> gradually ratchets up the quality overall without being
> huge "touch every line in a file" patches (which reduce
> the functionality of git blame, among other things).
> 
> It really isn't a very onerous requirement in my opinion.
>

OK, I surrender. v2 sent. Now we just need to find some bugs
in the other 180 style-violating lines in order to finish
cleaning up this file :-)

drew
 
> thanks
> -- PMM
>