From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Peschke <mp3@de.ibm.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 7/8] readahead: call scheme: fix thrashed unaligned read
Date: Sat, 27 Jan 2007 16:02:26 +0800 [thread overview]
Message-ID: <369886264.76457@ustc.edu.cn> (raw)
Message-ID: <20070127082530.137014081@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070127080219.161473179@mail.ustc.edu.cn
[-- Attachment #1: readahead-call-scheme-fix-thrashed-unaligned-read.patch --]
[-- Type: text/plain, Size: 780 bytes --]
When doing unaligned/subpages sequential reads, and thrashing happened,
it is possible that (offset == prev_page),
besides the normal (offset == prev_page + 1).
We do not have such problem for the state based method.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
mm/readahead.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.20-rc4-mm1.orig/mm/readahead.c
+++ linux-2.6.20-rc4-mm1/mm/readahead.c
@@ -1618,7 +1618,7 @@ page_cache_readahead_adaptive(struct add
/*
* Recover from possible thrashing.
*/
- if (!page && offset == ra->prev_page + 1 && ra_has_index(ra, offset))
+ if (!page && offset - ra->prev_page <= 1 && ra_has_index(ra, offset))
return thrashing_recovery_readahead(mapping, filp, ra,
offset, ra_max);
--
next prev parent reply other threads:[~2007-01-27 8:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-27 8:02 [PATCH 0/8] readahead updates Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 1/8] readahead: min/max sizes: increase VM_MIN_READAHEAD to 32KB Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 2/8] readahead: state based method routines: explicitly embed class_new/class_old inside flags Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 3/8] readahead: state based method: prevent tiny size Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 4/8] readahead: state based method: move readahead_ratio out of compute_thrashing_threshold() Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 5/8] readahead: initial method: user recommended size: rename to read_ahead_initial_kb Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` [PATCH 6/8] readahead: thrashing recovery method fix Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu [this message]
2007-01-27 8:02 ` [PATCH 7/8] readahead: call scheme: fix thrashed unaligned read Fengguang Wu
2007-01-27 8:02 ` [PATCH 8/8] readahead: laptop mode fix Fengguang Wu
2007-01-27 8:02 ` Fengguang Wu
2007-01-31 13:37 ` [PATCH 0/8] readahead updates martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=369886264.76457@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mp3@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.