From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH 4/5] tests/functional: remove all class level fields
Date: Thu, 6 Feb 2025 10:27:34 +0100 [thread overview]
Message-ID: <370f5393-e19e-4dfd-a627-05a60ba80bbb@redhat.com> (raw)
In-Reply-To: <20250205155946.2811296-5-berrange@redhat.com>
On 05/02/2025 16.59, Daniel P. Berrangé wrote:
> A number of fields are set at the class level on QemuBaseTest, even
> though the exact same named field is then set at the object level
> later in most cases.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/functional/qemu_test/testcase.py | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 574c1942f2..531d6393ad 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -33,12 +33,6 @@
>
> class QemuBaseTest(unittest.TestCase):
>
> - arch = None
> -
> - workdir = None
> - log = None
> - logdir = None
That's what you get when a Python ignorant like me tries to write object
oriented Python code ;-) Thanks for cleaning up my mess!
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2025-02-06 9:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:59 [PATCH 0/5] tests/functional: a few misc cleanups and fixes Daniel P. Berrangé
2025-02-05 15:59 ` [PATCH 1/5] tests/functional: skip test if QEMU_TEST_QEMU_BINARY is not set Daniel P. Berrangé
2025-02-06 9:01 ` Thomas Huth
2025-02-28 9:50 ` Daniel P. Berrangé
2025-02-05 15:59 ` [PATCH 2/5] tests/functional: remove unused 'bin_prefix' variable Daniel P. Berrangé
2025-02-06 9:23 ` Thomas Huth
2025-02-05 15:59 ` [PATCH 3/5] tests/functional: set 'qemu_bin' as an object level field Daniel P. Berrangé
2025-02-06 9:24 ` Thomas Huth
2025-02-05 15:59 ` [PATCH 4/5] tests/functional: remove all class level fields Daniel P. Berrangé
2025-02-06 9:27 ` Thomas Huth [this message]
2025-02-05 15:59 ` [PATCH 5/5] tests/functional: skip mem addr test on 32-bit hosts Daniel P. Berrangé
2025-02-05 16:40 ` Philippe Mathieu-Daudé
2025-02-05 16:53 ` Daniel P. Berrangé
2025-02-05 18:08 ` Philippe Mathieu-Daudé
2025-02-05 18:25 ` Richard Henderson
2025-02-06 9:29 ` Thomas Huth
2025-02-05 18:24 ` Richard Henderson
2025-02-05 18:47 ` Daniel P. Berrangé
2025-02-05 18:50 ` Richard Henderson
2025-02-06 9:35 ` Daniel P. Berrangé
2025-02-06 9:46 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370f5393-e19e-4dfd-a627-05a60ba80bbb@redhat.com \
--to=thuth@redhat.com \
--cc=berrange@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.