From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 5/5] tests/functional: skip mem addr test on 32-bit hosts
Date: Thu, 6 Feb 2025 09:35:53 +0000 [thread overview]
Message-ID: <Z6SCeWUMuhUa5zGG@redhat.com> (raw)
In-Reply-To: <18acac8d-271a-4641-893e-93096f31a2ac@linaro.org>
On Wed, Feb 05, 2025 at 10:24:08AM -0800, Richard Henderson wrote:
> On 2/5/25 07:59, Daniel P. Berrangé wrote:
> > +
> > +'''
> > +Decorator to skip execution of a test on 32-bit targets
> > +Example:
> > +
> > + @skipIf32BitTarget()
> > +'''
> > +def skipIf32BitTarget():
> > + enoughBits = sys.maxsize > 2**32
>
> This will work for true 32-bit hosts, and possibly for containers running
> emulation, but it won't work for cross-compilation (x86_64 to i686 or
> aarch64 to arm).
>
> Perhaps "file qemu-system-foo" | grep "ELF 32-bit" ?
> I don't know that we've actually selected the executable at this point though...
The QEMU_TEST_QEMU_BINARY env variable exists at all times, though
grepping for ELF format feels a bit icky.
We also know the location of the build directory, so was wondering if
anything there tells us whether the host target is 64-bit, but it
appears not be the case.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-02-06 9:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 15:59 [PATCH 0/5] tests/functional: a few misc cleanups and fixes Daniel P. Berrangé
2025-02-05 15:59 ` [PATCH 1/5] tests/functional: skip test if QEMU_TEST_QEMU_BINARY is not set Daniel P. Berrangé
2025-02-06 9:01 ` Thomas Huth
2025-02-28 9:50 ` Daniel P. Berrangé
2025-02-05 15:59 ` [PATCH 2/5] tests/functional: remove unused 'bin_prefix' variable Daniel P. Berrangé
2025-02-06 9:23 ` Thomas Huth
2025-02-05 15:59 ` [PATCH 3/5] tests/functional: set 'qemu_bin' as an object level field Daniel P. Berrangé
2025-02-06 9:24 ` Thomas Huth
2025-02-05 15:59 ` [PATCH 4/5] tests/functional: remove all class level fields Daniel P. Berrangé
2025-02-06 9:27 ` Thomas Huth
2025-02-05 15:59 ` [PATCH 5/5] tests/functional: skip mem addr test on 32-bit hosts Daniel P. Berrangé
2025-02-05 16:40 ` Philippe Mathieu-Daudé
2025-02-05 16:53 ` Daniel P. Berrangé
2025-02-05 18:08 ` Philippe Mathieu-Daudé
2025-02-05 18:25 ` Richard Henderson
2025-02-06 9:29 ` Thomas Huth
2025-02-05 18:24 ` Richard Henderson
2025-02-05 18:47 ` Daniel P. Berrangé
2025-02-05 18:50 ` Richard Henderson
2025-02-06 9:35 ` Daniel P. Berrangé [this message]
2025-02-06 9:46 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6SCeWUMuhUa5zGG@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.