From: Avinesh Kumar <akumar@suse.de>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] github: Improve pull request template
Date: Tue, 10 Jan 2023 16:08:30 +0530 [thread overview]
Message-ID: <37195382.rXvGVjUE4X@localhost> (raw)
In-Reply-To: <Y709W2qjGVFqvnvU@pevik>
On Tuesday, January 10, 2023 3:56:35 PM IST Petr Vorel wrote:
> Hi Richie, Avinesh,
>
> thanks for your review.
> > Hello,
>
> > Please merge.
> Before merge, are you ok with one more change?
>
> Kind regards,
> Petr
>
> +++ .github/pull_request_template.md
> @@ -9,6 +9,11 @@ We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list
> * Commits should be signed: Signed-off-by: Your Name <me@example.org>, see
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
> +* Commit message should be meaningful, following common style
> +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#split-changes
> +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> +https://chris.beams.io/posts/git-commit/
+1 for the change, as long as the last url can be considered reliable. It already redirects to another website for me.
> +
> * New code should follow Linux kernel coding style, see
> https://www.kernel.org/doc/html/latest/process/coding-style.html.
> You can run 'make check' or 'make check-foo' in the folder with modified code to check style and common errors.
>
Regards,
Avinesh
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-01-10 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 10:07 [LTP] [PATCH 1/1] github: Improve pull request template Petr Vorel
2023-01-09 11:05 ` Avinesh Kumar
2023-01-10 9:56 ` Richard Palethorpe
2023-01-10 10:26 ` Petr Vorel
2023-01-10 10:38 ` Avinesh Kumar [this message]
2023-01-10 10:38 ` Richard Palethorpe
2023-01-10 16:04 ` Petr Vorel
-- strict thread matches above, loose matches on Subject: below --
2023-01-10 8:47 Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37195382.rXvGVjUE4X@localhost \
--to=akumar@suse.de \
--cc=ltp@lists.linux.it \
--cc=pvorel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.