All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Richard Palethorpe <rpalethorpe@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] github: Improve pull request template
Date: Tue, 10 Jan 2023 17:04:15 +0100	[thread overview]
Message-ID: <Y72MfwHOkeag4NIw@pevik> (raw)
In-Reply-To: <87v8lehdpe.fsf@suse.de>

Hi Richie, Avinesh,

> > thanks for your review.
> >> Hello,

> >> Please merge.
> > Before merge, are you ok with one more change?

> Yes, although


> > Kind regards,
> > Petr

> > +++ .github/pull_request_template.md
> > @@ -9,6 +9,11 @@ We also have a patchwork instance: https://patchwork.ozlabs.org/project/ltp/list
> >  * Commits should be signed: Signed-off-by: Your Name <me@example.org>, see
> >  https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin

> > +* Commit message should be meaningful, following common style
> > +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#split-changes
> > +https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
> > +https://chris.beams.io/posts/git-commit/

> This redirects to https://cbea.ms/git-commit/.

Thank you both for additional review, I merged with the redirected URL.
If not stable in the future, we can always deleted it.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2023-01-10 16:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 10:07 [LTP] [PATCH 1/1] github: Improve pull request template Petr Vorel
2023-01-09 11:05 ` Avinesh Kumar
2023-01-10  9:56   ` Richard Palethorpe
2023-01-10 10:26     ` Petr Vorel
2023-01-10 10:38       ` Avinesh Kumar
2023-01-10 10:38       ` Richard Palethorpe
2023-01-10 16:04         ` Petr Vorel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-10  8:47 Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y72MfwHOkeag4NIw@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.