From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 4/4] pinctrl: sh-pfc: Use u32 to store register addresses
Date: Thu, 12 Mar 2015 03:02:51 +0200 [thread overview]
Message-ID: <3725535.iu1CkyQgCh@avalon> (raw)
In-Reply-To: <1425985583-26279-5-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Tuesday 10 March 2015 12:06:23 Geert Uytterhoeven wrote:
> Currently all PFC registers lie in low 32-bit address space. Hence use
> u32 instead of unsigned long to store PFC register addresses in pinctrl
> tables. All calculations of virtual addresses use a phys_addr_t
> intermediate, so we know where to add an offset if the 32-bit assumption
> ever becomes false.
>
> While this doesn't impact 32-bit builds, it would save ca. 7 KiB on a
> 64-bit shmobile_defconfig kernel.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 4/4] pinctrl: sh-pfc: Use u32 to store register addresses
Date: Thu, 12 Mar 2015 01:02:51 +0000 [thread overview]
Message-ID: <3725535.iu1CkyQgCh@avalon> (raw)
In-Reply-To: <1425985583-26279-5-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Tuesday 10 March 2015 12:06:23 Geert Uytterhoeven wrote:
> Currently all PFC registers lie in low 32-bit address space. Hence use
> u32 instead of unsigned long to store PFC register addresses in pinctrl
> tables. All calculations of virtual addresses use a phys_addr_t
> intermediate, so we know where to add an offset if the 32-bit assumption
> ever becomes false.
>
> While this doesn't impact 32-bit builds, it would save ca. 7 KiB on a
> 64-bit shmobile_defconfig kernel.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-03-12 1:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 11:06 [PATCH v2 0/4] pinctrl: sh-pfc: cleanups Geert Uytterhoeven
2015-03-10 11:06 ` Geert Uytterhoeven
2015-03-10 11:06 ` [PATCH v2 1/4] pinctrl: sh-pfc: Store register/field widths in u8 instead of unsigned long Geert Uytterhoeven
2015-03-10 11:06 ` Geert Uytterhoeven
2015-03-18 1:10 ` Linus Walleij
2015-03-18 1:10 ` Linus Walleij
2015-03-18 1:11 ` Linus Walleij
2015-03-18 1:11 ` Linus Walleij
2015-03-10 11:06 ` [PATCH v2 2/4] pinctrl: sh-pfc: Use unsigned int for register/field widths and offsets Geert Uytterhoeven
2015-03-10 11:06 ` Geert Uytterhoeven
2015-03-12 1:00 ` Laurent Pinchart
2015-03-12 1:00 ` Laurent Pinchart
2015-03-12 7:49 ` Geert Uytterhoeven
2015-03-12 7:49 ` Geert Uytterhoeven
2015-03-10 11:06 ` [PATCH v2 3/4] pinctrl: sh-pfc: Use reg_width instead of reg as sentinel Geert Uytterhoeven
2015-03-10 11:06 ` Geert Uytterhoeven
2015-03-12 1:19 ` Laurent Pinchart
2015-03-12 1:19 ` Laurent Pinchart
2015-03-10 11:06 ` [PATCH v2 4/4] pinctrl: sh-pfc: Use u32 to store register addresses Geert Uytterhoeven
2015-03-10 11:06 ` Geert Uytterhoeven
2015-03-12 1:02 ` Laurent Pinchart [this message]
2015-03-12 1:02 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725535.iu1CkyQgCh@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert+renesas@glider.be \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.