From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq
Date: Fri, 23 Oct 2015 16:14:09 +0300 [thread overview]
Message-ID: <3725918.YSMPQz70Zm@avalon> (raw)
In-Reply-To: <20151023121439.GK13380@katana>
Hi Wolfram,
On Friday 23 October 2015 14:14:39 Wolfram Sang wrote:
> > > :/ Let me know if I can send you debug output.
> >
> > What's the exact issue ?
>
> Best report ever: I simply don't get a picture :) No warnings, no
> messages. I think we want to make sure my HDMI->DVI converter is proper,
> though.
Does it work with other HDMI sources ?
> > > > .config attached.
> > >
> > > That one also probes for me... I only disabled DHCP and added my
> > > initramfs. I patched the fbdev build error out and changed Lager dts to
> > > use i2c-rcar (instead of i2c-sh_mobile).
>
> I made the ADV7180 and AK4642 built-in and this kernel still probes
> rcar-du on my Lager and Magnus' Koelsch...
It's CONFIG_DRM_I2C_ADV7511 that you need for HDMI output.
I have ADV7180 and AK4642 built as modules in my kernel.
> > <idle>-0 [000] d.h1 1.498063: rcar_i2c_irq: msr 09090909
> > <idle>-0 [000] d.h1 1.498075: rcar_i2c_irq: msr 08080808
> > <idle>-0 [000] d.h1 1.498266: rcar_i2c_irq: msr 07070707
> > <idle>-0 [000] d.h1 1.498348: rcar_i2c_irq: msr 06060606
> > <idle>-0 [000] d.h1 1.498465: rcar_i2c_irq: msr 49494949
>
> So, here is the NACK bit set. Which does not happen on my Lager and
> Magnus' Koelsch. I am starting to wonder if you have a board with HW
> issues?
It works fine when reverting this patch :-/
> Could it be another I2C device interfering?
I wouldn't rule anything out, but I don't see why reverting this patch would
help then.
> Do you happen to know if you have an earlier revision of Koelsch?
RTPORC7791SEB00010S
KOELSCH SN.057
I'm not sure if that tells anything about the board revision.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Simon Horman <horms@verge.net.au>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH 5/9] i2c: rcar: init new messages in irq
Date: Fri, 23 Oct 2015 13:14:09 +0000 [thread overview]
Message-ID: <3725918.YSMPQz70Zm@avalon> (raw)
In-Reply-To: <20151023121439.GK13380@katana>
Hi Wolfram,
On Friday 23 October 2015 14:14:39 Wolfram Sang wrote:
> > > :/ Let me know if I can send you debug output.
> >
> > What's the exact issue ?
>
> Best report ever: I simply don't get a picture :) No warnings, no
> messages. I think we want to make sure my HDMI->DVI converter is proper,
> though.
Does it work with other HDMI sources ?
> > > > .config attached.
> > >
> > > That one also probes for me... I only disabled DHCP and added my
> > > initramfs. I patched the fbdev build error out and changed Lager dts to
> > > use i2c-rcar (instead of i2c-sh_mobile).
>
> I made the ADV7180 and AK4642 built-in and this kernel still probes
> rcar-du on my Lager and Magnus' Koelsch...
It's CONFIG_DRM_I2C_ADV7511 that you need for HDMI output.
I have ADV7180 and AK4642 built as modules in my kernel.
> > <idle>-0 [000] d.h1 1.498063: rcar_i2c_irq: msr 09090909
> > <idle>-0 [000] d.h1 1.498075: rcar_i2c_irq: msr 08080808
> > <idle>-0 [000] d.h1 1.498266: rcar_i2c_irq: msr 07070707
> > <idle>-0 [000] d.h1 1.498348: rcar_i2c_irq: msr 06060606
> > <idle>-0 [000] d.h1 1.498465: rcar_i2c_irq: msr 49494949
>
> So, here is the NACK bit set. Which does not happen on my Lager and
> Magnus' Koelsch. I am starting to wonder if you have a board with HW
> issues?
It works fine when reverting this patch :-/
> Could it be another I2C device interfering?
I wouldn't rule anything out, but I don't see why reverting this patch would
help then.
> Do you happen to know if you have an earlier revision of Koelsch?
RTPORC7791SEB00010S
KOELSCH SN.057
I'm not sure if that tells anything about the board revision.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2015-10-23 13:14 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 20:20 [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 1/9] i2c: rcar: rework hw init Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 2/9] i2c: rcar: remove unused IOERROR state Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 6/9] i2c: rcar: don't issue stop when HW does it automatically Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
[not found] ` <1441311613-2681-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-09-03 20:20 ` [PATCH 3/9] i2c: rcar: remove spinlock Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 4/9] i2c: rcar: refactor setup of a msg Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 5/9] i2c: rcar: init new messages in irq Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-10-21 23:10 ` Laurent Pinchart
2015-10-21 23:10 ` Laurent Pinchart
2015-10-22 11:05 ` Wolfram Sang
2015-10-22 11:05 ` Wolfram Sang
2015-10-22 11:12 ` Laurent Pinchart
2015-10-22 11:12 ` Laurent Pinchart
2015-10-23 8:06 ` Wolfram Sang
2015-10-23 8:06 ` Wolfram Sang
2015-10-23 8:57 ` Laurent Pinchart
2015-10-23 9:45 ` Wolfram Sang
2015-10-23 9:45 ` Wolfram Sang
2015-10-23 10:28 ` Laurent Pinchart
2015-10-23 10:28 ` Laurent Pinchart
2015-10-23 12:14 ` Wolfram Sang
2015-10-23 12:14 ` Wolfram Sang
2015-10-23 13:14 ` Laurent Pinchart [this message]
2015-10-23 13:14 ` Laurent Pinchart
2015-10-25 15:53 ` Wolfram Sang
2015-10-25 15:53 ` Wolfram Sang
2015-10-29 19:23 ` Wolfram Sang
2015-10-29 19:23 ` Wolfram Sang
2015-10-23 10:04 ` Geert Uytterhoeven
2015-10-23 10:04 ` Geert Uytterhoeven
2015-10-23 10:07 ` Wolfram Sang
2015-10-23 10:07 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 7/9] i2c: rcar: check master irqs before slave irqs Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 8/9] i2c: rcar: revoke START request early Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:20 ` [PATCH 9/9] i2c: rcar: clean up after refactoring Wolfram Sang
2015-09-03 20:20 ` Wolfram Sang
2015-09-03 20:35 ` [PATCH 0/9] i2c: rcar: tackle race conditions in the driver Laurent Pinchart
2015-09-03 20:35 ` Laurent Pinchart
2015-09-03 20:40 ` Wolfram Sang
2015-09-03 20:40 ` Wolfram Sang
2015-09-03 20:47 ` Laurent Pinchart
2015-09-03 20:47 ` Laurent Pinchart
2015-09-03 20:55 ` Wolfram Sang
2015-09-03 20:55 ` Wolfram Sang
2015-09-04 4:33 ` Magnus Damm
2015-09-04 4:33 ` Magnus Damm
2015-09-05 7:31 ` Wolfram Sang
2015-09-05 7:31 ` Wolfram Sang
2015-09-07 16:04 ` Magnus Damm
2015-09-07 16:04 ` Magnus Damm
[not found] ` <CANqRtoRs=f=07B=HSLCVg5G4rnhxj6Heod+spYwxHiKFLZqFWg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-08 10:53 ` Wolfram Sang
2015-09-08 10:53 ` Wolfram Sang
2015-09-09 5:08 ` Magnus Damm
2015-09-09 5:08 ` Magnus Damm
2015-09-09 8:54 ` Wolfram Sang
2015-09-09 8:54 ` Wolfram Sang
2015-10-09 21:34 ` Wolfram Sang
2015-10-09 21:34 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3725918.YSMPQz70Zm@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=wsa@the-dreams.de \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.