From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Boris BREZILLON <boris.brezillon@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andrew Victor <linux@maxim.org.za>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Johan Hovold <jhovold@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v8 09/10] rtc: at91sam9: add DT bindings documentation
Date: Tue, 23 Sep 2014 14:56:37 +0200 [thread overview]
Message-ID: <3728270.N2tTcyeJmL@wuerfel> (raw)
In-Reply-To: <1411471444-2764-10-git-send-email-boris.brezillon@free-electrons.com>
On Tuesday 23 September 2014 13:24:03 Boris BREZILLON wrote:
> Add RTT bindings documentation.
Two minor comments here:
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtt alarm/event interrupt
> +- clocks: should contain one clock pointing to the slow clk
This should document what the clock is used for, not where it's
connected.
> +
> +rtt@fffffe00 {
> + compatible = "atmel,at91sam9260-rtt";
> + reg = <0xfffffd20 0x10>;
> + interrupts = <1 4 7>;
> + clocks = <&clk32k>;
> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
> +};
>
The register address fffffd20 does not match the name fffffe00
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 09/10] rtc: at91sam9: add DT bindings documentation
Date: Tue, 23 Sep 2014 14:56:37 +0200 [thread overview]
Message-ID: <3728270.N2tTcyeJmL@wuerfel> (raw)
In-Reply-To: <1411471444-2764-10-git-send-email-boris.brezillon@free-electrons.com>
On Tuesday 23 September 2014 13:24:03 Boris BREZILLON wrote:
> Add RTT bindings documentation.
Two minor comments here:
> +Atmel AT91SAM9260 Real Time Timer
> +
> +Required properties:
> +- compatible: should be: "atmel,at91sam9260-rtt"
> +- reg: should encode the memory region of the RTT controller
> +- interrupts: rtt alarm/event interrupt
> +- clocks: should contain one clock pointing to the slow clk
This should document what the clock is used for, not where it's
connected.
> +
> +rtt at fffffe00 {
> + compatible = "atmel,at91sam9260-rtt";
> + reg = <0xfffffd20 0x10>;
> + interrupts = <1 4 7>;
> + clocks = <&clk32k>;
> + atmel,rtt-rtc-time-reg = <&gpbr 0x0>;
> +};
>
The register address fffffd20 does not match the name fffffe00
Arnd
next prev parent reply other threads:[~2014-09-23 12:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 11:23 [PATCH v8 00/10] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` [PATCH v8 01/10] rtc: at91sam9: remove references to mach specific headers Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` [PATCH v8 02/10] rtc: at91sam9: use standard readl/writel functions instead of raw versions Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` [PATCH v8 03/10] rtc: at91sam9: replace devm_ioremap by devm_ioremap_resource Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` [PATCH v8 04/10] rtc: at91sam9: add DT support Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:23 ` [PATCH v8 05/10] rtc: at91sam9: make use of syscon/regmap to access GPBR registers Boris BREZILLON
2014-09-23 11:23 ` Boris BREZILLON
2014-09-23 11:24 ` [PATCH v8 06/10] rtc: at91sam9: rework the Kconfig description Boris BREZILLON
2014-09-23 11:24 ` Boris BREZILLON
2014-09-23 11:24 ` [PATCH v8 07/10] ARM: at91: add clk_lookup entry for RTT devices Boris BREZILLON
2014-09-23 11:24 ` Boris BREZILLON
2014-09-23 11:24 ` [PATCH v8 08/10] rtc: at91sam9: use clk API instead of relying on AT91_SLOW_CLOCK Boris BREZILLON
2014-09-23 11:24 ` Boris BREZILLON
2014-09-23 12:14 ` Johan Hovold
2014-09-23 12:14 ` Johan Hovold
2014-09-23 11:24 ` [PATCH v8 09/10] rtc: at91sam9: add DT bindings documentation Boris BREZILLON
2014-09-23 11:24 ` Boris BREZILLON
2014-09-23 12:56 ` Arnd Bergmann [this message]
2014-09-23 12:56 ` Arnd Bergmann
2014-09-23 11:24 ` [PATCH v8 10/10] mfd: syscon: add Atmel GPBR DT bindings documention Boris BREZILLON
2014-09-23 11:24 ` Boris BREZILLON
2014-09-23 12:57 ` [PATCH v8 00/10] rtc: at91sam9: add DT support Arnd Bergmann
2014-09-23 12:57 ` Arnd Bergmann
2014-09-23 12:57 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3728270.N2tTcyeJmL@wuerfel \
--to=arnd@arndb.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jhovold@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.