From: Tomasz Figa <tomasz.figa@gmail.com>
To: Andy Gross <agross@codeaurora.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Vinod Koul <vinod.koul@intel.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
David Brown <davidb@codeaurora.org>,
Bryan Huntsman <bryanh@codeaurora.org>
Subject: Re: [PATCH 1/2] dmaengine: add msm bam dma driver
Date: Wed, 13 Nov 2013 23:07:19 +0100 [thread overview]
Message-ID: <3732966.zLLfiChgvH@flatron> (raw)
In-Reply-To: <20131030203105.GA14525@agross>
Hi Andy,
On Wednesday 30 of October 2013 15:31:05 Andy Gross wrote:
> On Tue, Oct 29, 2013 at 10:56:03AM -0700, Stephen Boyd wrote:
> > On 10/25, Andy Gross wrote:
> > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > > index f238cfd..a71b415 100644
> > > --- a/drivers/dma/Kconfig
> > > +++ b/drivers/dma/Kconfig
> > > @@ -364,4 +364,13 @@ config DMATEST
> > > Simple DMA test client. Say N unless you're debugging a
> > > DMA Device driver.
> > >
> > > +
> > > +config MSM_BAM_DMA
> > > + tristate "MSM BAM DMA support"
> > > + depends on ARCH_MSM
> >
> > It would be nice if we didn't have to rely on ARCH_MSM here so we
> > get more build coverage.
>
> I can remove that. There is nothing that forces this depend option.
Instead of removing, please add "|| COMPILE_TEST". This is the right way
to allow drivers not supposed to be run on given platform to build on it.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] dmaengine: add msm bam dma driver
Date: Wed, 13 Nov 2013 23:07:19 +0100 [thread overview]
Message-ID: <3732966.zLLfiChgvH@flatron> (raw)
In-Reply-To: <20131030203105.GA14525@agross>
Hi Andy,
On Wednesday 30 of October 2013 15:31:05 Andy Gross wrote:
> On Tue, Oct 29, 2013 at 10:56:03AM -0700, Stephen Boyd wrote:
> > On 10/25, Andy Gross wrote:
> > > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > > index f238cfd..a71b415 100644
> > > --- a/drivers/dma/Kconfig
> > > +++ b/drivers/dma/Kconfig
> > > @@ -364,4 +364,13 @@ config DMATEST
> > > Simple DMA test client. Say N unless you're debugging a
> > > DMA Device driver.
> > >
> > > +
> > > +config MSM_BAM_DMA
> > > + tristate "MSM BAM DMA support"
> > > + depends on ARCH_MSM
> >
> > It would be nice if we didn't have to rely on ARCH_MSM here so we
> > get more build coverage.
>
> I can remove that. There is nothing that forces this depend option.
Instead of removing, please add "|| COMPILE_TEST". This is the right way
to allow drivers not supposed to be run on given platform to build on it.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-11-13 22:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 20:24 [PATCH 0/2] add MSM BAM dmaengine driver Andy Gross
2013-10-25 20:24 ` Andy Gross
2013-10-25 20:24 ` Andy Gross
2013-10-25 20:24 ` [PATCH 1/2] dmaengine: add msm bam dma driver Andy Gross
2013-10-25 20:24 ` Andy Gross
2013-10-29 17:56 ` Stephen Boyd
2013-10-29 17:56 ` Stephen Boyd
2013-10-30 20:31 ` Andy Gross
2013-10-30 20:31 ` Andy Gross
2013-10-30 20:46 ` Stephen Boyd
2013-10-30 20:46 ` Stephen Boyd
2013-11-13 22:07 ` Tomasz Figa [this message]
2013-11-13 22:07 ` Tomasz Figa
2013-10-31 16:59 ` Vinod Koul
2013-10-31 16:59 ` Vinod Koul
2013-10-31 21:46 ` Andy Gross
2013-10-31 21:46 ` Andy Gross
2013-11-07 23:03 ` Andy Gross
2013-11-07 23:03 ` Andy Gross
2013-11-13 13:18 ` Vinod Koul
2013-11-13 13:18 ` Vinod Koul
2013-11-13 21:03 ` Andy Gross
2013-11-13 21:03 ` Andy Gross
[not found] ` <1382732643-8184-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2013-10-25 20:24 ` [PATCH 2/2] dmaengine: msm_bam_dma: Add device tree binding Andy Gross
2013-10-25 20:24 ` Andy Gross
2013-10-25 20:24 ` Andy Gross
2013-10-25 21:31 ` Kumar Gala
2013-10-25 21:31 ` Kumar Gala
2013-10-25 23:20 ` Grant Likely
2013-10-25 23:20 ` Grant Likely
2013-10-25 23:20 ` Grant Likely
2013-10-29 6:18 ` Stephen Boyd
2013-10-29 6:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3732966.zLLfiChgvH@flatron \
--to=tomasz.figa@gmail.com \
--cc=agross@codeaurora.org \
--cc=bryanh@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=davidb@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.