All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: linux-parisc@vger.kernel.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 1/6] use linux/bitops.h instead of linux/log2.h to get fls()
Date: Sat, 21 Apr 2012 20:23:58 +0200	[thread overview]
Message-ID: <3739293.5fPmfJVmA0@donald.sf-tec.de> (raw)
In-Reply-To: <3154414.psmJh6J2U2@donald.sf-tec.de>

Since d66acc39c7cee323733c8503b9de1821a56dff7e (bitops: Optimise get_order())
getorder.h includes log2.h to get fls() and fls64(). They are not defined in
log2.h, but in bitops.h. This works since log2.h includes bitops.h, but we
should do it properly to not get any bad surprises if log2.h changes.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
 include/asm-generic/getorder.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/getorder.h b/include/asm-generic/getorder.h
index 65e4468..563114f 100644
--- a/include/asm-generic/getorder.h
+++ b/include/asm-generic/getorder.h
@@ -4,7 +4,7 @@
 #ifndef __ASSEMBLY__
 
 #include <linux/compiler.h>
-#include <linux/log2.h>
+#include <linux/bitops.h>
 
 /*
  * Runtime evaluation of get_order()
-- 
1.7.9.2

WARNING: multiple messages have this Message-ID (diff)
From: Rolf Eike Beer <eike-kernel@sf-tec.de>
From: <eike-kernel@sf-tec.de>
To: linux-parisc@vger.kernel.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>,
	Arnd Bergmann <arnd@arndb.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 1/6] use linux/bitops.h instead of linux/log2.h to get fls()
Date: Sat, 21 Apr 2012 20:23:58 +0200
Date: Sat, 21 Apr 2012 20:33:19 +0200	[thread overview]
Message-ID: <3739293.5fPmfJVmA0@donald.sf-tec.de> (raw)
Message-ID: <1335033199.699870@mail.sf-mail.de> (raw)
In-Reply-To: <3154414.psmJh6J2U2@donald.sf-tec.de>

Since d66acc39c7cee323733c8503b9de1821a56dff7e (bitops: Optimise get_order())
getorder.h includes log2.h to get fls() and fls64(). They are not defined in
log2.h, but in bitops.h. This works since log2.h includes bitops.h, but we
should do it properly to not get any bad surprises if log2.h changes.

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
 include/asm-generic/getorder.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/getorder.h b/include/asm-generic/getorder.h
index 65e4468..563114f 100644
--- a/include/asm-generic/getorder.h
+++ b/include/asm-generic/getorder.h
@@ -4,7 +4,7 @@
 #ifndef __ASSEMBLY__
 
 #include <linux/compiler.h>
-#include <linux/log2.h>
+#include <linux/bitops.h>
 
 /*
  * Runtime evaluation of get_order()
-- 
1.7.9.2


  parent reply	other threads:[~2012-04-21 18:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-21 17:52 [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer
2012-04-21 17:52 ` Rolf Eike Beer, eike-kernel
2012-04-21 18:15 ` [PATCH 3/6] parisc: add missing forward declarations in asm/hardware.h Rolf Eike Beer
2012-04-21 18:17 ` [PATCH 4/6] parisc: drop include of asm/pdc.h from asm/hardware.h Rolf Eike Beer
2012-04-24  1:34   ` Grant Grundler
2012-04-21 18:20 ` [PATCH 5/6] parisc: add missing include of asm/page.h to asm/pgtable.h Rolf Eike Beer
2012-04-21 18:22 ` [PATCH 6/6] parisc: move definition of PAGE0 to asm/page.h Rolf Eike Beer
2012-04-21 18:23 ` [PATCH 2/6] parisc: add missing includes in asm/spinlock.h Rolf Eike Beer
2012-04-21 18:23 ` Rolf Eike Beer [this message]
2012-04-21 18:23   ` [PATCH 1/6] use linux/bitops.h instead of linux/log2.h to get fls() Rolf Eike Beer, eike-kernel
2012-04-21 18:23 ` Rolf Eike Beer
2012-05-01 13:28 ` [PATCH 0/6] PA-RISC: fix compile Rolf Eike Beer
2012-05-10 20:49 ` [PATCH] use linux/bitops.h instead of linux/log2.h to get fls() Rolf Eike Beer
2012-05-12  9:53   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3739293.5fPmfJVmA0@donald.sf-tec.de \
    --to=eike-kernel@sf-tec.de \
    --cc=arnd@arndb.de \
    --cc=dhowells@redhat.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.