[PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc SoCs

[pramod.kumar@broadcom.com (Pramod Kumar)]

Hi David,

> -----Original Message-----
> From: David Miller [mailto:davem at davemloft.net]
> Sent: 02 June 2016 04:48
> To: pramod.kumar at broadcom.com
> Cc: robh+dt at kernel.org; pawel.moll at arm.com; mark.rutland at arm.com;
> ijc+devicetree at hellion.org.uk; galak at codeaurora.org;
> catalin.marinas at arm.com; will.deacon at arm.com; kishon at ti.com;
> devicetree at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
bcm-kernel-
> feedback-list at broadcom.com; linux-kernel at vger.kernel.org;
> netdev at vger.kernel.org
> Subject: Re: [PATCH v2 5/7] net:mdio-mux: Add MDIO mux driver for iProc
SoCs
>
> From: Pramod Kumar <pramod.kumar@broadcom.com>
> Date: Tue, 31 May 2016 19:06:39 +0530
>
> > +static int iproc_mdio_wait_for_idle(void __iomem *base, bool result)
> > +{
> > +	u32 val;
> > +	unsigned int timeout = 1000; /* loop for 1s */
>
> Please order your local variable declarations from longest to shortest
line.
>
> > +static int start_miim_ops(void __iomem *base,
> > +			  u16 phyid, u32 reg, u16 val, u32 op) {
> > +	int ret;
> > +	u32 param;
>
> Likewise.
>
Sure. I'll take care of this in next patch for all places.

> > +static int iproc_mdiomux_read(struct mii_bus *bus, int phyid, int
> > +reg) {
> > +	int ret;
> > +	struct iproc_mdiomux_desc *md = bus->priv;
>
> Likewise.
Sure. I'll take care of this in next patch for all places.

Regards,
Pramod