From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH/RFC] ARM: shmobile: Introduce ARCH_RENESAS
Date: Thu, 05 Nov 2015 08:43:31 +0000 [thread overview]
Message-ID: <3748528.BkhGxHFj5s@wuerfel> (raw)
In-Reply-To: <1446702397-24078-1-git-send-email-horms+renesas@verge.net.au>
On Thursday 05 November 2015 14:46:37 Simon Horman wrote:
> config PM_RCAR
> bool
> @@ -29,10 +31,11 @@ config ARCH_RMOBILE
> select SYS_SUPPORTS_SH_CMT
> select SYS_SUPPORTS_SH_TMU
>
> -menuconfig ARCH_SHMOBILE_MULTI
> +config ARCH_RENESAS
> bool "Renesas ARM SoCs" if ARCH_MULTI_V7
> depends on MMU
> select ARCH_SHMOBILE
> + select ARCH_SHMOBILE_MULTI
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select ARM_GIC
>
The patch looks mostly good to me, but please leave this as a
'menuconfig' rather than 'config'. I'd like to keep having one
Kconfig submenu for each mach-* directory, as most platforms
do today. We should really fix the ones that don't currently do
it like this.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH/RFC] ARM: shmobile: Introduce ARCH_RENESAS
Date: Thu, 05 Nov 2015 09:43:31 +0100 [thread overview]
Message-ID: <3748528.BkhGxHFj5s@wuerfel> (raw)
In-Reply-To: <1446702397-24078-1-git-send-email-horms+renesas@verge.net.au>
On Thursday 05 November 2015 14:46:37 Simon Horman wrote:
> config PM_RCAR
> bool
> @@ -29,10 +31,11 @@ config ARCH_RMOBILE
> select SYS_SUPPORTS_SH_CMT
> select SYS_SUPPORTS_SH_TMU
>
> -menuconfig ARCH_SHMOBILE_MULTI
> +config ARCH_RENESAS
> bool "Renesas ARM SoCs" if ARCH_MULTI_V7
> depends on MMU
> select ARCH_SHMOBILE
> + select ARCH_SHMOBILE_MULTI
> select HAVE_ARM_SCU if SMP
> select HAVE_ARM_TWD if SMP
> select ARM_GIC
>
The patch looks mostly good to me, but please leave this as a
'menuconfig' rather than 'config'. I'd like to keep having one
Kconfig submenu for each mach-* directory, as most platforms
do today. We should really fix the ones that don't currently do
it like this.
Arnd
next prev parent reply other threads:[~2015-11-05 8:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 5:46 [PATCH/RFC] ARM: shmobile: Introduce ARCH_RENESAS Simon Horman
2015-11-05 5:46 ` Simon Horman
2015-11-05 8:43 ` Arnd Bergmann [this message]
2015-11-05 8:43 ` Arnd Bergmann
2015-11-05 12:09 ` Simon Horman
2015-11-05 12:09 ` Simon Horman
2015-11-05 11:17 ` Sergei Shtylyov
2015-11-05 11:17 ` Sergei Shtylyov
2015-11-05 12:10 ` Simon Horman
2015-11-05 12:10 ` Simon Horman
2015-11-05 12:29 ` Sergei Shtylyov
2015-11-05 12:29 ` Sergei Shtylyov
2015-11-05 18:58 ` Geert Uytterhoeven
2015-11-05 18:58 ` Geert Uytterhoeven
2015-11-06 1:41 ` Simon Horman
2015-11-06 1:41 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3748528.BkhGxHFj5s@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.