From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wu, Jingjing" <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH]i40e: move the fdir_setup from dev_init to dev_configure
Date: Fri, 05 Dec 2014 17:13:58 +0100 [thread overview]
Message-ID: <3752546.1FjpsJa7G7@xps13> (raw)
In-Reply-To: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7CE9F6-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
> > In order not to affect the FVL's performance by default setting, this patch moves
> > the flow director initialization from i40e_pf_setup to i40e_dev_configure
> > according to the mode in fdir configure info.
> > Then the resources used for flow director will be only setup if it is enabled.
> >
> > Signed-off-by: jingjing.wu <jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> Acked-by: Helin Zhang <helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Applied
A lot of commit titles need rewording. This one is a good example to explain.
We don't need to see the function or structure names in a title.
The global idea is a lot more interesting and easy to read.
Here, I changed
i40e: move the fdir_setup from dev_init to dev_configure
to
i40e: setup flow director only if enabled
Thanks
--
Thomas
prev parent reply other threads:[~2014-12-05 16:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 15:40 [PATCH]i40e: move the fdir_setup from dev_init to dev_configure Jingjing Wu
[not found] ` <1417707623-25777-1-git-send-email-jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-04 20:28 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BCC1B-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-26 2:15 ` Cao, Min
2014-12-05 0:57 ` Zhang, Helin
[not found] ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A7CE9F6-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-05 16:13 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3752546.1FjpsJa7G7@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jingjing.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.