Re: [PATCH 03/33] drm/amdgpu/jpeg3: add additional ring reset error checking

["Sundararaju, Sathishkumar" <sathishkumar.sundararaju@amd.com>]

This patch is :-
Reviewed-by: Sathishkumar S <sathishkumar.sundararaju@amd.com>

On 7/12/2025 4:09 AM, Alex Deucher wrote:
> Start and stop can fail, so add checks.
>
> Fixes: 03399d0bff25 ("drm/amdgpu: Add ring reset callback for JPEG3_0_0")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Sathishkumar S <sathishkumar.sundararaju@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c
> index a24bd833d6442..5428930eafa3e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v3_0.c
> @@ -562,8 +562,12 @@ static int jpeg_v3_0_ring_reset(struct amdgpu_ring *ring,
>   	int r;
>   
>   	drm_sched_wqueue_stop(&ring->sched);
> -	jpeg_v3_0_stop(ring->adev);
> -	jpeg_v3_0_start(ring->adev);
> +	r = jpeg_v3_0_stop(ring->adev);
> +	if (r)
> +		return r;
> +	r = jpeg_v3_0_start(ring->adev);
> +	if (r)
> +		return r;
>   	r = amdgpu_ring_test_helper(ring);
>   	if (r)
>   		return r;