From: "Maxime Ripard" <mripard@kernel.org>
To: "Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Corbet" <corbet@lwn.net>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Robert Foss" <rfoss@kernel.org>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tvrtko Ursulin" <tursulin@ursulin.net>
Subject: Re: [PATCH v8 06/20] drm/display: hdmi-state-helper: Try subsampling in mode_valid
Date: Mon, 23 Feb 2026 10:58:40 +0000 [thread overview]
Message-ID: <37669584817bdca3d569e80047c94949@kernel.org> (raw)
In-Reply-To: <20260216-color-format-v8-6-5722ce175dd5@collabora.com>
On Mon, 16 Feb 2026 14:01:20 +0100, Nicolas Frattaroli wrote:
> drm_hdmi_connector_mode_valid assumes modes are only valid if they work
> with RGB. The reality is more complex however: YCbCr 4:2:0
> chroma-subsampled modes only require half the pixel clock that the same
> mode would require in RGB.
>
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
WARNING: multiple messages have this Message-ID (diff)
From: "Maxime Ripard" <mripard@kernel.org>
To: "Nicolas Frattaroli" <nicolas.frattaroli@collabora.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
kernel@collabora.com, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rockchip@lists.infradead.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Andrzej Hajda" <andrzej.hajda@intel.com>,
"Andy Yan" <andy.yan@rock-chips.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Harry Wentland" <harry.wentland@amd.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Jonas Karlman" <jonas@kwiboo.se>,
"Jonathan Corbet" <corbet@lwn.net>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Rob Herring" <robh@kernel.org>, "Robert Foss" <rfoss@kernel.org>,
"Rodrigo Siqueira" <siqueira@igalia.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Sandy Huang" <hjc@rock-chips.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tvrtko Ursulin" <tursulin@ursulin.net>
Subject: Re: [PATCH v8 06/20] drm/display: hdmi-state-helper: Try subsampling in mode_valid
Date: Mon, 23 Feb 2026 10:58:40 +0000 [thread overview]
Message-ID: <37669584817bdca3d569e80047c94949@kernel.org> (raw)
In-Reply-To: <20260216-color-format-v8-6-5722ce175dd5@collabora.com>
On Mon, 16 Feb 2026 14:01:20 +0100, Nicolas Frattaroli wrote:
> drm_hdmi_connector_mode_valid assumes modes are only valid if they work
> with RGB. The reality is more complex however: YCbCr 4:2:0
> chroma-subsampled modes only require half the pixel clock that the same
> mode would require in RGB.
>
>
> [ ... ]
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Thanks!
Maxime
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-02-23 10:58 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 13:01 [PATCH v8 00/20] Add new general DRM property "color format" Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 01/20] drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 02/20] drm: Add new general DRM property "color format" Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-23 16:17 ` Jani Nikula
2026-02-23 16:17 ` Jani Nikula
2026-02-24 9:03 ` Maxime Ripard
2026-02-24 9:03 ` Maxime Ripard
2026-02-24 14:38 ` Maxime Ripard
2026-02-24 14:38 ` Maxime Ripard
2026-02-16 13:01 ` [PATCH v8 03/20] drm: Add enum conversions for drm_color_format_enum Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-24 14:39 ` Maxime Ripard
2026-02-24 14:39 ` Maxime Ripard
2026-02-16 13:01 ` [PATCH v8 04/20] drm/bridge: Act on the DRM color format property Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 05/20] drm/display: hdmi-state-helper: Act on color format DRM property Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-24 14:41 ` Maxime Ripard
2026-02-24 14:41 ` Maxime Ripard
2026-02-16 13:01 ` [PATCH v8 06/20] drm/display: hdmi-state-helper: Try subsampling in mode_valid Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-23 10:58 ` Maxime Ripard [this message]
2026-02-23 10:58 ` Maxime Ripard
2026-02-16 13:01 ` [PATCH v8 07/20] drm/i915: Implement the "color format" DRM property Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 08/20] drm/amdgpu: Implement " Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 09/20] drm/rockchip: Add YUV422 output mode constants for VOP2 Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 10/20] drm/rockchip: vop2: Add RK3576 to the RG swap special case Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 11/20] drm/rockchip: vop2: Recognise 10-bit YUV422 as YUV format Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 12/20] drm/rockchip: vop2: Set correct output format for RK3576 YUV422 Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 13/20] drm/bridge: dw-hdmi-qp: Implement atomic_get_output_bus_fmts Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-22 10:42 ` Cristian Ciocaltea
2026-02-22 10:42 ` Cristian Ciocaltea
2026-02-23 11:21 ` Nicolas Frattaroli
2026-02-23 11:21 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 14/20] drm/rockchip: dw_hdmi_qp: Implement "color format" DRM property Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 15/20] drm/rockchip: dw_hdmi_qp: Set supported_formats platdata Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 16/20] drm/connector: Register color format property on HDMI connectors Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 17/20] drm/tests: hdmi: Add tests for the color_format property Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 18/20] drm/tests: hdmi: Add tests for HDMI helper's mode_valid Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 19/20] drm/tests: bridge: Add KUnit tests for bridge chain format selection Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 13:01 ` [PATCH v8 20/20] drm/bridge: Document " Nicolas Frattaroli
2026-02-16 13:01 ` Nicolas Frattaroli
2026-02-16 20:36 ` Randy Dunlap
2026-02-16 20:36 ` Randy Dunlap
2026-02-16 13:14 ` ✗ CI.checkpatch: warning for Add new general DRM property "color format" (rev5) Patchwork
2026-02-16 13:15 ` ✓ CI.KUnit: success " Patchwork
2026-02-16 13:31 ` ✗ CI.checksparse: warning " Patchwork
2026-02-16 13:51 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-16 13:55 ` ✓ i915.CI.BAT: " Patchwork
2026-02-16 15:33 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-16 16:04 ` ✓ i915.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37669584817bdca3d569e80047c94949@kernel.org \
--to=mripard@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=neil.armstrong@linaro.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=s.hauer@pengutronix.de \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=tursulin@ursulin.net \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.