Re: [PATCH 0/5] arm64: dts: rockchip: pinmux fixes and support for 2 adapters for Theobroma boards

From: "Heiko Stübner" <heiko@sntech.de>
To: "Rob Herring (Arm)" <robh@kernel.org>,
	Quentin Schulz <foss+kernel@0leil.net>,
	Quentin Schulz <quentin.schulz@cherry.de>
Cc: Farouk Bouabid <farouk.bouabid@theobroma-systems.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	Quentin Schulz <quentin.schulz@theobroma-systems.com>,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 0/5] arm64: dts: rockchip: pinmux fixes and support for 2 adapters for Theobroma boards
Date: Fri, 21 Feb 2025 11:07:37 +0100	[thread overview]
Message-ID: <3771836.RUnXabflUD@diego> (raw)
In-Reply-To: <f9b40055-bcb0-4245-b899-4c7890e81b20@cherry.de>

Hi Quentin,

Am Freitag, 21. Februar 2025, 11:01:44 MEZ schrieb Quentin Schulz:
> On 2/20/25 10:29 PM, Rob Herring (Arm) wrote:
> > On Thu, 20 Feb 2025 13:20:09 +0100, Quentin Schulz wrote:
> I believe this is a false positive due to the node suffix being -gpio? 
> If I change -gpio suffix to -pin, it doesn't complain anymore.
> 
> """
> diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts 
> b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
> index 08a11e4758413..249e50d64791e 100644
> --- a/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
> +++ b/arch/arm64/boot/dts/rockchip/px30-ringneck-haikou.dts
> @@ -196,7 +196,7 @@ sd_card_led_pin: sd-card-led-pin {
>   	};
> 
>   	uart {
> -		uart5_rts_gpio: uart5-rts-gpio {
> +		uart5_rts_pin: uart5-rts-pin {
>   			rockchip,pins =
>   			  <0 RK_PB5 RK_FUNC_GPIO &pcfg_pull_up>;
>   		};
> @@ -234,7 +234,7 @@ &uart0 {
>   };
> 
>   &uart5 {
> -	pinctrl-0 = <&uart5_xfer &uart5_rts_gpio>;
> +	pinctrl-0 = <&uart5_xfer &uart5_rts_pin>;
>   	rts-gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
>   	status = "okay";
>   };
> """
> 
> @Heiko, I guess you would like a warning-less DT :) I can send a v2 with 
> that change then if that works for you? I can wait a few days for other 
> reviews :)

that would be great - the v2.

We already had patches addressing the -gpio thing for other boards in the
past, so going to "-pin" is the preferred solution here.

Also, your patches are totally specific to Theobroma-boards, so just send
your v2 at your convenience - I don't really expect that much additional
outside review comments ;-) .

Heiko