All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rillian Grant <rillian.grant@gmail.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-leds@vger.kernel.org, lee@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes
Date: Tue, 13 Oct 2026 10:38:33 +0100	[thread overview]
Message-ID: <37Wk96VpSLOh-P0MeN457Q@gmail.com> (raw)
In-Reply-To: <sashiko-outbox-167402@kernel.org>

> [Severity: High]
> Is there a potential race condition here when multiple devices probe
> concurrently?
> 
> If two threads execute lm3643_add_dmi_leds() simultaneously (for example,
> during concurrent sysfs bind or async probe of two LM3643 devices matching
> the same DMI table), they both might pass the lockless
> software_node_fwnode(nodes[0]) check before either registers the nodes.

This condition is currently unreachable. It would require two LM3643
instances on the same DMI entry.

I'd be happy to add a static mutex if preferred, or alongside any future
DMI entry for a board with more than one LM3643.

-- 
Rillian Grant



  reply	other threads:[~2026-10-13  9:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-11 19:09 [PATCH v3 0/4] leds: flash: LM3643 dual LED flash driver Rillian Grant
2026-10-11 19:09 ` [PATCH v3 1/4] dt-bindings: leds: Document TI " Rillian Grant
2026-10-11 19:14   ` sashiko-bot
2026-10-12  9:51   ` Krzysztof Kozlowski
2026-10-11 19:09 ` [PATCH v3 2/4] leds: flash: Add support for the " Rillian Grant
2026-10-11 19:20   ` sashiko-bot
2026-10-13  9:31     ` Rillian Grant
2026-10-11 19:09 ` [PATCH v3 3/4] leds: flash: lm3643: Describe the LED of ACPI boards without LED nodes Rillian Grant
2026-10-11 19:20   ` sashiko-bot
2026-10-13  9:38     ` Rillian Grant [this message]
2026-10-11 19:09 ` [PATCH v3 4/4] leds: flash: lm3643: Describe the LED on the Lenovo ThinkPad X9-15 Gen 1 Rillian Grant
2026-10-11 19:15   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37Wk96VpSLOh-P0MeN457Q@gmail.com \
    --to=rillian.grant@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.