Re: [PATCH v3 2/4] leds: flash: Add support for the TI LM3643 dual LED flash driver

[Rillian Grant <rillian.grant@gmail.com>]

> [Severity: Low]
> This isn't a bug, but does this commit subject violate the subsystem naming
> conventions?
> 
> According to the LED subsystem guidelines, embedding subsystem subdirectory
> names like flash into the prefix hinders Git history categorization.
> Embedding implementation details can also create rigid and non-reusable
> drivers.
> 
> Could the driver name lm3643 be used in the prefix instead, such as
> "leds: lm3643: "?

Happy to switch to "leds: flash: lm3643:" across the series if there is
another revision, or for the maintainer to adjust when applying.

> [Severity: Medium]
> Does this sequence require a hardware startup delay after asserting the
> enable GPIO?
> 
> The lm3643_probe() function drives the HWEN GPIO high and then shortly after
> initiates an I2C regmap_read() to fetch the device ID. Failing to provide a
> programmatic delay (e.g., via usleep_range) might cause the I2C transfer to
> fail on platforms where the CPU executes the bus transaction before the
> hardware state machine and internal oscillator are fully initialized.
> 
> Could a small delay be added here to ensure the chip is ready for I2C
> traffic before the register read is attempted?

The LM3643 datasheet specifies no delay between HWEN high and I2C ready,
so I'd rather not add an arbitrary sleep.

-- 
Rillian Grant