From: Manu Gautam <mgautam@codeaurora.org>
To: Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Can Guo <cang@codeaurora.org>,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] phy: qcom-qmp: remove duplicate powerdown write
Date: Tue, 24 Dec 2019 09:09:59 +0530 [thread overview]
Message-ID: <37fc7e23-eb22-c6c9-ba71-b01992936030@codeaurora.org> (raw)
In-Reply-To: <20191223143046.3376299-3-vkoul@kernel.org>
On 12/23/2019 8:00 PM, Vinod Koul wrote:
> We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init()
> before invoking qcom_qmp_phy_configure() so remove the duplicate write.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/phy/qualcomm/phy-qcom-qmp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 1196c85aa023..4f2e65c7cf45 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = {
> };
>
> static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = {
> - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11),
> QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),
Reviewed-by: Manu Gautam <mgautam@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2019-12-24 3:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 14:30 [PATCH v3 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
2019-12-23 14:30 ` [PATCH v3 1/4] phy: qcom-qmp: Use register defines Vinod Koul
2019-12-24 3:41 ` Manu Gautam
2019-12-24 5:49 ` Can Guo
2019-12-23 14:30 ` [PATCH v3 2/4] phy: qcom-qmp: remove duplicate powerdown write Vinod Koul
2019-12-24 3:39 ` Manu Gautam [this message]
2019-12-24 5:56 ` Can Guo
2019-12-23 14:30 ` [PATCH v3 3/4] phy: qcom-qmp: remove no_pcs_sw_reset for sm8150 Vinod Koul
2019-12-24 3:39 ` Manu Gautam
2019-12-24 5:55 ` Can Guo
2019-12-23 14:30 ` [PATCH v3 4/4] phy: qcom-qmp: Add SW reset register Vinod Koul
2019-12-24 3:40 ` Manu Gautam
2019-12-24 5:55 ` Can Guo
2020-01-03 6:22 ` [PATCH v3 0/4] phy: qcom-qmp: Fixes and updates for sm8150 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37fc7e23-eb22-c6c9-ba71-b01992936030@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.