From: Arnd Bergmann <arnd@arndb.de>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Jon Medhurst <tixy@linaro.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Liviu Dudau <Liviu.Dudau@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
arm@kernel.org
Subject: Re: [PATCH] scpi: hide get_scpi_ops in module from built-in code
Date: Thu, 19 Nov 2015 16:23:31 +0100 [thread overview]
Message-ID: <3802372.zWzDBWFCTp@wuerfel> (raw)
In-Reply-To: <9hhoaespm8p.fsf@e105922-lin.cambridge.arm.com>
On Tuesday 17 November 2015 17:30:14 Punit Agrawal wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The scpi_clock driver can be built-in when CONFIG_COMPILE_TEST
> > is set even when ARM_SCPI_PROTOCOL is a loadable module, and
> > that results in a link error:
> >
> > drivers/built-in.o: In function `scpi_clocks_probe':
> > (.text+0x14453c): undefined reference to `get_scpi_ops'
> >
> > Using #if IS_REACHABLE() around the get_scpi_ops() declaration
> > makes it build successfully in this case for compile-testing,
> > but the effect is the same as when ARM_SCPI_PROTOCOL is
> > disabled, as the code will not be used.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Makes sense. Thanks, Arnd!
>
> Acked-by: Punit Agrawal <punit.agrawal@arm.com>
>
I've added it to arm-soc fixes now.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scpi: hide get_scpi_ops in module from built-in code
Date: Thu, 19 Nov 2015 16:23:31 +0100 [thread overview]
Message-ID: <3802372.zWzDBWFCTp@wuerfel> (raw)
In-Reply-To: <9hhoaespm8p.fsf@e105922-lin.cambridge.arm.com>
On Tuesday 17 November 2015 17:30:14 Punit Agrawal wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > The scpi_clock driver can be built-in when CONFIG_COMPILE_TEST
> > is set even when ARM_SCPI_PROTOCOL is a loadable module, and
> > that results in a link error:
> >
> > drivers/built-in.o: In function `scpi_clocks_probe':
> > (.text+0x14453c): undefined reference to `get_scpi_ops'
> >
> > Using #if IS_REACHABLE() around the get_scpi_ops() declaration
> > makes it build successfully in this case for compile-testing,
> > but the effect is the same as when ARM_SCPI_PROTOCOL is
> > disabled, as the code will not be used.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Makes sense. Thanks, Arnd!
>
> Acked-by: Punit Agrawal <punit.agrawal@arm.com>
>
I've added it to arm-soc fixes now.
Arnd
next prev parent reply other threads:[~2015-11-19 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 21:34 [PATCH] scpi: hide get_scpi_ops in module from built-in code Arnd Bergmann
2015-11-16 21:34 ` Arnd Bergmann
2015-11-17 17:30 ` Punit Agrawal
2015-11-17 17:30 ` Punit Agrawal
2015-11-19 15:23 ` Arnd Bergmann [this message]
2015-11-19 15:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3802372.zWzDBWFCTp@wuerfel \
--to=arnd@arndb.de \
--cc=Liviu.Dudau@arm.com \
--cc=arm@kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=punit.agrawal@arm.com \
--cc=sudeep.holla@arm.com \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.