All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: wens@kernel.org
Cc: pgwipeout@gmail.com, Furkan Kardame <f.kardame@manjaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add rk3566 audio nodes
Date: Tue, 10 Jan 2023 15:10:26 +0100	[thread overview]
Message-ID: <3835889.hdfAi7Kttb@diego> (raw)
In-Reply-To: <CAGb2v66RnP+Gk+3ZAVjb9Fde=+82BTaRuRCnuibbzQ84+FQU6w@mail.gmail.com>

Am Dienstag, 10. Januar 2023, 15:08:50 CET schrieb Chen-Yu Tsai:
> On Tue, Jan 10, 2023 at 10:05 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > On Mon, 9 Jan 2023 23:32:33 +0300, Furkan Kardame wrote:
> > > This patch adds simple audio card nodes
> > > Enabled i2s0_8ch as it is needed for hdmi audio
> > > Added i2s1_8ch as it is needed for 3.5mm audio jack
> > >
> > >
> >
> > Applied - with remarks below!
> >
> > [1/1] arm64: dts: rockchip: add rk3566 audio nodes
> >       commit: 9ce61898b3075892b01792fd3a44507b7e459c6f
> >
> >
> > The core i2s@fe410000 node should _not_ go into a board devicetree.
> > Thankfully an identical node for the i2s controller was already
> > added to the core rk356x dt, so I've just dropped the one from
> > your patch.
> 
> Shouldn't hdmi_sound also be enabled? Otherwise i2s0_8ch is enabled
> for nothing.

Furkan, care to send a patch for that?




_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: wens@kernel.org
Cc: pgwipeout@gmail.com, Furkan Kardame <f.kardame@manjaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add rk3566 audio nodes
Date: Tue, 10 Jan 2023 15:10:26 +0100	[thread overview]
Message-ID: <3835889.hdfAi7Kttb@diego> (raw)
In-Reply-To: <CAGb2v66RnP+Gk+3ZAVjb9Fde=+82BTaRuRCnuibbzQ84+FQU6w@mail.gmail.com>

Am Dienstag, 10. Januar 2023, 15:08:50 CET schrieb Chen-Yu Tsai:
> On Tue, Jan 10, 2023 at 10:05 PM Heiko Stuebner <heiko@sntech.de> wrote:
> >
> > On Mon, 9 Jan 2023 23:32:33 +0300, Furkan Kardame wrote:
> > > This patch adds simple audio card nodes
> > > Enabled i2s0_8ch as it is needed for hdmi audio
> > > Added i2s1_8ch as it is needed for 3.5mm audio jack
> > >
> > >
> >
> > Applied - with remarks below!
> >
> > [1/1] arm64: dts: rockchip: add rk3566 audio nodes
> >       commit: 9ce61898b3075892b01792fd3a44507b7e459c6f
> >
> >
> > The core i2s@fe410000 node should _not_ go into a board devicetree.
> > Thankfully an identical node for the i2s controller was already
> > added to the core rk356x dt, so I've just dropped the one from
> > your patch.
> 
> Shouldn't hdmi_sound also be enabled? Otherwise i2s0_8ch is enabled
> for nothing.

Furkan, care to send a patch for that?




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-01-10 14:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-09 20:32 [PATCH] arm64: dts: rockchip: add rk3566 audio nodes Furkan Kardame
2023-01-09 20:32 ` Furkan Kardame
2023-01-10 14:04 ` Heiko Stuebner
2023-01-10 14:04   ` Heiko Stuebner
2023-01-10 14:08   ` Chen-Yu Tsai
2023-01-10 14:08     ` Chen-Yu Tsai
2023-01-10 14:10     ` Heiko Stübner [this message]
2023-01-10 14:10       ` Heiko Stübner
2023-01-10 16:57       ` Furkan Kardame
2023-01-10 16:57         ` Furkan Kardame
2023-01-10 17:43         ` Heiko Stübner
2023-01-10 17:43           ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3835889.hdfAi7Kttb@diego \
    --to=heiko@sntech.de \
    --cc=f.kardame@manjaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=pgwipeout@gmail.com \
    --cc=wens@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.