From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 08/10] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb
Date: Tue, 24 Jul 2007 10:00:17 +0800 [thread overview]
Message-ID: <385243123.51698@ustc.edu.cn> (raw)
Message-ID: <20070724020042.882116065@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070724020009.677809022@mail.ustc.edu.cn
[-- Attachment #1: remove-readahead-size-limit.patch --]
[-- Type: text/plain, Size: 1300 bytes --]
Remove the size limit max_sectors_kb imposed on max_readahead_kb.
The size restriction is unreasonable. Especially when max_sectors_kb cannot
grow larger than max_hw_sectors_kb, which can be rather small for some disk
drives.
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
---
block/ll_rw_blk.c | 9 ---------
1 file changed, 9 deletions(-)
--- linux-2.6.22-rc6-mm1.orig/block/ll_rw_blk.c
+++ linux-2.6.22-rc6-mm1/block/ll_rw_blk.c
@@ -3945,7 +3945,6 @@ queue_max_sectors_store(struct request_q
max_hw_sectors_kb = q->max_hw_sectors >> 1,
page_kb = 1 << (PAGE_CACHE_SHIFT - 10);
ssize_t ret = queue_var_store(&max_sectors_kb, page, count);
- int ra_kb;
if (max_sectors_kb > max_hw_sectors_kb || max_sectors_kb < page_kb)
return -EINVAL;
@@ -3954,14 +3953,6 @@ queue_max_sectors_store(struct request_q
* values synchronously:
*/
spin_lock_irq(q->queue_lock);
- /*
- * Trim readahead window as well, if necessary:
- */
- ra_kb = q->backing_dev_info.ra_pages << (PAGE_CACHE_SHIFT - 10);
- if (ra_kb > max_sectors_kb)
- q->backing_dev_info.ra_pages =
- max_sectors_kb >> (PAGE_CACHE_SHIFT - 10);
-
q->max_sectors = max_sectors_kb << 1;
spin_unlock_irq(q->queue_lock);
--
next prev parent reply other threads:[~2007-07-24 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 2:00 [PATCH 00/10] readahead cleanups and interleaved readahead take 4 Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 01/10] readahead: compacting file_ra_state Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 02/10] readahead: mmap read-around simplification Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 3:52 ` Andrew Morton
2007-07-24 3:48 ` Fengguang Wu
2007-07-24 3:48 ` Fengguang Wu
2007-07-24 3:55 ` Andrew Morton
2007-07-24 4:32 ` Fengguang Wu
2007-07-24 4:32 ` Fengguang Wu
2007-07-24 4:53 ` Andrew Morton
2007-07-24 6:27 ` Fengguang Wu
2007-07-24 6:27 ` Fengguang Wu
2007-07-24 4:37 ` Fengguang Wu
2007-07-24 4:37 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 04/10] radixtree: introduce radix_tree_scan_hole() Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 05/10] readahead: basic support of interleaved reads Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 06/10] readahead: remove the local copy of ra in do_generic_mapping_read() Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 07/10] readahead: remove several readahead macros Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu [this message]
2007-07-24 2:00 ` [PATCH 08/10] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-24 2:00 ` [PATCH 09/10] filemap: trivial code cleanups Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
2007-07-24 2:00 ` [PATCH 10/10] filemap: convert some unsigned long to pgoff_t Fengguang Wu
2007-07-24 2:00 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=385243123.51698@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.