From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: R8A7779: add VIN pin groups
Date: Tue, 16 Apr 2013 09:09:42 +0000 [thread overview]
Message-ID: <3861427.7X66IM5gtB@avalon> (raw)
In-Reply-To: <201304120251.38652.sergei.shtylyov@cogentembedded.com>
Hi Sergei,
On Friday 12 April 2013 18:26:20 Sergei Shtylyov wrote:
> On 12-04-2013 8:33, Kuninori Morimoto wrote:
> > Thank you for your patch
>
> It's not mine. :-)
>
> >> +/* - VIN0
> >> ------------------------------------------------------------------- */
> >> +static const unsigned int vin0_data8_pins[] = {
> >> + /* D[0:7] */
> >> + 70, 71, 72, 73, 74, 75, 76, 77,
> >> +};
> >
> > Can you use RCAR_GP_PIN() macro on this patch ?
> >
> > 0bd898b16cdc0a4512d0b1af2fbe1174d217dd2d
> > (gpio-rcar: Add RCAR_GP_PIN macro)
>
> I think there should be a wholesale conversion patch for all this file.
The whole file has been converted already in tags/renesas-next-20130416. Could
you please rebase this patch on top of that tag and resubmit, with the
hardcoded pin numbers replaced with the RCAR_GP_PIN() macro ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-16 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-11 22:51 [PATCH] sh-pfc: R8A7779: add VIN pin groups Sergei Shtylyov
2013-04-12 4:33 ` Kuninori Morimoto
2013-04-12 6:40 ` Simon Horman
2013-04-12 8:15 ` Laurent Pinchart
2013-04-12 14:24 ` Sergei Shtylyov
2013-04-12 14:26 ` Sergei Shtylyov
2013-04-16 9:09 ` Laurent Pinchart [this message]
2013-04-16 14:02 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3861427.7X66IM5gtB@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.